From: Jonathan Cameron <jic23@kernel.org>
To: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Cc: gregkh@linuxfoundation.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org,
u.kleine-koenig@baylibre.com, joshua.crofts1@gmail.com,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: iio: adt7316: use kstrtobool() for sysfs boolean parsing
Date: Sat, 17 Oct 2026 23:17:47 +0100 [thread overview]
Message-ID: <20261017231747.4906975c@jic23-hlaptop> (raw)
In-Reply-To: <20261014091111.20059-1-abdelnasserhussein11@gmail.com>
On Wed, 14 Oct 2026 12:11:11 +0300
Abdelnasser Hussein <abdelnasserhussein11@gmail.com> wrote:
> Replace manual character checks (e.g., buf[0] == '1') with the standard
> kstrtobool() API in sysfs store functions.
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
> Signed-off-by: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Work on this driver always feels like we are dancing around a complete
mess. The thing needs radical modifications so most likely changes
like this are to code that will go away.
Still that doesn't mean small changes aren't going to help whoever
does that work read the driver more easily.
This looks fine to me, but given the potential issue with Josh's tag
I'll leave it until that is addressed. Perhaps I just missed an email!
Jonathan
next prev parent reply other threads:[~2026-10-17 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 9:11 Abdelnasser Hussein
2026-10-17 22:17 ` Jonathan Cameron [this message]
2026-10-18 6:22 ` Abdelnasser Hussein
2026-10-19 3:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261017231747.4906975c@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=abdelnasserhussein11@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®