mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: Arnav Kapoor <kapoorarnav43@gmail.com>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	David Lechner <dlechner@baylibre.com>,
	Andy Shevchenko <andy@kernel.org>,
	Rodrigo Alencar <rodrigo.alencar@analog.com>,
	linux@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: ad5686: fix channels member name in kernel-doc
Date: Sat, 17 Oct 2026 23:57:16 +0100	[thread overview]
Message-ID: <20261017235716.23df682e@jic23-hlaptop> (raw)
In-Reply-To: <atCSevvIuyomufQ5@nsa>

On Thu, 15 Oct 2026 09:45:00 +0100
Nuno Sá <nuno.sa@analog.com> wrote:

> On Sun, Oct 11, 2026 at 10:21:47AM +0530, Arnav Kapoor wrote:
> > The kernel-doc for struct ad5686_chip_info describes a member called
> > @channel, but the member is named channels. W=1 builds report:
> > 
> >   Warning: drivers/iio/dac/ad5686.h:95 struct member 'channels' not
> >   described in 'ad5686_chip_info'
> >   Warning: drivers/iio/dac/ad5686.h:95 Excess struct member 'channel'
> >   description in 'ad5686_chip_info'
> > 
> > Rename the entry to match the struct member.
> > 
> > Fixes: 0357e488b825 ("iio:dac:ad5686: Refactor the driver")
> > Assisted-by: LLM
> > Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
> > ---  
> 
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Applied.

> 
> > Comment-only change, checked with scripts/kernel-doc -Wall.
> > 
> >  drivers/iio/dac/ad5686.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/dac/ad5686.h b/drivers/iio/dac/ad5686.h
> > index 482bc70515f7..4f2ac1e96643 100644
> > --- a/drivers/iio/dac/ad5686.h
> > +++ b/drivers/iio/dac/ad5686.h
> > @@ -85,7 +85,7 @@ struct ad5686_bus_ops {
> >   * struct ad5686_chip_info - chip specific information
> >   * @int_vref_mv:	the internal reference voltage
> >   * @num_channels:	number of channels
> > - * @channel:		channel specification
> > + * @channels:		channel specification
> >   * @regmap_type:	register map layout variant
> >   */
> >  struct ad5686_chip_info {
> > -- 
> > 2.53.0
> >   


      reply	other threads:[~2026-10-17 22:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11  4:51 Arnav Kapoor
2026-10-11 15:09 ` Maxwell Doose
2026-10-15  8:45 ` Nuno Sá
2026-10-17 22:57   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261017235716.23df682e@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=kapoorarnav43@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=rodrigo.alencar@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®