mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>
Cc: "Arnav Kapoor" <kapoorarnav43@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: imu: inv_mpu6050: fix swapped accel and gyro startup times
Date: Sun, 18 Oct 2026 00:10:42 +0100	[thread overview]
Message-ID: <20261018001042.31f109bf@jic23-hlaptop> (raw)
In-Reply-To: <BE1P281MB14268B8ABA5134519916E673CE9F2@BE1P281MB1426.DEUP281.PROD.OUTLOOK.COM>


> > 	{
> > 		.whoami = INV_IAM20680HT_WHOAMI_VALUE,
> >@@ -311,7 +365,10 @@ static const struct inv_mpu6050_hw hw_info[] = {
> > 		.config = &chip_config_6500,
> > 		.fifo_size = 4 * 1024,
> > 		.temp = {INV_ICM20608_TEMP_OFFSET, INV_ICM20608_TEMP_SCALE},
> >-		.startup_time = {INV_MPU6500_GYRO_STARTUP_TIME, INV_MPU6500_ACCEL_STARTUP_TIME},
> >+		.startup_time = {
> >+			.accel = INV_MPU6500_ACCEL_STARTUP_TIME,
> >+			.gyro = INV_MPU6500_GYRO_STARTUP_TIME,
> >+		},
> > 	},
> > };
> > 
> >-- 
> >2.53.0
> >  
> 
> Hello Arnav,
> 
> another good catch, thanks for the patch.
Absolutely.  

If you fancy doing a follow up cleanup, lets reduce chance of similar
by using named initializers for .temp just above each of the changes
made in this patch.

No problem if you have moved onto other things!

Applied to the fixes-togreg branch of iio.git and marked for stable.

Jonathan

> 
> Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> 
> Thanks,
> JB

      reply	other threads:[~2026-10-17 23:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11  4:57 Arnav Kapoor
2026-10-12  7:54 ` Jean-Baptiste Maneyrol
2026-10-17 23:10   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261018001042.31f109bf@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=Jean-Baptiste.Maneyrol@tdk.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=kapoorarnav43@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®