From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp153-165.sina.com.cn (smtp153-165.sina.com.cn [61.135.153.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBF0233DEC0 for ; Sun, 18 Oct 2026 03:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=61.135.153.165 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792295678; cv=none; b=kkaU2PCrpQtHjxr+H15EO4rhR4/iPa+Qqomi12+hr45nRo/jLfFYa94X1K60DvifGUdFwBpphFlITahUhmCKdJE3GkJg48Hb5YJp6Mgx97Z5HYS9jtIZ28ok4EGUPdHJg8PA/nKEq5XPF2KE1NnodqkiBsaCDfdzykMvr3YYTww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792295678; c=relaxed/simple; bh=zFcwfzk4q8S7P/JRU+QaJoklDB3jg5Lx6JhYHfcGVN4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qUU99sVT1PkIdgXBzfmo4xmJWRgkAave2Gpo9CBFa7e9jErVdELn1+d54goIJ+JSe5sYP6FPoX4GR/EK7401VGI8r1qJrqoYt1RyicxsC9n68GIbFJnrGXnNqBp5rZlkpRaNEi9rc3MQGS6VV7w00Cji+5BRgD3Wy/fm0kNOLP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b=OI0P/8xu; arc=none smtp.client-ip=61.135.153.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b="OI0P/8xu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sina.com; s=201208; t=1792295671; bh=w4C2kASBcIhDMTznUIgytaJpWRdhNZM0Dne23YRvlME=; h=From:Subject:Date:Message-ID; b=OI0P/8xu2iBRIS6w36i6J0OmtAOX5Kj+8ls/n+Xze3/jk0X6SbpiTfR5F3GkI/xOY 5m53XVFw8dRv4/N7Tc8c5dgnv+FBXBfKO/XjZAcKLVjqf1oRT8nkAI2oqt9VQC5YmE zrQLZ/IW9MOLB4D3zFnTR0chs9WtSyRwV234R+PQ= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.254.3.234]) by sina.com (10.54.253.32) with ESMTP id 6AD442EA00002C78; Sun, 18 Oct 2026 11:54:21 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 9146694456836 X-SMAIL-UIID: 8384FFC0A8B24B719C454D185D6068AB-20261018-115421-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [nvme?] BUG: corrupted list in nvmet_fc_remove_port Date: Sun, 18 Oct 2026 11:54:08 +0800 Message-ID: <20261018035409.695-1-hdanton@sina.com> In-Reply-To: <6acbc835.a150a118.27e199.003c.GAE@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > Date: Sun, 11 Oct 2026 10:32:37 -0700 [thread overview] > Hello, > > syzbot found the following issue on: > > HEAD commit: a5ebb76233b7 Merge tag 'edac_urgent_for_v7.3_rc7' of git:/.. > git tree: upstream > console+strace: https://syzkaller.appspot.com/x/log.txt?x=1494923e580000 > kernel config: https://syzkaller.appspot.com/x/.config?x=df4bbab1c2172b9f > dashboard link: https://syzkaller.appspot.com/bug?extid=c98b21427617af7f547a > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=126a0f15580000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=166a0f15580000 #syz test --- x/drivers/nvme/target/fc.c +++ y/drivers/nvme/target/fc.c @@ -113,6 +113,7 @@ struct nvmet_fc_tgtport { struct nvmet_fc_port_entry *pe; struct kref ref; u32 max_sg_cnt; + int assoc_freed; }; struct nvmet_fc_port_entry { @@ -1271,9 +1272,17 @@ nvmet_fc_portentry_bind(struct nvmet_fc_ static void nvmet_fc_portentry_unbind(struct nvmet_fc_port_entry *pe) { + struct nvmet_fc_port_entry *entry; unsigned long flags; spin_lock_irqsave(&nvmet_fc_tgtlock, flags); + list_for_each_entry(entry, &nvmet_fc_portentry_list, pe_list) { + if (entry == pe) + goto out; + } + spin_unlock_irqrestore(&nvmet_fc_tgtlock, flags); + return; +out: if (pe->tgtport) { nvmet_fc_tgtport_put(pe->tgtport); pe->tgtport->pe = NULL; @@ -1474,14 +1483,20 @@ static void __nvmet_fc_free_assocs(struct nvmet_fc_tgtport *tgtport) { struct nvmet_fc_tgt_assoc *assoc; + unsigned long flags; + if (tgtport->assoc_freed) + return; + tgtport->assoc_freed = 1; rcu_read_lock(); + spin_lock_irqsave(&tgtport->lock, flags); list_for_each_entry_rcu(assoc, &tgtport->assoc_list, a_list) { if (!nvmet_fc_tgt_a_get(assoc)) continue; nvmet_fc_schedule_delete_assoc(assoc); nvmet_fc_tgt_a_put(assoc); } + spin_unlock_irqrestore(&tgtport->lock, flags); rcu_read_unlock(); } @@ -1643,8 +1658,10 @@ nvmet_fc_unregister_targetport(struct nv nvmet_fc_portentry_unbind_tgt(tgtport); + spin_lock_irqsave(&nvmet_fc_tgtlock, flags); /* terminate any outstanding associations */ __nvmet_fc_free_assocs(tgtport); + spin_unlock_irqrestore(&nvmet_fc_tgtlock, flags); flush_workqueue(nvmet_wq); @@ -2917,6 +2934,7 @@ nvmet_fc_remove_port(struct nvmet_port * { struct nvmet_fc_port_entry *pe = port->priv; struct nvmet_fc_tgtport *tgtport = NULL; + struct nvmet_fc_tgtport *next = NULL; unsigned long flags; spin_lock_irqsave(&nvmet_fc_tgtlock, flags); @@ -2926,9 +2944,11 @@ nvmet_fc_remove_port(struct nvmet_port * nvmet_fc_portentry_unbind(pe); - if (tgtport) { + if (tgtport && next) { + spin_lock_irqsave(&nvmet_fc_tgtlock, flags); /* terminate any outstanding associations */ __nvmet_fc_free_assocs(tgtport); + spin_unlock_irqrestore(&nvmet_fc_tgtlock, flags); nvmet_fc_tgtport_put(tgtport); } --