mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Francisco Beltrán Millalén" <fbeltranmillalen@gmail.com>
To: mika.westerberg@linux.intel.com
Cc: helgaas@kernel.org, bhelgaas@google.com,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	andreas.noever@gmail.com, westeri@kernel.org,
	YehezkelShB@gmail.com, lukas@wunner.de,
	linux-usb@vger.kernel.org, d@rrell.co
Subject: Re: [PATCH] PCI: Extend Apple Thunderbolt power quirk to Alpine Ridge
Date: Sun, 18 Oct 2026 10:29:20 -0300	[thread overview]
Message-ID: <20261018132920.7407-1-fbeltranmillalen@gmail.com> (raw)
In-Reply-To: <20261016052503.GT176164@black.igk.intel.com>

Hi Mika,

On Fri, Oct 16, 2026 at 07:25:03AM +0200, Mika Westerberg wrote:
> Unfortunately I can't expose any of the non-public bits without going
> through an extensive paper work.

No problem.  I'll describe bit 26 in the patch only by what I measured:
with it set, SXFP() really powers the controller off and Linux does not
bring it back on resume; with it clear, the controller resumes fine.

> I can comment on the ACPI bits, though. I think they can be put into
> drivers/thunderbolt/acpi.c if they are strictly TB specific.

That makes sense to me.  I'll move both parts into drivers/thunderbolt:
calling SXFP() on suspend, and clearing bit 26 just before it.  I'll
test it the same way as the PCI version, with a USB disk attached
across suspend, and send it as a new patch when it works.

Bjorn, that new patch would replace this one, and nothing would be
left to change in drivers/pci for Alpine Ridge.  So please drop this
version.

Thanks,
Francisco

      reply	other threads:[~2026-10-18 13:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 13:28 Francisco Beltrán Millalén
2026-10-08 18:55 ` Darrell Gum
2026-10-09  2:51   ` Francisco Beltrán Millalén
2026-10-08 23:17 ` Bjorn Helgaas
2026-10-09  2:50   ` Francisco Beltrán Millalén
2026-10-16  5:25     ` Mika Westerberg
2026-10-18 13:29       ` Francisco Beltrán Millalén [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261018132920.7407-1-fbeltranmillalen@gmail.com \
    --to=fbeltranmillalen@gmail.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=d@rrell.co \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®