From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADE6F4A2A4A for ; Sun, 18 Oct 2026 13:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792331382; cv=none; b=CirRn31hn6VugMiPAwqutbYlfqb3D+GIN3TGOCOgIMzVngrsfaevAZ8XMXahYvdH5tQ8c947NrFkOOnb5LwFbNN1nqnrhkqL48vM5rSCJhOTUdyz7zc0gA1pQhea/9Ls71YLcp7T6ubiAflafSBQ8OduwdLoCm9xb/MUOqu46BE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792331382; c=relaxed/simple; bh=XS1hfUYBh3IHnLjqYMLanotOueCfYEigxxyKMp4yttk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o2A7V7T7P3WZKVgy3vVnoV7eRdAgiM8wt7YdFf+E9iIUgMbqyYpPppLU3vg1YbbEwsMogr3ZU9WGb1xgct8DzgTA5SN0aVuSiNNgm3IbhYrINZ2AXp/r8Ya24DZEHfo5knLCHOpsXYuqKGLUX7XtXT3nwsWv1Y/0L/vkd58SWvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uj8PuAXi; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uj8PuAXi" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-c38ac26cc5dso176401666b.2 for ; Sun, 18 Oct 2026 06:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792331377; x=1792936177; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XrgtN1CfIC918YQEqPq2f1RcPZ7legyk//5piQ8+dDY=; b=Uj8PuAXiQssCE/myuDDwafEFSpeV340x80XfFsgxdHrd+PxxleJDzx/TwHIqlmwp4+ 8U4EVOrpnDpIQzUtjR8WWuzvtCRYNuGT0Onwt0GFEtMjwhJCAWZ5oDRDiEYWU94zswH9 eGpZyurIuSwm9/7UxN341UmN0YhqrCCxpXuqDAW8VNmxZLRybHX57+nEUInhfMYWuv0P AOqgdcbaBwTi8kE0dSCna0saVPC8w/fI6Gif77TBMUZKz9PZIukq7rmtHjQP3mzfhz9X Qw334Mx4BsYcPajENS3EoMN4L8CAbMkUb7El4VjE2Xc//oXymNaqMZJnj7P/rC7XfXOV z8IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792331377; x=1792936177; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XrgtN1CfIC918YQEqPq2f1RcPZ7legyk//5piQ8+dDY=; b=LFbrKSksifkYNgnDSmY5UJki2qdqgNaUHGaS5YzUYpJ14C1pI692DF2TD94VpVcLr3 xS2CCfv7l6wxQ+3DYHBNAwmX2t8VM5iv/ugDjfEK2M/IbnU/ny7t5MwiWtndmUqVbwiQ R8toTj/w8kkq9rlfqxuafLvwiStTr94JSi80VrcwJhzr1V1MQaA+WCabQEbCgIVXy4RQ Hc1Aqba1EXSgTbYdMj1ESy7leb9V/H2Nvg8kQg0DFURDWuaRJ5M53P6nQa2L+NxSGeWW M6XDmhcZxw4FGBnSnT7jIbM//N/ZnhjxpyWVOrq39nSddnnxAmwS1lxulGRyt84rPdcw CVDw== X-Gm-Message-State: AFq9FYKQl/eKyrbfgPnHSzxnZlfEZ6/f5wY3PTQPDi71z1D2Mseu6db4 JNMCCfZDLmBveQg9FPE1jS4AxLghp+uez/6cVipFVzi66Br5Rg6hnlwy X-Gm-Gg: AYBFou2QtXh/+31TN5MOYI3mhU+6tEHk3y0FALEX3Y7RllS63SK2ePhiD0ykgksvg+f /QsoSQV/CUnWRPdY5GmFnYF3vh5PblYYqgX8F1akGS0lv4HBC6lr2nIK8TfzcY65btW/xhk0C7K jf/DN4KxFJiCVaRLW8ofv6MVSv4kOPINTWfs5mrrCNq5hmfnHxUyFFdIUzvLIxBKBKaHj9nWKT+ 8uUl9bNTbizDwTXXvMSlczkA64BM5CxXv5GzXoa2S4LQIdhVFvqi8IWMsrX3y074e/MMWSM8+j4 KZgDzIsoRGu7gTxTonbizrkxkXzAo3HHnwhg0mSqw9gsjZHH9x0RQAJJWgPzPMnRVHVxWNkzUWB AACF92ZTqsF8JiUMzJpJHzVCE9RB3bi56msestRoOqjpnU++pYZiTbmF3eOvkkQTvmt8VetJpxr KAu4sLC3kpk4uYGeTVDdUFSFV5ilnbKcnCOsNk8nZDA/gO/50zveU0fMb7o13emv8kq9dmVvm9a M1ATXWSjVJXOWiHS9c1GDXHqSxCsT/Vl/luHcQIpVRck+VHlQg= X-Received: by 2002:a17:907:c605:10b0:c42:a326:78a9 with SMTP id a640c23a62f3a-c42a3267e26mr126187466b.42.1792331376760; Sun, 18 Oct 2026 06:49:36 -0700 (PDT) Received: from buildhost.darklands.se ([2001:9b1:ff:d701:51eb:176f:63d9:53f8]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c40919c0402sm267678266b.61.2026.10.18.06.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 06:49:35 -0700 (PDT) From: Magnus Lindholm To: davem@davemloft.net, andreas@gaisler.com, sparclinux@vger.kernel.org Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, krzk@kernel.org, oleg@redhat.com, linmag7@gmail.com Subject: [PATCH v4 04/10] sparc64: stop IRQ setup when descriptor allocation fails Date: Sun, 18 Oct 2026 15:45:06 +0200 Message-ID: <20261018134738.1016106-5-linmag7@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261018134738.1016106-1-linmag7@gmail.com> References: <20261018134738.1016106-1-linmag7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit irq_alloc() returns zero on failure, but build_irq() then configures IRQ 0, which is reserved for the timer, as a device interrupt. Halt before publishing the IRQ or changing its descriptor, matching the existing fatal handler-data allocation path. Returning zero would let callers continue treating the timer IRQ as a valid device interrupt. Fixes: 8047e247c899 ("[SPARC64]: Virtualize IRQ numbers.") Signed-off-by: Magnus Lindholm --- arch/sparc/kernel/irq_64.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/sparc/kernel/irq_64.c b/arch/sparc/kernel/irq_64.c index 3f55c69d5f3b..4cceeba726ab 100644 --- a/arch/sparc/kernel/irq_64.c +++ b/arch/sparc/kernel/irq_64.c @@ -619,6 +619,10 @@ unsigned int build_irq(int inofixup, unsigned long iclr, unsigned long imap) irq = bucket_get_irq(__pa(bucket)); if (!irq) { irq = irq_alloc(0, ino); + if (!irq) { + prom_printf("IRQ: cannot allocate interrupt descriptor.\n"); + prom_halt(); + } bucket_set_irq(__pa(bucket), irq); irq_set_chip_and_handler_name(irq, &sun4u_irq, handle_fasteoi_irq, "IVEC"); -- 2.43.0