mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
	Arnav Kapoor <kapoorarnav43@gmail.com>,
	Joshua Crofts <joshua.crofts1@gmail.com>,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	David Lechner <dlechner@baylibre.com>,
	Nuno Sa <nuno.sa@analog.com>, Andy Shevchenko <andy@kernel.org>,
	chrome-platform@lists.linux.dev, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: common: cros_ec_sensors: use sensor_scale union member for CALIBSCALE
Date: Sun, 18 Oct 2026 19:09:02 +0100	[thread overview]
Message-ID: <20261018190902.6f0466c3@jic23-hlaptop> (raw)
In-Reply-To: <atRvqJiiAjjfbDcE@google.com>

On Sun, 18 Oct 2026 07:05:12 +0000
Tzung-Bi Shih <tzungbi@kernel.org> wrote:

> On Sun, Oct 18, 2026 at 12:02:06AM +0100, Jonathan Cameron wrote:
> > On Tue, 13 Oct 2026 22:55:27 +0300
> > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> >   
> > > On Tue, Oct 13, 2026 at 02:47:30AM +0530, Arnav Kapoor wrote:  
> > > > On Sun, 11 Oct 2026 19:16:41 +0200, Joshua Crofts wrote:    
> > > > > Please add a Fixes tag. Otherwise looks good to me!
> > > > >
> > > > > Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>    
> > > > 
> > > > Thanks for the review. The mismatch was introduced when CALIBSCALE
> > > > support was added:
> > > > 
> > > > Fixes: ed1f2e85da79 ("iio: cros_ec: Add calibscale for 3d MEMS")
> > > > 
> > > > Jonathan, could you pick this up when applying, or would you prefer a v2?    
> > > 
> > > No need to resend, `b4` will scan the whole email thread for the tags.  
> > If it could put them in the right order for 'late' fixes tags it would
> > be perfect (easy fix though so don't resend!)  
> > >   
> > 
> > This driver tends to be well maintained so whilst I'm fine
> > with the change I'll wait a bit for a tag from one of the maintainers.  
> 
> Sorry for the delay, I somehow missed this in my inbox.
> 
> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Thanks!

Applied to the fixes-togreg branch of iio.git.
I considered taking this one the slow path given it 'works' today
but given we are very early in the cycle seems nicer to just get
it cleaned up.

I dropped the Assisted-by LLM bit given guidance on that has
changed again since this was sent.

Jonathan



      reply	other threads:[~2026-10-18 18:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11  4:54 Arnav Kapoor
2026-10-11 17:16 ` Joshua Crofts
2026-10-12 21:17   ` Arnav Kapoor
2026-10-13 19:55     ` Andy Shevchenko
2026-10-17 23:02       ` Jonathan Cameron
2026-10-18  7:05         ` Tzung-Bi Shih
2026-10-18 18:09           ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261018190902.6f0466c3@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=dlechner@baylibre.com \
    --cc=groeck@chromium.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=kapoorarnav43@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®