From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7568C3DBD76; Sun, 18 Oct 2026 20:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792354862; cv=none; b=grVE+b9cgq/bJ6vHSHw28Hac79hMGAqKlBkLf9L5tVNmWWv04eUUvFB8J1WRka/YZk8/Xq7krVLpH9NzCnkCkp3BYiroGuWgv1dpATTPeL1CVizbpQ8dXb2p5uK3HL5yOUu9yBVcQPj2nLWf5w59H5qpeVj+dr98nmoV590/+30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792354862; c=relaxed/simple; bh=ytUJ1qQODw6q6S66trjDvYnTe6DClcfAtKnyEJUGY+U=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k/0+tICogdy1aRODdMzm4T7GY2iQ0a/XbtV8BjeyjcZ7jSXXPo8kh2jkrPGkJgsewDHjoeIU4JVEq1JysqFXTboXAZ+hHABYPnmc/dKX1fwtwjFuQLh56SUVbdk44W02fTEB9x98VN5Iaml3VN+Z4eqQAKL/s3Ie0AwU5Tn+U3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DN42uhjs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DN42uhjs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF8DC1F000C4; Sun, 18 Oct 2026 20:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792354861; bh=K3vg7IqzjZiEQ62NPia2RyXT3ORHAoyMO+p50jGOtZw=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=DN42uhjssBH86VQizcq5jBM/pAM5XiupkNkSlWnHTZxjUsb17kYByLHKkxkkceroo Ospc1wcLZnHmMoXh1HlQRyFFxqPGFFU7JM6McYvhA5pIvd4QC5En9m+/bv78D9AbM4 VSPnCQY3CvOQ+E5u0Pq585FUTBtl5lnIZ1dxUDGTy676NAnSUxOUA5bOZo8mAE6hG8 tERVSLls3RlCTRXt2jduw6obubdpKJzCfP8d2e6wSMtNZ496KeFMxiUHml7n0uGFBG fZhlV6uCZfK7c7TdDI5YZs421v85yOpSn6eua6appsTGcMuVrwpQLq8WjwkwY3t3/e 5xeOZjueFgFRA== Date: Sun, 18 Oct 2026 21:20:53 +0100 From: Jonathan Cameron To: Fabrice Gasnier Cc: Brian Norris , "Rafael J. Wysocki" , , , Andy Shevchenko , Alexandre Torgue , Nuno =?UTF-8?B?U8Oh?= , , David Lechner , Maxime Coquelin , , Fabrice Gasnier , Subject: Re: [PATCH 5/5] iio: adc: stm32-adc: Drop runtime_idle() Message-ID: <20261018212053.66b7ba14@jic23-hlaptop> In-Reply-To: <39d56818-922f-488e-842d-19a194654921@foss.st.com> References: <20261002230714.507921-1-briannorris@chromium.org> <20261002160309.5.Ica1e32ae51d7975844386684d2b6a097f3ca9122@changeid> <39d56818-922f-488e-842d-19a194654921@foss.st.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 6 Oct 2026 14:42:51 +0200 Fabrice Gasnier wrote: > On 10/3/26 01:03, Brian Norris wrote: > > This runtime_idle() implementation was added in commit c537d3457542 ("iio: > > adc: stm32-adc: fix runtime autosuspend delay when slow polling"), to work > > around a suboptimal behavior in the runtime PM core. It should no longer > > be necessary as of "PM: runtime: Propagate last_busy from dependent to > > dependency". > > > > Cc: Jonathan Cameron > > Cc: Fabrice Gasnier > > Cc: Ulf Hansson > > Signed-off-by: Brian Norris > > --- > > I do not have these devices to test. I have tested other drivers, and I've > > verified this behavior in unit tests as well. > > Hi Brian, > > I've been able to reproduce on stm32 earlier behavior by applying this patch only. > With the full series, so far, everything seems fine from my point of view. > > I haven't deeply inspected all the series, at least for the stm32-adc driver, you can add my: > > Tested-by: Fabrice Gasnier > I'm fine with this going through whatever tree you like Acked-by: Jonathan Cameron It seems unlikely to cause merge conflicts with other changes to that driver, but might be worth an immutable branch, just in case. > Thanks, > Best Regards, > Fabrice > > > > > drivers/iio/adc/stm32-adc-core.c | 9 +-------- > > 1 file changed, 1 insertion(+), 8 deletions(-) > > > > diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c > > index a42d82d61cb8..e9e113a46ccf 100644 > > --- a/drivers/iio/adc/stm32-adc-core.c > > +++ b/drivers/iio/adc/stm32-adc-core.c > > @@ -836,17 +836,10 @@ static int stm32_adc_core_runtime_resume(struct device *dev) > > return stm32_adc_core_hw_start(dev); > > } > > > > -static int stm32_adc_core_runtime_idle(struct device *dev) > > -{ > > - pm_runtime_mark_last_busy(dev); > > - > > - return 0; > > -} > > - > > static DEFINE_RUNTIME_DEV_PM_OPS(stm32_adc_core_pm_ops, > > stm32_adc_core_runtime_suspend, > > stm32_adc_core_runtime_resume, > > - stm32_adc_core_runtime_idle); > > + NULL); > > > > static const struct stm32_adc_priv_cfg stm32f4_adc_priv_cfg = { > > .regs = &stm32f4_adc_common_regs, >