From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Guixiong Wei <weiguixiong@bytedance.com>,
Tony Luck <tony.luck@intel.com>,
Muralidhara M K <muralidhara.mk@amd.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] EDAC/mce_amd: Add missing long names for SMCA bank types
Date: Sun, 18 Oct 2026 18:34:31 -0400 [thread overview]
Message-ID: <20261018223431.GA3236@yaz-khff2.amd.com> (raw)
In-Reply-To: <20261017195145.GAatPR0dQVZGEMHglh@fat_crate.local>
On Sat, Oct 17, 2026 at 12:51:45PM -0700, Borislav Petkov wrote:
> On Mon, Oct 12, 2026 at 10:03:30AM -0400, Yazen Ghannam wrote:
> > These were intentionaly left out as it as it seems users have been
> > moving to user space decode tools.
>
> You're making the old mistake:
>
> a. a naked MCE record in dmesg, you have to open the PPRs and actually decode
> it by hand. Or use a tool but most of the time, that tool is not updated with
> the latest error definitions, and you need the exact machine info in order for
> the tool to decode properly, yadda yadda...
>
> b. Get a fully decoded error string in dmesg.
>
> What is better: a) or b) ?
>
"a" is better.
The same "is not updated with the latest error definitions" applies to
the kernel.
And it's usually easier to update tools than patch the kernel (and also
deal with backporting, etc.).
In any case, this patch isn't about error descriptions. It's only about
adding the names for some bank types.
The bank types were added three years ago. AFAIK, the missing names
haven't been an issue. So I'm curious if this patch is actually fixing a
problem. If so, then that's fine.
Thanks,
Yazen
next prev parent reply other threads:[~2026-10-18 22:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 2:04 Guixiong Wei
2026-10-09 5:07 ` Borislav Petkov
2026-10-12 14:03 ` Yazen Ghannam
2026-10-17 19:51 ` Borislav Petkov
2026-10-18 22:34 ` Yazen Ghannam [this message]
2026-10-18 23:07 ` Borislav Petkov
2026-10-19 2:16 ` Guixiong Wei
2026-10-19 4:19 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261018223431.GA3236@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muralidhara.mk@amd.com \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=weiguixiong@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®