From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425153E172B for ; Sun, 18 Oct 2026 23:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792366032; cv=none; b=uuTFLAHBqpENZeqcrnqfAm+gmdEFFvUG58Lw2KVxYxVN/DMMoMVmiwIqqIDWk3UBAZrQGi9CZadBwws3op5p+14seXDAKIkuy/SQ6JZbVW16UoD+kucjKcK/WKJeXCoXM1bL5TRoTCldEfSfYgF2LGYr8CLjvM7RuuzD1UgLbZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792366032; c=relaxed/simple; bh=2KCYfLt5qJEmI2+WklOncv4iJAcjrI56HEp0rR9tV7Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iUeXM5Gw3hdnoXIfzwTVbbdcuGPw/D/xEEoumGUBWMutaiRTcyEwAmXQ61InuYzZezbCFWClLxA7lY/Ezelw58p5IPVWa5V6xv77oX6/7sx0LoCmX3MiEepDYkVk/NfmZACJemnjxAd202sh+9tlZsezQQbiKWBGqZbBvYh5Xjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KgZaHz+D; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KgZaHz+D" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-35cd4e8bdbdso3815632eec.1 for ; Sun, 18 Oct 2026 16:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792366029; x=1792970829; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=J5TdL2Y2ZbBg8GY/uY0EyJ065wBCuX4tK3r2mB1aNq4=; b=KgZaHz+D08IdWnVzWH67c1oxo2wjsiCe5c+KnxaH15G1S2lzu6sHAk2GHeB/riBYUU ucTNFFgwCYr658NWacdCcQ9yP13+47qQ4t6maG0G4kufpH3Z0IQ3epki1945+PBqeHQP Dbk751bWYhw+2HMMUctj+nPuv8VcooZkf81TSQNsqHcxUYQaG5T6IikOn8On+KfDtfyZ fD3O80CHF6+wfrFNapUwtWr+GIQyoAqqkZeq5dcQVixBmPXG9LpKwIpdYFdEa6DbAvj/ 89BLAXDfRkN9FSUBwhiHvJx7xL8L64a8dY3oKL5eAqr9ckIiEGl6VUIsD6cV/EduHaK4 Jh6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792366029; x=1792970829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=J5TdL2Y2ZbBg8GY/uY0EyJ065wBCuX4tK3r2mB1aNq4=; b=i4o7kHGlO8J1n3ybuo8mMoNlBK/CzhO6NtSapfBaL4v5hPoJKuLv8weDfssN57k5ae fLFonKy+Iyvx5rw04FKB3h92ZLYaYnMQfju/tLif1aWiSQETMpWB0yb13yDmmm3YfJDr X7PT9vmnKLJCsbvtjwVI07ukFEnwYLDz7DVYonA8pxxfuKzsT6XaeUYPWnYSNMfYd5xB z4WZF5GCkH95xlOCadOhEnC3//EgWAXyMJ+MdVLaxx/7r/4OhJo2HxB7xtoLL4T4k5O7 CN9gOYgxVLR3mkIZC9rmQSSNHPQJJNCE6cRzOTWHIQlUn05n//sj/zPSpp5J5E4Tm9Cv rlyw== X-Forwarded-Encrypted: i=1; AKwUvBzTJ13QKeSBlROQ4JYAwIKTtfa3xEUsqAmMToFqm27eFWt3JNKwj1A86lIjdw7Ad81OtLl1oP+NksGxWww=@vger.kernel.org X-Gm-Message-State: AFq9FYLENqXLHl9reK79qs4xM0nsOTcusXcjz7tKrH/aflsnLH2BfpEl DP88i3brlHK3p3cJ0kQDU3vg3sahPZsAU0p4/q8qIFADHDMQCueK/kqu X-Gm-Gg: AYBFou17zTEs2360Bi83eYM52m+CM6GZdP/Hh7UxG/M6bjMZsFqdtoj6IOv9gkCo1fd egQEk5LMz+NhgcAtn2bdzJmOVo559hf79UmRBaJ7x94SAEr2kWpgc15fLpsAsNh3gMiBpz+C/W2 X5zWsT7mxDZknZB41g2xC1NDbcCNL7kps7w7qts797VSRVG3T4OVhWKxWyjXN01OmcCEMAxNuQj m7q6HcRO8NkXWO1mgIzqiiSywnd0yq1ztWWb8ruqg20mOi+fXXWHdWtkBxAtVrDcLh03Wu7vRys /zgRc2LQBYEWaQVUm+YU9pJMnc+2EFpncHmGq9Mn5tJgPDr7hYYV/bUATZyRzWBOmuqP6RF8uSv 2xTgl8nrtS7Jux3hg1HKgJiMaER+ShP1wk+ScipWeCyUKh4Ory5jG172XO4sVqcz1vqLfXQ3BtG O8rMPEZ44BTGl19DMxAEsZVdALLb0rFNvUy9TpQ6louE1FNngOkOMHBNHqL9UGMW1/Bmd+XIbhB Sd6uI/Ut5cRoVziYBdZQMPOUoCi4CISCYIhUvo7Mpg= X-Received: by 2002:a05:693c:884f:b0:35f:2858:aa4b with SMTP id 5a478bee46e88-361a2c36e5fmr8217730eec.30.1792366029272; Sun, 18 Oct 2026 16:27:09 -0700 (PDT) Received: from siegeengine2 (c-73-158-156-210.hsd1.ca.comcast.net. [73.158.156.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-360813b6ca5sm25571908eec.9.2026.10.18.16.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 16:27:08 -0700 (PDT) From: Mark Pariente To: Jiri Kosina , Benjamin Tissoires Cc: =?UTF-8?q?Filipe=20La=C3=ADns?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mark Pariente Subject: [PATCH v2 0/2] HID: logitech-dj: Restore device configuration after reset-resume Date: Sun, 18 Oct 2026 16:26:52 -0700 Message-ID: <20261018232654.70571-1-markpariente@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261018224627.60328-1-markpariente@gmail.com> References: <20261018224627.60328-1-markpariente@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a Unifying receiver is reset on resume, for example because a USB KVM switch moved it to another host while the system was suspended, devices that reconnected in the meantime lose their configuration. The most visible case is HID++ hi-res scrolling, which leaves the wheel about 15x slower. Patch 2 has the receiver re-announce its connected devices on reset-resume so that hidpp reconfigures them. Sashiko pointed out that on Unifying receivers the re-announce can also hit slots without a known device, and that HID++ connect notifications then add those devices with an incomplete report descriptor. That can already happen today, e.g. when Solaar sends the same request on startup, so patch 1 fixes it separately: on Unifying receivers, unknown slots are enumerated through DJ notifications instead. Changes in v2: - New patch 1/2: don't add devices from HID++ connect notifications on Unifying receivers (reported by Sashiko). - Patch 2/2: code unchanged; the commit message notes the dependency on 1/2. - v1: https://lore.kernel.org/linux-input/20261018224627.60328-1-markpariente@gmail.com/ Testing: - Both patches applied to the v7.2 driver and loaded as an out-of-tree module on Fedora's 7.2.11 kernel, with an MX Master 3 on a Unifying receiver (046d:c52b) behind a USB KVM switch. Devices enumerate normally, and hi-res scrolling is restored after the reset-resume reproducer described in patch 2. - The unknown-slot case fixed by patch 1 could not be reproduced here, because this KVM switch fully disconnects the receiver, so it was verified by code inspection only. - Lightspeed, Nano and 27 MHz receivers were not tested; patch 1 does not change their behaviour, and patch 2 sends them the request logi_dj_recv_query_paired_devices() already uses for them. - The investigation, patches and changelogs were drafted with an LLM coding assistant, then reviewed and tested by me. Mark Pariente (2): HID: logitech-dj: Don't add Unifying devices from HID++ notifications HID: logitech-dj: Re-announce connected devices on reset-resume drivers/hid/hid-logitech-dj.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) base-commit: ae6927c533a4454570950125ca8ba909c45f20f9 -- 2.56.0