From: Greg KH <gregkh@linuxfoundation.org>
To: Melih Emik <melihemik@noirlang.tr>
Cc: parthiban.veerasooran@microchip.com,
christian.gromm@microchip.com, error27@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: most: dim2: remove redundant dev_err() calls
Date: Sun, 18 Oct 2026 13:52:09 +0200 [thread overview]
Message-ID: <2026101833-envision-landless-4b41@gregkh> (raw)
In-Reply-To: <20261018110058.296436-1-melihemik@noirlang.tr>
On Sun, Oct 18, 2026 at 02:00:58PM +0300, Melih Emik wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() and
> devm_request_irq() automatically log detailed failure diagnostics
> including device name, IRQ number, handlers, and the error code via
> dev_err_probe().
>
> Consequently, driver-specific dev_err() calls immediately following
> these requests produce duplicate error messages on failure and are
> redundant. Remove the redundant dev_err() calls in dim2_probe().
LLM-generated patches are not allowed in drivers/staging as per the
previous statements:
https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
sorry,
greg k-h
next prev parent reply other threads:[~2026-10-18 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 11:00 Melih Emik
2026-10-18 11:52 ` Greg KH [this message]
2026-10-18 12:18 ` Melih Emik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026101833-envision-landless-4b41@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=christian.gromm@microchip.com \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=melihemik@noirlang.tr \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®