From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE67C559CA1 for ; Mon, 19 Oct 2026 14:28:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792420110; cv=none; b=WpFqEiZqsZt1Bvoz1GcpfHc16GqyVK1557A1I6uKpVUQ8KPhnJDsR24ykIV8aPzCtGniSA4Dk/xIZXAgMmRLg0FqY59/bHQrgANc4SJiVjQTMl7mGGKdxl9rG3gc7MNzqf3AjbSCfKY2ZBkii6vj3RA+kzy8VZuFU9fPgUYf7Ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792420110; c=relaxed/simple; bh=anBcak3Ys9II84vCh2gVKyCJfNBmhw+4V0+PFeEukjc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rWUD1jjB5YxfkUp64YDUb2vchcO9Lu+KnBHrAURTQKxsu99D60Y6Uy5QpMcbTuMVcK8vrxm9+25yNpVL96Ee3emPakgC/XEE5v4zi6pBpTzvfHZV6EyjkPij2UbY1qCAs4dlC6DlssfAvwbxLrZ21ywDhOH4HzJvQxbNwwdb5wA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=FevbvPPs; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="FevbvPPs" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-6b1f31c63ebso5354339a12.0 for ; Mon, 19 Oct 2026 07:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1792420107; x=1793024907; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BcJ7RHtekvu//YyovleHaPy2Pek3quV3iA/aby3t/xk=; b=FevbvPPscMs209qdlZGxEMLzToIPgPCcL4dsixfI4DLqobcnqb+wkQkmrSY1D3AF2z siZp5ELrIurk9c2y8Jmh5PHbne3Yw18ZCKSGElEtBkUEuqmE0M38cFhJSS+ikPKrQ91r p288Yi8QSAFQ008a2s52zsqU1DPptxcfgSuWpnmFRjkPvEfIyaCRq9yO7MoJldbDIAT/ L19hQZdWSR325tso4Kf+UGZ93Jh9SO22rZrbgWs2M7tlo1UrYGTiMCnJDm4DMJpdMM1t bfuFODTxqwlPR35FR/xvmemTT+6SPi2EmVgwxxYUgpqnyvVEtJfrUwomcAbe7XNkPHib AFyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792420107; x=1793024907; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BcJ7RHtekvu//YyovleHaPy2Pek3quV3iA/aby3t/xk=; b=hizVCDKEMElnTwuA8dsmQRfMwe0PBq7Bj56WF/5UWEO1vQHcAVSk4w4AkKfI9/GraA p1VzjAG/15WYF5fVPZ4DfEeCMKIReTJCaiGVQRWRYZM0uKMZdXKTcGX4zbibCJmwMN6L z8Kx6ouSgWfVvtSJ3/jTMublFwAHZ5sblLLnzk43CgxM35DcSsW6EZoEBmfQQeHiL93J m85u1NG2Ar06Y7XpW7r34G5twqFnBQDkhCh+PDQeALsCf1JiD0tJA6DYjetGAUnYjexO +48AbupS/Gn0pWoxtetwONhbxUuWtaMkAUzIfRokZChQNwNOQG3DvESKXDMTv7c7+x0d Xkzw== X-Forwarded-Encrypted: i=1; AKwUvBw7LIUbS876a7M+ndpcNH0/b1/DhJak+N6Px5QoHQCo0Z1iJjPWjZ6JA4tSKWvC1NVE5dfvQraUNRgraAA=@vger.kernel.org X-Gm-Message-State: AFq9FYL9tYV08CjHWncLyUMZ7p/knBqbhm3MNga1VP7fRSNi+WhIBudP 6v5hbK62tLyecZ/3ibgILzRFUacYgdtRRJn//HxDQ1+1S+USQhTohcm24xskVlnkIgA= X-Gm-Gg: AYBFou2MsD9lzY1pKbIcoNiBWjWlKWWHbsbT4yzoN9YxjDF2JGy9o/sf2aOojsTNgBt gNHxdll5ofIIopbFAftYgswX3VATLSKx+vPbz8swlvoGsd/aqEECxZhmE26Z0hsEEaMuqNArDwI okzjxCrWolh4fuLNkdPW3P+59l02YVDSgeVDL6/FEIRmxD8G2OOsLbK6eNXsWbXjWw/XlFvsFgx HtyPfCPzmphNVDwPnh0uE68cKYRtrZyJL9mFY3N8cF9XGV3Al89r5P3OUldYIoxVS69mX272zjX dzSXn9uaDnzxXvJbXSsOq22MCmKmNg+dV1y975QHNDmUpfgcGi15GJuKJ3+XuTyVJBWtcu9iUwf QFVIGDWaGHFpGF5MC9Hwlw2FJGvbmDzUEaS0Ab4hfhSll7Cztdj0e0rBJjPt0l1AtEv18C+C9uP dC4mWIGhGEh9AI7a7a2tDsO/kqZVd8KpkbW7yioTouidTWE+ZHyZLr3RkwPzHs9uwHXz6hSHOpE epH10JrVOMTeUOjmepBMrj8KdKwBsIKlyLTfFkdG5tDas6Gaw== X-Received: by 2002:a17:907:c299:b0:c25:4d9e:bb28 with SMTP id a640c23a62f3a-c401e03b0bemr808167666b.3.1792420105499; Mon, 19 Oct 2026 07:28:25 -0700 (PDT) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48dfd540bc4sm23854576f8f.2.2026.10.19.07.28.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2026 07:28:23 -0700 (PDT) From: Dave Stevenson Date: Mon, 19 Oct 2026 15:28:10 +0100 Subject: [PATCH v5 03/16] media: sony-starvis2: Always program the sensor in window mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261019-media-starvis2-v5-3-eef935347ce9@raspberrypi.com> References: <20261019-media-starvis2-v5-0-eef935347ce9@raspberrypi.com> In-Reply-To: <20261019-media-starvis2-v5-0-eef935347ce9@raspberrypi.com> To: Sakari Ailus , Jai Luthra , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Laurent Pinchart , Alexander Shiyan , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dave Stevenson X-Mailer: b4 0.14.1 If the requested region matched the defined active area then the driver switched to all-pixel mode. This left the possibility that the active area was incorrect and not reading out the area expected. Switch to always requesting window mode to avoid this potential mismatch. Signed-off-by: Dave Stevenson --- drivers/media/i2c/sony-starvis2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/i2c/sony-starvis2.c b/drivers/media/i2c/sony-starvis2.c index e5c56a1d09df..981ce722bf8f 100644 --- a/drivers/media/i2c/sony-starvis2.c +++ b/drivers/media/i2c/sony-starvis2.c @@ -922,9 +922,7 @@ static int starvis2_program_window(struct starvis2 *starvis2, int ret = 0; cci_write(starvis2->cci, STARVIS2_REG_ADDMODE, 0x00, &ret); - cci_write(starvis2->cci, STARVIS2_REG_WINMODE, - v4l2_rect_equal(crop, &imx678_active_area) ? 0x00 : 0x04, - &ret); + cci_write(starvis2->cci, STARVIS2_REG_WINMODE, 0x04, &ret); cci_write(starvis2->cci, STARVIS2_REG_PIX_HST, crop->left - imx678_active_area.left, &ret); cci_write(starvis2->cci, STARVIS2_REG_PIX_HWIDTH, crop->width, &ret); -- 2.34.1