From: Jiale Yao <yaojiale02@163.com>
To: Solomon Peachy <pizza@shaftnet.org>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiale Yao <yaojiale02@163.com>
Subject: [PATCH] wifi: cw1200: unwind failed interface additions
Date: Mon, 19 Oct 2026 09:31:58 +0800 [thread overview]
Message-ID: <20261019013158.1488968-1-yaojiale02@163.com> (raw)
cw1200 publishes the vif and changes its mode before cw1200_setup_mac(),
but leaves that state in place if setup fails. mac80211 will not call
remove_interface for the failed addition, so subsequent interface
requests are rejected as busy.
Restore the empty monitor state when MAC setup fails.
Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
Signed-off-by: Jiale Yao <yaojiale02@163.com>
---
drivers/net/wireless/st/cw1200/sta.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/wireless/st/cw1200/sta.c b/drivers/net/wireless/st/cw1200/sta.c
index 5d8eaa700779..92a729f1e9ef 100644
--- a/drivers/net/wireless/st/cw1200/sta.c
+++ b/drivers/net/wireless/st/cw1200/sta.c
@@ -235,6 +235,11 @@ int cw1200_add_interface(struct ieee80211_hw *dev,
priv->vif = vif;
memcpy(priv->mac_addr, vif->addr, ETH_ALEN);
ret = cw1200_setup_mac(priv);
+ if (ret) {
+ priv->vif = NULL;
+ priv->mode = NL80211_IFTYPE_MONITOR;
+ eth_zero_addr(priv->mac_addr);
+ }
/* Enable auto-calibration */
/* Exception in subsequent channel switch; disabled.
* wsm_write_mib(priv, WSM_MIB_ID_SET_AUTO_CALIBRATION_MODE,
--
2.34.1
reply other threads:[~2026-10-19 1:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019013158.1488968-1-yaojiale02@163.com \
--to=yaojiale02@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=pizza@shaftnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®