mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Szuying Chen <Chloe_Chen@asmedia.com.tw>
To: <Markus.Elfring@web.de>
Cc: <linusw@kernel.org>, <brgl@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<Yd_Tseng@asmedia.com.tw>, <Jesse1_Chang@asmedia.com.tw>,
	<Richard_Hsu@asmedia.com.tw>, <Chloe_Chen@asmedia.com.tw>
Subject: RE: [PATCH v2] gpio: amdptpci: add support for AMD PT PCI controller
Date: Mon, 19 Oct 2026 14:57:01 +0800	[thread overview]
Message-ID: <20261019065702.31436-1-Chloe_Chen@asmedia.com.tw> (raw)

Hi Markus,

>> This commit implements the new gpio-amdptpci driver to support the
>…

>See also:
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3-rc7#n94

>> Signed-off-by: Szuying Chen <Chloe_Chen@asmedia.com.tw>>
>> Co-authored-by: YD Tseng <Yd_Tseng@asmedia.com.tw>>

>See also:
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3-rc7#n502

>> v1->v2:
>…
>> ---
>…
>>  drivers/gpio/gpio-amdptpci.c | 891 
>> +++++++++++++++++++++++++++++++++++

>Please move patch version descriptions behind the marker line.
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3-rc7#n793

I will correct the patch format in v3.
>…
>> +++ b/drivers/gpio/gpio-amdptpci.c
>> @@ -0,0 +1,891 @@
>…
>> +static int pt27_gpio_get_direction(struct gpio_chip *gc, unsigned int 
>> +offset) {
>…
>> +	raw_spin_lock_irqsave(&chip->lock, flags);
>> +	val = pt27_rd32(chip, PT27_REG_DIR);
>> +	raw_spin_unlock_irqrestore(&chip->lock, flags);
>…

>Under which circumstances would you become interested to apply a statement like “guard(raw_spinlock_irqsave)(&chip->>lock);”?
>https://elixir.bootlin.com/linux/v7.3-rc6/source/include/linux/spinlock.h#L594-L597

Thanks for the pointer. Simple lock/unlock sections like the one in 
pt27_gpio_get_direction() are good candidates for guard(raw_spinlock_irqsave), 
and we will use it where it fits in v3.

>Regards,
>Markus

thanks,

Best regards,
Chloe Chen
==================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it 
is addressed.If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete 
the message and any attachments from your computer system, and destroy all hard copies. If any, please be advised that any unauthorized 
disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Furthermore, any views 
or opinions expressed are solely those of the author and do not represent those of ASMedia Technology Inc. Thank you for your cooperation.
==================================================================================================================

             reply	other threads:[~2026-10-19  6:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19  6:57 Szuying Chen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-10-19  7:38 Szuying Chen
2026-10-13  8:16 Szuying Chen
2026-10-13  7:43 Szuying Chen
2026-10-13  8:48 ` Markus Elfring
2026-10-13 23:30 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019065702.31436-1-Chloe_Chen@asmedia.com.tw \
    --to=chloe_chen@asmedia.com.tw \
    --cc=Jesse1_Chang@asmedia.com.tw \
    --cc=Markus.Elfring@web.de \
    --cc=Richard_Hsu@asmedia.com.tw \
    --cc=Yd_Tseng@asmedia.com.tw \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®