From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m1973172.qiye.163.com (mail-m1973172.qiye.163.com [220.197.31.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E17349BD71; Mon, 19 Oct 2026 09:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792400662; cv=none; b=eoutkR2p7t2IvsHYVT8karP8cUrr4ctgmlO9KvNV1c94uv82X8OFOUTzYeYu8lcqkZ7jkA4DslD8sIfMBQWwS8jlaulCPxwbQjXdSowC0iJBabxRFTyBdYCvuG+2+/6aTY/7uABuLk7DO5bYKlrzh+pXot8KwLS8TqMYfBj+bvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792400662; c=relaxed/simple; bh=IOR9zbEyCG0rTY4vuDfKH6Q+3agDYaSdFoAdRnUG+LA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Egvq6bhXAdSjbpuWKmMjo4aOC9CYeyHfNfadDmEoC423uWd8DIACc1/baKC2XQ8a1hXfCgrmxuMTcyeCe7giP0eVH9rsZzaFB8r2EekTR32Xzwe3ivo1/T8kFrFNKYnALvLtUpyjrIMmuZ692LnJHdDLFUM5u42SpAWwm8NyKno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=Rgy38Rxe; arc=none smtp.client-ip=220.197.31.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="Rgy38Rxe" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 5189b85d8; Mon, 19 Oct 2026 16:59:02 +0800 (GMT+08:00) From: Damon Ding To: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Heiko Stuebner Cc: Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Dmitry Baryshkov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding , Sashiko Subject: [PATCH v4 02/14] drm/bridge: analogix_dp: Check all negative return values for &analogix_dp_device.irq Date: Mon, 19 Oct 2026 16:58:24 +0800 Message-Id: <20261019085836.3065008-3-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261019085836.3065008-1-damon.ding@rock-chips.com> References: <20261019085836.3065008-1-damon.ding@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0aa15362be5603a8kunm6ee755052eabf8 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlDGRkfVk1LGR0aGkMeTRhOQlYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU JDQkpVSktLVUtZBg++ DKIM-Signature: a=rsa-sha256; b=Rgy38Rxe8sSFyv4DxSF44Xrg5Put/bFOTb3fjWhyx4t/yDf3yZ1Z0EcICad4s07iVbPq+qxwT0hWkzLwNPEXmbMADS05EMN++q/d0YMesgXwQq23s3Jz3kiQf0iUQ4/jTRGiufyD5VMPbSWM4tEwKVH1ZYvHqNvfKly7nbG5DEg=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=nLsz7932z7XAKnP+Q9VfpNYxFLgSWJSn220mna7ZMLI=; h=date:mime-version:subject:message-id:from; Currently only -ENXIO is checked for dp->irq from gpiod_to_irq(), which ignores other possible error codes like -EPROBE_DEFER, -ENOENT. Check for any negative value instead, and propagate the actual error code rather than hardcoding -ENODEV. Reported-by: Sashiko Link: https://lore.kernel.org/all/20260804083307.84ECA1F000E9@smtp.kernel.org/ Tested-by: Heiko Stuebner Signed-off-by: Damon Ding --- Changes in v4: - Add Tested-by tag. --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 079f2f01f33b..27c9a764e25f 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1480,9 +1480,9 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) irq_flags = IRQF_NO_AUTOEN; } - if (dp->irq == -ENXIO) { + if (dp->irq < 0) { dev_err(&pdev->dev, "failed to get irq\n"); - return ERR_PTR(-ENODEV); + return ERR_PTR(dp->irq); } ret = devm_request_threaded_irq(&pdev->dev, dp->irq, -- 2.34.1