From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A6ED4CDDD2 for ; Mon, 19 Oct 2026 10:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792404587; cv=none; b=oQxYvFh2gdUIb2bJxgGa/s0plyKoavk1aZTyersug7rCVbTY/aI5E65QbQjZ5LwWlhshcTmILpKpyDLu/fcty1lv1+lbVPZr9LaBW2D08Jao5L2/7lurjv7rEEiGsCN7MC+04OhO2AD5YzEggj4mRiz/817McxPxUA2b5DiMlPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792404587; c=relaxed/simple; bh=PkwePPbuzVu9fbzReX4tE5VcjsQsyH/gZI5uyzCeZOs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q+NXKawmCw/WFVeAjZwbEW/IVsecOVG8vd1DoB7FQ4rjeiBDDMLk403/ztqaqyOsQKse03QrDVcpYrzEFlUbo4111Yz2nJZUAJcFP25l8uQRbKBuScQjd8B7bNW00yA1IljWfWsUx7hkFAVXE6wKtrkD/xWNkh8xF6iEguJVm48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r4hrPBmh; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r4hrPBmh" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-48df4f540ebso984198f8f.3 for ; Mon, 19 Oct 2026 03:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792404584; x=1793009384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=L/trV4jow8NDaSDq91x2ETJmC0OZjy2jDwgvKC6ameE=; b=r4hrPBmhqUjTPiOJa0j+vGxGTczI9XmY5BAra20vRCr89VY/BKzAQYgL0/+YjjJLCB pKdClt5u4RcNM3fnNO1giuNDyNke368fV/IF1/L1s569iEcCC286aI7uZ6QHHQuuIxnd 1yolac8AMMOJLHUs+TGS3EoOaODfNicNi3pBntu1DIbaI0+ycqT6CJgq2X5hj13ft8K6 gtKzbQgxSQ1QWrnmSLdWNTscsZVHvPHOvh0rFjFL8rkmnmaXA9pHZUtyCap4RGluW+VU 3GfbxpWeCy/ilLbImHj4mv2rkEs2NWnb4QNkFfbwI4bo0rFpmDz+7WJ2M+BvtIEJfm5I nbig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792404584; x=1793009384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=L/trV4jow8NDaSDq91x2ETJmC0OZjy2jDwgvKC6ameE=; b=0Agsar+f8hfmHHgTgqq+vxLropoQVCp9Y2pnWxp6RO+CZH+kypUlUcqgTZ1GqISmwG Xulwoy7YoQWN3dE8dyIMTTANM6OG/Nc5zBa8Jy6/xzDrpBCcjCA3xW3L9okeYxNGpG3i O3Z2hKPstYYVkJDqH7s3Mtrd9R3QElciS1Ev0DeZ1de0lGAtyHc0k51rHOEVVSJU3XUc bSOfC9oLf8qANw7AK4rCB3oI143W/I0LAR7kGCGk62AF1KmBVsz6SQEJYOZPnRIANbFX qAhDyvbFXqtuVohrnZ0A9LyXF90ei3VY0pW5ldUzd5uT0qVrCuEFEM3WIfb+GI/ukJ39 iqcg== X-Forwarded-Encrypted: i=1; AKwUvBwh7HQHDTylSkprYy95A2purogX667e5gNztnl9QBLxFsqEbegleK1qUNOFZvqPff55c/7ndbfaUJS7f64=@vger.kernel.org X-Gm-Message-State: AFq9FYLwSdkHOGJW2fzgr74P7dMWHuOSo1FaOxehckzDe2RFYcxtn9A9 GQCGfR9EHXaGLMDgPYMukrf7r3xzzgMbuozYO2RMoAgxHz/nxRYLRJWA X-Gm-Gg: AYBFou3U1gNw7Jblo8FhNg0/0NmIRuJPSp4bAHP+BPY52HQ7uEJdRqE13cbclTgtBr3 i5yQaeIh8W3js2mhJNFt/OD9HWEW7TFG2zPidN/m192JW0vrYUc6iXhLkukrqf0DLXkgycxyrYO ZDAccdtqCDX+M6enFIjyaz86doRw3l/NQvO8XYZ4nPTn493uLeothmK+0rv18Fi3VdQqpQfLwD9 lVsj9YJEeI5ms8oplu2rDbJhR3RG9zumB4xoUrAzQ497sO7nhDrWfkJnjat6Hxfw9Npv1PA1mNr GknPlef6zsaUC5kGFRhr0Ekm89lEod7QbZxLZ6ZILaJ/vkqnCWYTap7NndAWnR6n3nkavPTLzhL w8VWkaeBjXUa+tkSme0FsvlJNoyXBeix+YsTfkLADTO5vXUQxzBBmCA85UKJeuLH/sUTOlxWydH 4MR06beTH5T9s8RqohoXOZpg8mYTG8zKfR9q7OobX0/6Jed7O7z8MwK2tBh4anwKWAXJl9N00yF niMV73T/nzmW4iVq2Y= X-Received: by 2002:a05:600c:3b91:b0:4a1:dfaf:f43e with SMTP id 5b1f17b1804b1-4a1dfaff680mr129256885e9.1.1792404584307; Mon, 19 Oct 2026 03:09:44 -0700 (PDT) Received: from xeon ([188.163.112.62]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1c8a81587sm510533485e9.1.2026.10.19.03.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2026 03:09:43 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Daniel Thompson , Jingoo Han , Svyatoslav Ryhel Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mfd@lists.linux.dev, dri-devel@lists.freedesktop.org Subject: [PATCH v4 2/4] mfd: aat2870: Derive brightness steps from max current Date: Mon, 19 Oct 2026 13:09:28 +0300 Message-ID: <20261019100930.110954-3-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261019100930.110954-1-clamor95@gmail.com> References: <20261019100930.110954-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The AAT2870 allows only 32 steps of brightness, with this amount defined by the maximum supported current. Remove the need for max_brightness by calculating the allowed number of steps from the maximum current. Reviewed-by: Daniel Thompson (RISCstar) Signed-off-by: Svyatoslav Ryhel --- drivers/video/backlight/aat2870_bl.c | 30 ++++++++++------------------ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/video/backlight/aat2870_bl.c b/drivers/video/backlight/aat2870_bl.c index 8b790df1e842b..c9e764a94a238 100644 --- a/drivers/video/backlight/aat2870_bl.c +++ b/drivers/video/backlight/aat2870_bl.c @@ -24,18 +24,6 @@ struct aat2870_bl_driver_data { int brightness; /* current brightness */ }; -static inline int aat2870_brightness(struct aat2870_bl_driver_data *aat2870_bl, - int brightness) -{ - struct backlight_device *bd = aat2870_bl->bd; - int val; - - val = brightness * (aat2870_bl->max_current - 1); - val /= bd->props.max_brightness; - - return val; -} - static inline int aat2870_bl_enable(struct aat2870_bl_driver_data *aat2870_bl) { struct aat2870_data *aat2870 @@ -69,10 +57,11 @@ static int aat2870_bl_update_status(struct backlight_device *bd) dev_dbg(&bd->dev, "brightness=%d, power=%d, state=%d\n", bd->props.brightness, bd->props.power, bd->props.state); - ret = aat2870->write(aat2870, AAT2870_BLM, - (u8)aat2870_brightness(aat2870_bl, brightness)); - if (ret < 0) - return ret; + if (brightness) { + ret = aat2870->write(aat2870, AAT2870_BLM, (u8)brightness - 1); + if (ret < 0) + return ret; + } if (brightness == 0) { ret = aat2870_bl_disable(aat2870_bl); @@ -150,10 +139,11 @@ static int aat2870_bl_probe(struct platform_device *pdev) else aat2870_bl->max_current = AAT2870_CURRENT_27_9; - if (pdata->max_brightness > 0) - bd->props.max_brightness = pdata->max_brightness; - else - bd->props.max_brightness = 255; + /* + * The maximum number of brightness steps is determined by the max current. + * The aat2870_current enum maps directly to the allowed brightness steps. + */ + bd->props.max_brightness = aat2870_bl->max_current; aat2870_bl->brightness = 0; bd->props.power = BACKLIGHT_POWER_ON; -- 2.53.0