From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Bradley Morgan <brads@mainlining.org>
Cc: pmladek@suse.com, akpm@linux-foundation.org, rostedt@goodmis.org,
john.ogness@linutronix.de, senozhatsky@chromium.org,
kees@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic: drop the fake trace id from the oops end marker
Date: Mon, 19 Oct 2026 16:46:28 +0200 [thread overview]
Message-ID: <20261019144628.r8Q0S1M-@linutronix.de> (raw)
In-Reply-To: <20261004175419.269865-1-brads@mainlining.org>
On 2026-10-04 17:54:19 [+0000], Bradley Morgan wrote:
> print_oops_end_marker() prints "---[ end trace 0000000000000000
> ]---". The format pretends each oops has a trace id, but the value
> has been a hardcoded 0 since the oops id machinery was removed, and
> nothing prints an opening marker anymore. Nothing in tree parses the
> id either, the pstore selftest greps for "---[ end trace" without it.
> Kill the fake id, the format specifier and the 0ULL argument go with
> it.
Could you please figure out _why_ it is hardcoded to 0? Someone
requested this with a reason. If you want to remove it, you need to
ensure that reason is no longer valid.
> Signed-off-by: Bradley Morgan <brads@mainlining.org>
> ---
> kernel/panic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index 213725b612aa..0436a92318ed 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -1051,7 +1051,7 @@ void oops_enter(void)
>
> static void print_oops_end_marker(void)
> {
> - pr_warn("---[ end trace %016llx ]---\n", 0ULL);
> + pr_warn("---[ end trace ]---\n");
> }
>
> /*
Sebastian
next prev parent reply other threads:[~2026-10-19 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 17:54 Bradley Morgan
2026-10-19 14:46 ` Sebastian Andrzej Siewior [this message]
2026-10-19 15:07 ` Bradley Morgan
2026-10-19 15:18 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019144628.r8Q0S1M-@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=brads@mainlining.org \
--cc=john.ogness@linutronix.de \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®