From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.218.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792431434; b=q7Eme3+OdWHfy/6takmWlq3utx+mkB8FxMB8jPcSSuKEm404joEJMlUAc3Tgn1mXFt6R CAb2H0Szh2hf2lx2YqwW12yyxy3lPt7s/nVesTNV2OBQG/3iq4vmuU378mfmfvi7KqY/X yb0srq/UHQVEPhZ6MyuGezKY+GskPH5fomln3IZJRbrIIhlzO29m8VITxi4eZlHFUlXnx D7j2micbVY0fyPRhsmnTRqUEb4ySoGvU3MehKRQBkVuRC9WY+D4MtQR0f9srdxaovFCHZ YTAepXaKcrL6+PSVVezckdeau1f2vtDz1r2MZhhhTnZR0/HADPek7gW+QxdXDhh5d/g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792431434; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=X7SfKpkZEyou8apB+p/B2J6UWfJlZHexvBzvKG5arNU=; b=PbunNzD1RmS8xndrWtOjvIgorg+njsuBz3ZeRdXnSgFn7BXj5QkiwMvDO3MeR5U34ooJ +XETbjJpktWpHc7YG7dfJQqKZ/+8ZPufcpuf0dGpCS2sr8NIhP0B9UDVc8XFE90wvBqfs +A2fGAxqs19cYIRSUXILdHsqpomrvg9CyrernHdG0hJds5g0+4/DPOqVZCNGm/5u661Wb Xce2IlXp1Xi9KwvdWvQJJjJXU4xC5LBUNYSonYodGcVr5RvgJzU03CC8KHBao18bu6qdo wvs2bcCnSmn/EtMqrPfV7Xv9MFPtHBFfQiHH1KIGGCm9Cc1EpERDX7QY25UOztcE7Jg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=W3e+jzOX; arc=none smtp.remote-ip=209.85.218.45 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55FB9606A31A for ; Mon, 19 Oct 2026 17:37:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 55FB9606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=W3e+jzOX Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-c20ce3c118aso438570466b.0 for ; Mon, 19 Oct 2026 10:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792431433; x=1793036233; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X7SfKpkZEyou8apB+p/B2J6UWfJlZHexvBzvKG5arNU=; b=W3e+jzOXCY7H2t+R8eQRvZ6ycEKAxC/TG3tmAYpTO1zl3QcoJV9GXMq/+dgDTS0cCu 0p9osOW/GqfTTSebAtPhou3iHW2o1P8Qur/06Aau/yawerGMKkTij5/gxlXD9Z0oxHe2 JNDwh327ZjHw7DCVvQXBMEYOkaAsuzRX4FMUA4J9kL0T45i4/K1F/Ke1ROoSE4hruE5x TkCuOb5/VXUD5R872BPBdYlabV5+MJr6q/2n8EmqwcJPejJNUiEyFPeiRNc6A6wT0rOD Yo4dPBqsj3uLT70FGfih5zO8DJCZ4QAOu74Dkok5FXb8iw8DHcwTVa3sLbHhoQt2MEPj tr8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792431433; x=1793036233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=X7SfKpkZEyou8apB+p/B2J6UWfJlZHexvBzvKG5arNU=; b=Wn8023NVzyQtMScL9q0Xtx3UnvEQI+U3+385l6UN24boDMROqco418GKm2cVTCZOsE BQTnUzmY5HGBSOK+ms1lOPpHa5iNu4lKMjTF8wvtU2af56fm/Hbg5Zgf/ONnYmeUxauv Ifw/0pFW5cOGsCgu/LkzifMvGRi1TeStPwJEjnG2dfsm8vkLimGoP9jDLpHXeHjRaZih aht0b6f291hEeDbHuLT2Pwkfsst+LjWW+kb/HcyhsZxX870xCHTD7WXuSFpqpIWW46iD ZBTlYiNzVD64vCmVsHkv9leqmTzyL9k6TaedT2w4/JChMBPI1IvOOuhNvee9ifS1VSVc nanw== X-Forwarded-Encrypted: i=1; AKwUvBwL0FpA1qEKUbnuh7hBzgMEJ7XPZD1jYM//opTEAi7RpXnSWNiE6x+E6Vdu8AoynXmh7BnoVnb71S6Yygo=@vger.kernel.org X-Gm-Message-State: AFq9FYKc4WADRvp4SGXxpd7q57Smjf34mVVqXTTBfb/V1a9FV+HpAZ4D fXZeB+Yzj20XpsUDWatSvxtOcMJYa9KTNvfV5QbGcMRkNpLVVxxVJlpl X-Gm-Gg: AYBFou1HJ4Itx5AKB1oLvdLOAKPppGAkkMdlaPG+g7VR2MBcsIKIZUydLABf/2osbrQ 4PcxtbRNAP+HOZRea8xWkkoQy1yXIbc+5jaGYu2AnxBRMBHYH+Ek/r9d7ALRg8Qh9COs5bmSCKv TiKcMDDaGW9M+7OUkePbUkDaLmd4eI2gdUToMwT1W5iCqNRgxBel0aEBfAr626n4H5gdBmW3twR AcCZoopRPeqnpvtw0csDmFKhmcAE5qT7PQ5SYzrUF4LnCfeJ6SeWlEgS8SeVou+YUVU/Xi8LAHI Dk5ZsopRAuBxtY0FGAaXmRfcAXugASJHeEn0ABpe5eT48vtuTc4fH+ZRKm7si2tHEQPwpGPxqaT MlNN3vywrK/t0pI6SlE/6LQIdzmYnMHVxFMDEUYFMDN4ncvyxpDYo7VcDGkMGlGOHcDcYnDPoU9 Wk5h5mxxZSQzAXanSc/z0EMv0k9TiaqqfIDlczui1GZ4hktBhyoyAmRQRQ/aP9kRfmp/ByWrR6b rqQtgGcW07hAiZsTAayZAQ7ChqotWxJB7mXg++R6dXmIMoteprtpaFnpcXxoGKc9HbOeDu/Ii4i E3E= X-Received: by 2002:a17:907:a317:b0:c3f:2:6faa with SMTP id a640c23a62f3a-c401e136d98mr974748666b.1.1792431432318; Mon, 19 Oct 2026 10:37:12 -0700 (PDT) Received: from CCM-PC (94-255-221-162.cust.bredband2.com. [94.255.221.162]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6b38a1dacb6sm4299381a12.28.2026.10.19.10.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2026 10:37:11 -0700 (PDT) From: Yongzhao Chen To: netdev-bot+sashiko@kernel.org Cc: netdev@vger.kernel.org, Christian Marangi , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Russell King , Florian Fainelli , linux-kernel@vger.kernel.org, Ziyang Huang Subject: Re: [PATCH net v5] net: dsa: qca8k: preserve port state across MTU changes Date: Mon, 19 Oct 2026 19:37:06 +0200 Message-ID: <20261019173706.198461-1-yongzhao.derek@gmail.com> X-Mailer: git-send-email 2.55.0.windows.5 In-Reply-To: <179240775070.3135.2434822808609533404@kernel.org> References: <20261015104550.43169-1-yongzhao.derek@gmail.com> <179240775070.3135.2434822808609533404@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 19 Oct 2026 11:02:30 +0000 netdev-bot+sashiko@kernel.org wrote: > That path only reverts the conduit MTU. Does the switch-global > MAX_FRAME_SIZE register then keep the new value, while DSA and the > conduit keep the old MTU? Nothing seems to write the old frame size > back. Yes. With v5, a failed restore after a successful frame-size write leaves the new frame size in the switch while DSA keeps the old MTU. On a fixed-link CPU port the same failure can keep the MAC off until a link flap or reboot. > Two options: keep returning success once MAX_FRAME_SIZE has been > written, or roll MAX_FRAME_SIZE back on failure. Either way, should a > failed restore stop being treated as the saved state on later calls? v6 takes the first option: it returns the result of the frame-size write, and a later restore failure no longer replaces it. A failed PORT_STATUS write now keeps its target and is retried every second from delayed work, so a fixed-link port does not depend on another mac_link_up(). Newer port decisions replace the pending bits. The next MTU change first recovers pending writes on ports 0 and 6 and returns an error if that fails, so a failed restore is not taken as the saved state. A userspace harness that compiles the driver functions and dsa_user_change_mtu() now covers both cases, and v5 fails it. v6 has not been tested on hardware. I will send it separately. Thanks, Yongzhao Chen pw-bot: cr