From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.16 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792443058; b=cMXBDgrudkAdTVAHCnQqfUw1MHLp2XVVN+oYvghps9uKQAIegAw/eLQpEo2cZb00JNLl 6xgUMzB9mKRfsFCdEPPTK9hIr01luYnEsmuDTkRuiPo3uS7BxU33Rn+OhGZuUKcE6/QTr 2EuiBQVvxmQnKf3q1jlukAonYrtHA7y48Wre52+xuR4nOflZ9sHOKu2VeBf3KekggFvP1 0U9n3IowaCIE0gIqm4lZG7rXKCnsWPg+LNvNbFdid92rpqccQvChXMyIZkS2WDungMsmw CMvCuylBzRtdFUnIGrbLV2ZnaVoS2oincl+hgOjzSURHHIF7pXIwX2NCNTV2kZG083A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792443058; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=b6sFqVcK9TmYk4uNli988YT73/sawBcMefs54y4lE+c=; b=tYMZXkJuBCGOGGhmrmPnCZ0kInbbW9B9KrKKhR5h00TKBLgeVuXh2Wri0IxQ81is5MRP NgR6aCm0BJzKpuhzVI+4+ksZh1tbFLYfwpwLuIOVahAr3142HtzQo4+HaNyecjcnUEEtd BxXQbGM9RPk+5/QSKDmmR+cRrQnuxwQc/J3iOh8zIwJIceYhdSkj2VxOwy5RY4cFd2LG/ rIaPKpbk6u2UMSmai4+CdaUExgdtqbZHbxLIUJbMIU9XyLphsACXBeMr0pmO3gaXiEvVa dlWYfFFucGpxAMc6C316DyQNBnhF43DwgOqjfINP6TkpklTXe70DFdTHVOs19IgUCuQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=D4KL0j6c; arc=none smtp.remote-ip=198.175.65.16 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E876D60A260C for ; Mon, 19 Oct 2026 20:50:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E876D60A260C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=D4KL0j6c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1792443058; x=1823979058; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DfeSBr9wkJljBUmBXYtLnlQczM0GujksKrgn/Ar85jQ=; b=D4KL0j6cXlIwYzjuN7Ml4TxSzcH+oUIcmtqTz2M/ZBH/J6JpweEzm9W1 dzVbXHfoMMQAYDlHosiUjyI8EYt62fWKxOQVQHjwYNweZNtdrzKitl+om nZNu6MG/YIiGpCV5U1mPG5ZEWLN+c/HvbI10wa3y8dPo1hN4r6XBny2vP BJa6HhzPXbGFmoQkILEfYahRtVIh3YH1BVjPNzDtMGdkwIfp6yQavWYQr iNMWGxC2ychMJ4N2E81cO1MEGw4HPxCraXcrMDGCJHj7UeGeq4MoO4APS v7I3Q/V/F42QlGX7R1EqDoa2Bz3O3qEDH9ptf0goKMKo9u6Wp8J/ukheO A==; X-CSE-ConnectionGUID: kULebxPcS7CRWFeka3cTfw== X-CSE-MsgGUID: jLYZBfSkSXONOBdCsbnX7w== X-IronPort-AV: E=McAfee;i="6800,10657,11940"; a="1131201" X-IronPort-AV: E=Sophos;i="6.27,168,1787036400"; d="scan'208";a="1131201" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2026 13:50:50 -0700 X-CSE-ConnectionGUID: rFQcCMokSnmxT5iVKwvZ9A== X-CSE-MsgGUID: sE/Jh+qrQXi9TKSRhZtRpg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,168,1787036400"; d="scan'208";a="3008653" Received: from spandruv-mobl5.amr.corp.intel.com (HELO agluck-desk3.intel.com) ([10.124.220.87]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2026 13:50:50 -0700 From: Tony Luck To: Fenghua Yu , Reinette Chatre , Maciej Wieczor-Retman , Peter Newman , James Morse , Babu Moger , Drew Fustini , Dave Martin , Chen Yu , David E Box , x86@kernel.org Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, patches@lists.linux.dev, Tony Luck Subject: [PATCH v14 11/24] fs/resctrl: Add interface to disable a monitor event Date: Mon, 19 Oct 2026 13:50:18 -0700 Message-ID: <20261019205031.16977-12-tony.luck@intel.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261019205031.16977-1-tony.luck@intel.com> References: <20261019205031.16977-1-tony.luck@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit resctrl assumes that every monitor event is enabled before any domain is created, since domains are created from CPU hotplug callbacks and their per-domain state depends on the events enabled at that time. Events, once enabled, stay enabled. resctrl enumerates Application Energy Telemetry (AET) events from data provided by the pmt_telemetry driver, which currently must be built in. Allowing the driver to be a loadable module means AET events must be enumerated on every mount and disabled again on unmount, so the driver can be unloaded while resctrl is not mounted. There is no way to disable an event. Add resctrl_disable_mon_event(). The architecture owns domain lifetime, so it is responsible for calling this only while resctrl is unmounted and for cleaning up any per-domain state. These requirements are not enforced in code, so document them in kerneldoc, alongside the matching requirements for enabling an event. Signed-off-by: Tony Luck --- v14: New commit message. Dropped previous applied Reinette RB tag. --- include/linux/resctrl.h | 36 ++++++++++++++++++++++++++++++++++++ fs/resctrl/monitor.c | 15 +++++++++++++++ 2 files changed, 51 insertions(+) diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h index 0e7fce070fde..764c45be2d59 100644 --- a/include/linux/resctrl.h +++ b/include/linux/resctrl.h @@ -449,9 +449,45 @@ u32 resctrl_arch_get_num_closid(struct rdt_resource *r); u32 resctrl_arch_system_num_rmid_idx(void); int resctrl_arch_update_domains(struct rdt_resource *r, u32 closid); +/** + * resctrl_enable_mon_event() - Enable monitoring event + * @eventid: ID of the event. + * @any_cpu: True if event data can be read from any CPU. + * @binary_bits: Number of binary places of the fixed-point value expected to + * back a floating point event. Can only be set for floating point + * events. + * @arch_priv: Architecture private data associated with event. Passed back to + * architecture when reading the event via resctrl_arch_rmid_read(). + * + * The file system must not be mounted when enabling an event. + * + * Events that require per-domain (architectural and/or filesystem) state must + * be enabled before the domain structures are allocated. For example before + * CPU hotplug callbacks that allocate domain structures are registered. If the + * architecture discovers a resource after initialization it should enable + * events needing per-domain state before any domain structure allocation which + * should be coordinated with the CPU hotplug callbacks. + * + * Return: + * true if event was successfully enabled, false otherwise. + */ bool resctrl_enable_mon_event(enum resctrl_event_id eventid, bool any_cpu, unsigned int binary_bits, void *arch_priv); +/** + * resctrl_disable_mon_event() - Disable monitoring event + * @eventid: ID of the event + * + * Never disable an event while the file system is mounted. Never + * disable an event that may be accessed while the file system is + * unmounted. + * + * Events that require per-domain (architectural and/or filesystem) state + * will require additional cleanup which should be coordinated with the CPU + * hotplug callbacks. + */ +void resctrl_disable_mon_event(enum resctrl_event_id eventid); + bool resctrl_is_mon_event_enabled(enum resctrl_event_id eventid); bool resctrl_arch_is_evt_configurable(enum resctrl_event_id evt); diff --git a/fs/resctrl/monitor.c b/fs/resctrl/monitor.c index f05be52ab5b3..fbbb31e9618b 100644 --- a/fs/resctrl/monitor.c +++ b/fs/resctrl/monitor.c @@ -1068,6 +1068,21 @@ bool resctrl_enable_mon_event(enum resctrl_event_id eventid, bool any_cpu, return true; } +void resctrl_disable_mon_event(enum resctrl_event_id eventid) +{ + if (WARN_ON_ONCE(eventid < QOS_FIRST_EVENT || eventid >= QOS_NUM_EVENTS)) + return; + if (!mon_event_all[eventid].enabled) { + pr_warn("Event %d already disabled\n", eventid); + return; + } + + mon_event_all[eventid].any_cpu = false; + mon_event_all[eventid].binary_bits = 0; + mon_event_all[eventid].arch_priv = NULL; + mon_event_all[eventid].enabled = false; +} + bool resctrl_is_mon_event_enabled(enum resctrl_event_id eventid) { return eventid >= QOS_FIRST_EVENT && eventid < QOS_NUM_EVENTS && -- 2.56.0