From: Tony Luck <tony.luck@intel.com>
To: Fenghua Yu <fenghuay@nvidia.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
Peter Newman <peternewman@google.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>,
Drew Fustini <dfustini@baylibre.com>,
Dave Martin <Dave.Martin@arm.com>, Chen Yu <yu.c.chen@intel.com>,
David E Box <david.e.box@intel.com>,
x86@kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Tony Luck <tony.luck@intel.com>
Subject: [PATCH v14 15/24] x86/resctrl: Add PMT registration API for AET enumeration callbacks
Date: Mon, 19 Oct 2026 13:50:22 -0700 [thread overview]
Message-ID: <20261019205031.16977-16-tony.luck@intel.com> (raw)
In-Reply-To: <20261019205031.16977-1-tony.luck@intel.com>
resctrl is always built in and calls into the pmt_telemetry driver to
enumerate Application Energy Telemetry (AET) features. Built-in code cannot
call directly into a module, so AET support requires
CONFIG_INTEL_PMT_TELEMETRY=y.
In preparation for allowing pmt_telemetry to be built as a module, add and
export functions with which pmt_telemetry registers its enumeration
callbacks when it is loaded and unregisters them when it is unloaded.
Record the registering module so that resctrl can hold a reference on it
while it uses the callbacks.
Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
v14:
New commit message.
---
include/linux/intel_vsec.h | 12 ++++++++++++
arch/x86/kernel/cpu/resctrl/intel_aet.c | 24 ++++++++++++++++++++++++
2 files changed, 36 insertions(+)
diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h
index 843cda8f8644..c04b1d0f3143 100644
--- a/include/linux/intel_vsec.h
+++ b/include/linux/intel_vsec.h
@@ -257,4 +257,16 @@ static inline void
intel_pmt_put_feature_group(struct pmt_feature_group *feature_group) {}
#endif
+#ifdef CONFIG_X86_CPU_RESCTRL_INTEL_AET
+void intel_aet_register_enumeration(struct module *module,
+ struct pmt_feature_group *(*get)(enum pmt_feature_id id),
+ void (*put)(struct pmt_feature_group *p));
+void intel_aet_unregister_enumeration(void);
+#else
+static inline void intel_aet_register_enumeration(struct module *module,
+ struct pmt_feature_group *(*get)(enum pmt_feature_id id),
+ void (*put)(struct pmt_feature_group *p)) { }
+static inline void intel_aet_unregister_enumeration(void) { }
+#endif /* CONFIG_X86_CPU_RESCTRL_INTEL_AET */
+
#endif
diff --git a/arch/x86/kernel/cpu/resctrl/intel_aet.c b/arch/x86/kernel/cpu/resctrl/intel_aet.c
index 9f0829a82cb0..996a7ee544bf 100644
--- a/arch/x86/kernel/cpu/resctrl/intel_aet.c
+++ b/arch/x86/kernel/cpu/resctrl/intel_aet.c
@@ -17,12 +17,14 @@
#include <linux/cpumask.h>
#include <linux/err.h>
#include <linux/errno.h>
+#include <linux/export.h>
#include <linux/gfp_types.h>
#include <linux/init.h>
#include <linux/intel_pmt_features.h>
#include <linux/intel_vsec.h>
#include <linux/io.h>
#include <linux/minmax.h>
+#include <linux/module.h>
#include <linux/printk.h>
#include <linux/rculist.h>
#include <linux/rcupdate.h>
@@ -325,6 +327,10 @@ static enum pmt_feature_id lookup_pfid(const char *pfname)
return FEATURE_INVALID;
}
+static struct module *pmt_module;
+static struct pmt_feature_group *(*get_feature)(enum pmt_feature_id id);
+static void (*put_feature)(struct pmt_feature_group *p);
+
/*
* Request a copy of struct pmt_feature_group for each event group. If there is
* one, the returned structure has an array of telemetry_region structures,
@@ -359,6 +365,24 @@ bool intel_aet_get_events(void)
return ret;
}
+void intel_aet_register_enumeration(struct module *module,
+ struct pmt_feature_group *(*get)(enum pmt_feature_id id),
+ void (*put)(struct pmt_feature_group *p))
+{
+ get_feature = get;
+ put_feature = put;
+ pmt_module = module;
+}
+EXPORT_SYMBOL_NS_GPL(intel_aet_register_enumeration, "INTEL_PMT");
+
+void intel_aet_unregister_enumeration(void)
+{
+ pmt_module = NULL;
+ get_feature = NULL;
+ put_feature = NULL;
+}
+EXPORT_SYMBOL_NS_GPL(intel_aet_unregister_enumeration, "INTEL_PMT");
+
void __exit intel_aet_exit(void)
{
struct event_group **peg;
--
2.56.0
next prev parent reply other threads:[~2026-10-19 20:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 20:50 [PATCH v14 00/24] Allow AET to use PMT as loadable module Tony Luck
2026-10-19 20:50 ` [PATCH v14 01/24] x86/cpufeatures: Add missing CQM feature dependency Tony Luck
2026-10-19 20:50 ` [PATCH v14 02/24] x86/resctrl: Check if monitoring features are supported Tony Luck
2026-10-19 20:50 ` [PATCH v14 03/24] x86/resctrl: Centralize monitoring feature enumeration Tony Luck
2026-10-19 20:50 ` [PATCH v14 04/24] x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config() Tony Luck
2026-10-19 20:50 ` [PATCH v14 05/24] x86/resctrl: Delete resctrl_cpu_detect() Tony Luck
2026-10-19 20:50 ` [PATCH v14 06/24] arm,x86,fs/resctrl: Replace architecture capability helpers with generic versions Tony Luck
2026-10-19 20:50 ` [PATCH v14 07/24] x86/resctrl: Update special case for Intel Haswell enumeration Tony Luck
2026-10-19 20:50 ` [PATCH v14 08/24] x86/resctrl: Delete rdt_alloc_capable and rdt_mon_capable Tony Luck
2026-10-19 20:50 ` [PATCH v14 09/24] fs/resctrl: Remove redundant calls to resctrl_mon_capable() Tony Luck
2026-10-19 20:50 ` [PATCH v14 10/24] x86/resctrl: Honor rdt={perf|energy} options to force enable AET events Tony Luck
2026-10-19 20:50 ` [PATCH v14 11/24] fs/resctrl: Add interface to disable a monitor event Tony Luck
2026-10-19 20:50 ` [PATCH v14 12/24] arm,x86,fs/resctrl: Allocate maximum needed rmid_ptrs[] Tony Luck
2026-10-19 20:50 ` [PATCH v14 13/24] arm,x86,fs/resctrl: Use right size for L3 monitor data structures Tony Luck
2026-10-19 20:50 ` [PATCH v14 14/24] x86,fs/resctrl: Handle systems where AET is the only monitoring feature Tony Luck
2026-10-19 20:50 ` Tony Luck [this message]
2026-10-19 20:50 ` [PATCH v14 16/24] platform/x86/intel/pmt: Register enumeration functions with resctrl Tony Luck
2026-10-19 20:50 ` [PATCH v14 17/24] x86/resctrl: Use registered function pointers for AET enumeration Tony Luck
2026-10-19 20:50 ` [PATCH v14 18/24] arm,x86,fs/resctrl: Enumerate AET on every resctrl mount Tony Luck
2026-10-19 20:50 ` [PATCH v14 19/24] x86/resctrl: Enforce system RMID limit on AET Tony Luck
2026-10-19 20:50 ` [PATCH v14 20/24] x86/resctrl: Export interface to report telemetry unbind/remove Tony Luck
2026-10-19 20:50 ` [PATCH v14 21/24] platform/x86/intel/pmt: Inform resctrl when MMIO maps are being removed Tony Luck
2026-10-19 20:50 ` [PATCH v14 22/24] x86/resctrl: Require 64-bit x86 for resctrl support Tony Luck
2026-10-19 20:50 ` [PATCH v14 23/24] x86/resctrl: Simplify Kconfig options for resctrl Tony Luck
2026-10-19 20:50 ` [PATCH v14 24/24] x86,fs/resctrl: Document telemetry mount timing caveat Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019205031.16977-16-tony.luck@intel.com \
--to=tony.luck@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=david.e.box@intel.com \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=hch@infradead.org \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=reinette.chatre@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®