From: alexandre.belloni@bootlin.com
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 06/19] rtc: ds1307: use guard
Date: Mon, 19 Oct 2026 23:18:07 +0200 [thread overview]
Message-ID: <20261019211827.126262-6-alexandre.belloni@bootlin.com> (raw)
In-Reply-To: <20261019211827.126262-1-alexandre.belloni@bootlin.com>
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Use guard() to simplify error handling
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-ds1307.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 522f7eef3b4a..0cf4836b81b1 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -579,28 +579,27 @@ static irqreturn_t rx8130_irq(int irq, void *dev_id)
u8 ctl[3];
int ret;
- rtc_lock(ds1307->rtc);
+ guard(rtc_ops)(ds1307->rtc);
/* Read control registers. */
ret = regmap_bulk_read(ds1307->regmap, RX8130_REG_EXTENSION, ctl,
sizeof(ctl));
if (ret < 0)
- goto out;
+ return IRQ_HANDLED;
+
if (!(ctl[1] & RX8130_REG_FLAG_AF))
- goto out;
+ return IRQ_HANDLED;
+
ctl[1] &= ~RX8130_REG_FLAG_AF;
ctl[2] &= ~RX8130_REG_CONTROL0_AIE;
ret = regmap_bulk_write(ds1307->regmap, RX8130_REG_EXTENSION, ctl,
sizeof(ctl));
if (ret < 0)
- goto out;
+ return IRQ_HANDLED;
rtc_update_irq(ds1307->rtc, 1, RTC_AF | RTC_IRQF);
-out:
- rtc_unlock(ds1307->rtc);
-
return IRQ_HANDLED;
}
--
2.56.0
next prev parent reply other threads:[~2026-10-19 21:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 21:18 [PATCH 01/19] rtc: introduce rtc_device.ops_lock guard() alexandre.belloni
2026-10-19 21:18 ` [PATCH 02/19] rtc: ac100: use guard alexandre.belloni
2026-10-19 21:18 ` [PATCH 03/19] rtc: asm9260: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 04/19] rtc: atcrtc100: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 05/19] rtc: ds1305: " alexandre.belloni
2026-10-19 21:18 ` alexandre.belloni [this message]
2026-10-19 21:18 ` [PATCH 07/19] rtc: ds1343: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 08/19] rtc: ds1685: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 09/19] rtc: ds3232: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 10/19] rtc: hym8563: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 11/19] rtc: m41t80: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 12/19] rtc: mcp795: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 13/19] rtc: nct6694: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 14/19] rtc: pcf2123: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 15/19] rtc: rv3029c2: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 16/19] rtc: rx8010: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 17/19] rtc: rx8025: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 18/19] rtc: stm32: " alexandre.belloni
2026-10-19 21:18 ` [PATCH 19/19] rtc: abx80x: simplify locking alexandre.belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019211827.126262-6-alexandre.belloni@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®