mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Jiri Slaby" <jirislaby@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	"Uwe Kleine-König (The Capable Hub)"
	<u.kleine-koenig@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] [v3] serial: 8250: remove obsolete and broken PORT_RSA support
Date: Mon, 19 Oct 2026 11:39:20 +0200	[thread overview]
Message-ID: <2026101952-wham-earthly-c149@gregkh> (raw)
In-Reply-To: <20261019090017.430425-1-arnd@kernel.org>

On Mon, Oct 19, 2026 at 10:56:55AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> For all I can tell, the RSA support in the 8250 driver is not functional
> and has not been for a long time.
> 
> The RSA-DV II/S ISA card[1] was sold by IODATA in the 1990s as a faster
> alternative to regular ISA serial ports, and it was discontinued in
> 2002. Linux support was added by Kiyokazu SUTO in 2000.
> 
> The driver defines an I/O port base address of -8 (negative eight),
> which should always get refused by request_region on all architectures
> for being outside of the valid resource range.
> 
> Further, it seems that a patch to setserial would be required in order
> to set PORT_RSA when not using autoconfiguration.
> 
> This patch removes all code related to the RSA support, with the exception
> of the user-visible PORT_RSA definition.
> 
> Link: http://translate.google.com/translate?hl=en&sl=ja&u=http://www.iodata.jp/products/network/rsadv2s.htm
> Link: https://lore.kernel.org/all/1309211120-2803-6-git-send-email-arnd@arndb.de/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: rebased my own patch after 15 years
> v3: fix up Makefile and sunsu.c file
> ---
>  drivers/tty/serial/8250/8250.h          |  17 --
>  drivers/tty/serial/8250/8250_core.c     |   6 -
>  drivers/tty/serial/8250/8250_platform.c |   4 -
>  drivers/tty/serial/8250/8250_port.c     |   8 -
>  drivers/tty/serial/8250/8250_rsa.c      | 209 ------------------------
>  drivers/tty/serial/8250/Kconfig         |  11 --
>  drivers/tty/serial/8250/Makefile        |   1 -
>  drivers/tty/serial/sunsu.c              |  92 -----------
>  include/uapi/linux/serial_reg.h         |  51 ------
>  9 files changed, 399 deletions(-)
>  delete mode 100644 drivers/tty/serial/8250/8250_rsa.c

Any objection for me to sneak this into 7.4-rc1?

thanks,

greg k-h

  reply	other threads:[~2026-10-19  9:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19  8:56 Arnd Bergmann
2026-10-19  9:39 ` Greg Kroah-Hartman [this message]
2026-10-19 10:25   ` Andy Shevchenko
2026-10-19 10:23 ` Andy Shevchenko
2026-10-19 15:06 ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026101952-wham-earthly-c149@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®