From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=100.103.45.18 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1792482883; b=CiYACMPgxn7Z1K6eGCAz7D7GUtVGjNFJuXULxzUk09IncFvJz5e7emXq4YF8yigZqzBo +5Detsu4+c5ZoFTc6p0jFlnlhhw/Q6R7JaFMEzLF8+RVNS6ne6ECHr4yA1XCSI0O8HcHw qBJvYSQUA6L1E7PNmgihKeFiKJHJSuDSwXAZZd7geFQtqS3BdRGrpXbDvb26fCIw2Wt9X rOBgDnUPZ/CFqJDl1LCHK+CXQ857ORw0/ie7xQz55xUhXqar6R9DVCfY9PPcWzqF+N9is DUAi0B8fEdaNgH7UIxskOoquKxHeRRtPvBs9lXDppwe+zpAzwl6m/CNZ3LiOD8f5RGA== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792482883; h=Received:DKIM-Signature:Received:From:Date:Subject:MIME-Version: Content-Type:Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Endpoint-Received: X-Original-From:Reply-To:Content-Transfer-Encoding; bh=ZOfwWlMhSfoJ2Ju/rK9PnaxQgiy2kXpt3sLhqzS+2o4=; b=P4kbwpXkFK3GQohnOshJ4vjzstn+snFbu+5wm+3/LXbkYNUAisT1f0FadKQKIa04E3fz HcABo3Du9tqCIU8D+DLdsOHhcsl0qyBti/btRjnawk+sq6SH+ynPSvHG68Yj6ZC7XWdH5 1LoPNRbC05/gnTnEA5vkiiLXiJOUTahrhnqgrKb5esUvnY/NgRD+VaZAxiJyi7+ETrck7 kouh0iRSv3Rb+sD5EVwvewl35M9DdeauTXbCKGG8qgOgVe3mAi+V2Hu4baaWfMRP711F1 36ehKnZ1bYRB7dAPvknTuXh8bwaNqPckmcKv8wDd2OzmZOMF0an/5d0AnwxLGMXmw1Q== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=FI46pcpT; arc=pass header.oldest-pass=0 smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 124D0606A32E; Tue, 20 Oct 2026 07:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=FI46pcpT Authentication-Results: smtp.kernel.org; arc=none smtp.remote-ip=100.80.115.77 ARC-Seal: i=1; d=kernel.org; s=arc20260519; a=rsa-sha256; cv=none; t=1792482882; b=UkDBOJg6G0i5+BR3K2XSYFmHYz4izHFZh2+esaNoUjC8QuStxYGVC0S2tbe0b20efXSg 0eqo2nHRAe2VkPHkhM3Vi05cOE1/u/yJdfl7xUhVj5tAfn8l0mjdtiklpwsVgA4agCDO7 sge/eZgJgk0mlb0y8XTClKWc4RLjyrnlKsDPqdGwZQD/FYwAZHzd61q1e3BBk1/GGkfsK KSTm8kWUcuSun2cdhe3vFmN132XbKWl9X9oIcflXfmyiZRXs2pbdHWbeO0e0z6DH6grmE l6lopIEaWsc3Oqbki/LT3oieSAsmK83Y9yyKzAQ1egzxrkzwgEXULhepfEZhQ2oED5Q== ARC-Message-Signature: i=1; d=kernel.org; s=arc20260519; a=rsa-sha256; c=relaxed/relaxed; t=1792482882; h=DKIM-Signature:Received:From:Date:Subject:MIME-Version:Content-Type: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Endpoint-Received: X-Original-From:Reply-To:Content-Transfer-Encoding; bh=ZOfwWlMhSfoJ2Ju/rK9PnaxQgiy2kXpt3sLhqzS+2o4=; b=VIPYXizAltQtvFV6GkZO3I2E00idtj4OCtOBVysNNB1z3RCwQ9WBFXqTshzlQiJ7E7Jr X72uC+pdWOoxDy4PTPuL3EEXM74FefigAbPAyRoua0BdcHINPN8WTpulBNIguXLo5ClKy bgFMscZV4RguOtjfBFF5WjTFjHHWBV61Jk6bCq3WEd+cokuYNrfbM/T2YbP3btraDKV6d HIITI1XIFpWr1d7PsOPg1vJAeEQSR8Iwfuj6EmrYiUepBVYdTXWXbhED5u4erXVS51VZW XC/h5H6+7tt7G3lJyQkhUa6vfqHmNDvtNjtxi0gfb9Mv4BT8nsnuQFRkcuGGlPz4V9w== ARC-Authentication-Results: i=1; smtp.kernel.org; arc=none smtp.remote-ip=100.80.115.77 Received: from lkml.kernel.org (nexus.subspace.kernel.org [100.80.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 1C56D1F000C5; Tue, 20 Oct 2026 07:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792482882; bh=ZOfwWlMhSfoJ2Ju/rK9PnaxQgiy2kXpt3sLhqzS+2o4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To; b=FI46pcpTklOf6bEN8glmnk+TCegqyqf5Jp8m5zeuBkqsj3UkIvqmLXri0PZ5atpps /kMtmJSzuwcBqeoeE+vk3GyxXjvaBR/zQ+T6SzfmYooMaTre6ZduisnR2WEM+IXJFf C0zIW6m6WN1GkHfI9Sv0aNMD66UQRKgT5S7wxRcGVjccSq1s5BwOrIhDmOagx4AmP9 rP1XxArg8TdWwLlB6+MlOcnKu4TobHFdOsPdCERFH3UBRIirj5zXgQykhX+zDX4+wS VW5NEiyViMnx2z0oQizEj3osDJf8PGTO0yIBw7ssaPB9HT/RwLhIQV1ySiJI4eUiS0 hrLce/FeLl7pA== Received: from nexus.subspace.kernel.org (localhost [IPv6:::1]) by lkml.kernel.org (Postfix) with ESMTP id 8AC1F43092; Tue, 20 Oct 2026 07:54:40 +0000 (UTC) From: Long Zhao via B4 Relay Date: Tue, 20 Oct 2026 15:54:08 +0800 Subject: [PATCH v11 4/9] gpio: pl061: convert register access to regmap X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <20261020-cv75-gpio-v11-4-e058bae19571@ambarella.com> References: <20261020-cv75-gpio-v11-0-e058bae19571@ambarella.com> In-Reply-To: <20261020-cv75-gpio-v11-0-e058bae19571@ambarella.com> To: Bartosz Golaszewski , linux-gpio@vger.kernel.org Cc: Linus Walleij , Michael Walle , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Krzysztof Kozlowski , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Long Zhao , Long Zhao , linux-kernel@vger.kernel.org, Chanho Min X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1792482878; l=11491; i=longzhao@ambarella.com; s=20260730; h=from:subject:message-id; bh=ZGKF2dN3rQu8suQcIDaV6ZAl14rQS1nyK8VOegoyl38=; b=B70gK74oQV8do6KeV35I9uCTXzGnBad9aSjwZnr9ZzY24nndRCfelFCcC761w9MnEsNH9PjSZ ooua5a4fNccDFjv8qOAgL86AGA5MTxUXgzqYCn7CncRibFRVJKlLWq0 X-Developer-Key: i=longzhao@ambarella.com; a=ed25519; pk=/xGhPTOX0/eYsyTWzyjjgAIW1Z/YD+IlnOnvcdRozow= X-Endpoint-Received: by B4 Relay for longzhao@ambarella.com/20260730 with auth_id=903 X-Original-From: Long Zhao Reply-To: longzhao@ambarella.com Content-Transfer-Encoding: 7bit From: Long Zhao Replace readb()/writeb() with a MMIO regmap while keeping the existing gpio_chip and girq irqchip. Use a raw spinlock so irq_ack() can run under the irq descriptor lock. Reviewed-by: Linus Walleij Reviewed-by: Andy Shevchenko Tested-by: Chanho Min Signed-off-by: Long Zhao --- drivers/gpio/Kconfig | 1 + drivers/gpio/gpio-pl061.c | 137 ++++++++++++++++++++++++++++++---------------- 2 files changed, 91 insertions(+), 47 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index f03c05288376..2a1487bd1a94 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -583,6 +583,7 @@ config GPIO_PL061 depends on ARM_AMBA || COMPILE_TEST select IRQ_DOMAIN select GPIOLIB_IRQCHIP + select REGMAP_MMIO help Say yes here to support the PrimeCell PL061 GPIO device. diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c index 721f14cf404e..5f0b845eb096 100644 --- a/drivers/gpio/gpio-pl061.c +++ b/drivers/gpio/gpio-pl061.c @@ -19,9 +19,11 @@ #include #include #include +#include #include #include #include +#include #include #include #include @@ -36,6 +38,7 @@ #define GPIOIC 0x41C #define PL061_GPIO_NR 8 +#define PL061_DATA_OFFSET 2 struct pl061_context_save_regs { u8 gpio_data; @@ -49,18 +52,51 @@ struct pl061_context_save_regs { struct pl061 { raw_spinlock_t lock; - void __iomem *base; + struct regmap *regmap; struct gpio_chip gc; int parent_irq; struct pl061_context_save_regs csave_regs; }; +static bool pl061_arm_is_data_reg(unsigned int reg) +{ + return reg >= BIT(PL061_DATA_OFFSET) && + reg <= BIT(PL061_DATA_OFFSET + PL061_GPIO_NR - 1) && + is_power_of_2(reg); +} + +static bool pl061_arm_volatile_reg(struct device *dev, unsigned int reg) +{ + switch (reg) { + case GPIOMIS: + case GPIOIC: + return true; + default: + return pl061_arm_is_data_reg(reg); + } +} + +static const struct regmap_config pl061_arm_regmap_config = { + .reg_bits = 16, + .val_bits = 8, + .reg_stride = 4, + .max_register = GPIOIC, + .volatile_reg = pl061_arm_volatile_reg, + .cache_type = REGCACHE_FLAT_S, + .use_raw_spinlock = true, +}; + static int pl061_get_direction(struct gpio_chip *gc, unsigned offset) { struct pl061 *pl061 = gpiochip_get_data(gc); + int ret; - if (readb(pl061->base + GPIODIR) & BIT(offset)) + ret = regmap_test_bits(pl061->regmap, GPIODIR, BIT(offset)); + if (ret < 0) + return ret; + + if (ret) return GPIO_LINE_DIRECTION_OUT; return GPIO_LINE_DIRECTION_IN; @@ -70,12 +106,9 @@ static int pl061_direction_input(struct gpio_chip *gc, unsigned offset) { struct pl061 *pl061 = gpiochip_get_data(gc); unsigned long flags; - unsigned char gpiodir; raw_spin_lock_irqsave(&pl061->lock, flags); - gpiodir = readb(pl061->base + GPIODIR); - gpiodir &= ~(BIT(offset)); - writeb(gpiodir, pl061->base + GPIODIR); + regmap_clear_bits(pl061->regmap, GPIODIR, BIT(offset)); raw_spin_unlock_irqrestore(&pl061->lock, flags); return 0; @@ -86,19 +119,19 @@ static int pl061_direction_output(struct gpio_chip *gc, unsigned offset, { struct pl061 *pl061 = gpiochip_get_data(gc); unsigned long flags; - unsigned char gpiodir; + unsigned int mask = BIT(offset); raw_spin_lock_irqsave(&pl061->lock, flags); - writeb(!!value << offset, pl061->base + (BIT(offset + 2))); - gpiodir = readb(pl061->base + GPIODIR); - gpiodir |= BIT(offset); - writeb(gpiodir, pl061->base + GPIODIR); + regmap_assign_bits(pl061->regmap, BIT(offset + PL061_DATA_OFFSET), + BIT(offset), value); + regmap_set_bits(pl061->regmap, GPIODIR, mask); /* * gpio value is set again, because pl061 doesn't allow to set value of * a gpio pin before configuring it in OUT mode. */ - writeb(!!value << offset, pl061->base + (BIT(offset + 2))); + regmap_assign_bits(pl061->regmap, BIT(offset + PL061_DATA_OFFSET), + BIT(offset), value); raw_spin_unlock_irqrestore(&pl061->lock, flags); return 0; @@ -108,16 +141,17 @@ static int pl061_get_value(struct gpio_chip *gc, unsigned offset) { struct pl061 *pl061 = gpiochip_get_data(gc); - return !!readb(pl061->base + (BIT(offset + 2))); + return regmap_test_bits(pl061->regmap, BIT(offset + PL061_DATA_OFFSET), + BIT(offset)); } static int pl061_set_value(struct gpio_chip *gc, unsigned int offset, int value) { struct pl061 *pl061 = gpiochip_get_data(gc); - writeb(!!value << offset, pl061->base + (BIT(offset + 2))); - - return 0; + return regmap_assign_bits(pl061->regmap, + BIT(offset + PL061_DATA_OFFSET), + BIT(offset), value); } static int pl061_irq_type(struct irq_data *d, unsigned trigger) @@ -125,9 +159,11 @@ static int pl061_irq_type(struct irq_data *d, unsigned trigger) struct gpio_chip *gc = irq_data_get_irq_chip_data(d); struct pl061 *pl061 = gpiochip_get_data(gc); int offset = irqd_to_hwirq(d); + unsigned int bit = BIT(offset); + unsigned int gpioiev = 0; + unsigned int gpioibe = 0; + unsigned int gpiois = 0; unsigned long flags; - u8 gpiois, gpioibe, gpioiev; - u8 bit = BIT(offset); if (offset < 0 || offset >= PL061_GPIO_NR) return -EINVAL; @@ -145,9 +181,9 @@ static int pl061_irq_type(struct irq_data *d, unsigned trigger) raw_spin_lock_irqsave(&pl061->lock, flags); - gpioiev = readb(pl061->base + GPIOIEV); - gpiois = readb(pl061->base + GPIOIS); - gpioibe = readb(pl061->base + GPIOIBE); + regmap_read(pl061->regmap, GPIOIEV, &gpioiev); + regmap_read(pl061->regmap, GPIOIS, &gpiois); + regmap_read(pl061->regmap, GPIOIBE, &gpioibe); if (trigger & (IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_LEVEL_LOW)) { bool polarity = trigger & IRQ_TYPE_LEVEL_HIGH; @@ -199,9 +235,9 @@ static int pl061_irq_type(struct irq_data *d, unsigned trigger) offset); } - writeb(gpiois, pl061->base + GPIOIS); - writeb(gpioibe, pl061->base + GPIOIBE); - writeb(gpioiev, pl061->base + GPIOIEV); + regmap_write(pl061->regmap, GPIOIS, gpiois); + regmap_write(pl061->regmap, GPIOIBE, gpioibe); + regmap_write(pl061->regmap, GPIOIEV, gpioiev); raw_spin_unlock_irqrestore(&pl061->lock, flags); @@ -211,6 +247,7 @@ static int pl061_irq_type(struct irq_data *d, unsigned trigger) static void pl061_irq_handler(struct irq_desc *desc) { unsigned long pending; + unsigned int mis = 0; int offset; struct gpio_chip *gc = irq_desc_get_handler_data(desc); struct pl061 *pl061 = gpiochip_get_data(gc); @@ -218,7 +255,8 @@ static void pl061_irq_handler(struct irq_desc *desc) chained_irq_enter(irqchip, desc); - pending = readb(pl061->base + GPIOMIS); + regmap_read(pl061->regmap, GPIOMIS, &mis); + pending = mis; for_each_set_bit(offset, &pending, PL061_GPIO_NR) generic_handle_domain_irq(gc->irq.domain, offset); @@ -230,11 +268,9 @@ static void pl061_irq_mask(struct irq_data *d) struct gpio_chip *gc = irq_data_get_irq_chip_data(d); struct pl061 *pl061 = gpiochip_get_data(gc); u8 mask = BIT(irqd_to_hwirq(d) % PL061_GPIO_NR); - u8 gpioie; raw_spin_lock(&pl061->lock); - gpioie = readb(pl061->base + GPIOIE) & ~mask; - writeb(gpioie, pl061->base + GPIOIE); + regmap_clear_bits(pl061->regmap, GPIOIE, mask); raw_spin_unlock(&pl061->lock); gpiochip_disable_irq(gc, d->hwirq); @@ -245,13 +281,11 @@ static void pl061_irq_unmask(struct irq_data *d) struct gpio_chip *gc = irq_data_get_irq_chip_data(d); struct pl061 *pl061 = gpiochip_get_data(gc); u8 mask = BIT(irqd_to_hwirq(d) % PL061_GPIO_NR); - u8 gpioie; gpiochip_enable_irq(gc, d->hwirq); raw_spin_lock(&pl061->lock); - gpioie = readb(pl061->base + GPIOIE) | mask; - writeb(gpioie, pl061->base + GPIOIE); + regmap_set_bits(pl061->regmap, GPIOIE, mask); raw_spin_unlock(&pl061->lock); } @@ -269,9 +303,7 @@ static void pl061_irq_ack(struct irq_data *d) struct pl061 *pl061 = gpiochip_get_data(gc); u8 mask = BIT(irqd_to_hwirq(d) % PL061_GPIO_NR); - raw_spin_lock(&pl061->lock); - writeb(mask, pl061->base + GPIOIC); - raw_spin_unlock(&pl061->lock); + regmap_write(pl061->regmap, GPIOIC, mask); } static int pl061_irq_set_wake(struct irq_data *d, unsigned int state) @@ -305,15 +337,20 @@ static int pl061_probe(struct amba_device *adev, const struct amba_id *id) struct device *dev = &adev->dev; struct pl061 *pl061; struct gpio_irq_chip *girq; + void __iomem *base; int ret, irq; pl061 = devm_kzalloc(dev, sizeof(*pl061), GFP_KERNEL); if (pl061 == NULL) return -ENOMEM; - pl061->base = devm_ioremap_resource(dev, &adev->res); - if (IS_ERR(pl061->base)) - return PTR_ERR(pl061->base); + base = devm_ioremap_resource(dev, &adev->res); + if (IS_ERR(base)) + return PTR_ERR(base); + + pl061->regmap = devm_regmap_init_mmio(dev, base, &pl061_arm_regmap_config); + if (IS_ERR(pl061->regmap)) + return PTR_ERR(pl061->regmap); raw_spin_lock_init(&pl061->lock); pl061->gc.request = gpiochip_generic_request; @@ -332,7 +369,7 @@ static int pl061_probe(struct amba_device *adev, const struct amba_id *id) /* * irq_chip support */ - writeb(0, pl061->base + GPIOIE); /* disable irqs */ + regmap_write(pl061->regmap, GPIOIE, 0); /* disable irqs */ irq = adev->irq[0]; if (!irq) dev_warn(&adev->dev, "IRQ support disabled\n"); @@ -363,14 +400,20 @@ static int pl061_probe(struct amba_device *adev, const struct amba_id *id) static int pl061_suspend(struct device *dev) { struct pl061 *pl061 = dev_get_drvdata(dev); + unsigned int val = 0; int offset; pl061->csave_regs.gpio_data = 0; - pl061->csave_regs.gpio_dir = readb(pl061->base + GPIODIR); - pl061->csave_regs.gpio_is = readb(pl061->base + GPIOIS); - pl061->csave_regs.gpio_ibe = readb(pl061->base + GPIOIBE); - pl061->csave_regs.gpio_iev = readb(pl061->base + GPIOIEV); - pl061->csave_regs.gpio_ie = readb(pl061->base + GPIOIE); + regmap_read(pl061->regmap, GPIODIR, &val); + pl061->csave_regs.gpio_dir = val; + regmap_read(pl061->regmap, GPIOIS, &val); + pl061->csave_regs.gpio_is = val; + regmap_read(pl061->regmap, GPIOIBE, &val); + pl061->csave_regs.gpio_ibe = val; + regmap_read(pl061->regmap, GPIOIEV, &val); + pl061->csave_regs.gpio_iev = val; + regmap_read(pl061->regmap, GPIOIE, &val); + pl061->csave_regs.gpio_ie = val; for (offset = 0; offset < PL061_GPIO_NR; offset++) { if (pl061->csave_regs.gpio_dir & (BIT(offset))) @@ -395,10 +438,10 @@ static int pl061_resume(struct device *dev) pl061_direction_input(&pl061->gc, offset); } - writeb(pl061->csave_regs.gpio_is, pl061->base + GPIOIS); - writeb(pl061->csave_regs.gpio_ibe, pl061->base + GPIOIBE); - writeb(pl061->csave_regs.gpio_iev, pl061->base + GPIOIEV); - writeb(pl061->csave_regs.gpio_ie, pl061->base + GPIOIE); + regmap_write(pl061->regmap, GPIOIS, pl061->csave_regs.gpio_is); + regmap_write(pl061->regmap, GPIOIBE, pl061->csave_regs.gpio_ibe); + regmap_write(pl061->regmap, GPIOIEV, pl061->csave_regs.gpio_iev); + regmap_write(pl061->regmap, GPIOIE, pl061->csave_regs.gpio_ie); return 0; } -- 2.34.1