Re: [PATCH net-next 1/2] dt-bindings: net: pse-pd: realtek,pse: add gen1 I2C transport

[Krzysztof Kozlowski <krzk@kernel.org>]

On Sun, Oct 18, 2026 at 06:12:47PM +0200, Sander Vanheule wrote:
> Like the gen2 protocol, the gen1 protocol can also be used over both a
> raw I2C transport and an SMBUs transport. Add a compatible for the
> former and the compatible for the Ubiquiti Unifi Switch Lite 16 PoE
> device that uses it.
> 
> Signed-off-by: Sander Vanheule <sander@svanheule.net>
> ---
>  .../bindings/net/pse-pd/realtek,pse-mcu-gen1.yaml          | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/pse-pd/realtek,pse-mcu-gen1.yaml b/Documentation/devicetree/bindings/net/pse-pd/realtek,pse-mcu-gen1.yaml
> index 3bb32349c28c..526f8525bb4d 100644
> --- a/Documentation/devicetree/bindings/net/pse-pd/realtek,pse-mcu-gen1.yaml
> +++ b/Documentation/devicetree/bindings/net/pse-pd/realtek,pse-mcu-gen1.yaml
> @@ -54,6 +54,12 @@ properties:
>                - zyxel,gs1920-24hp-v2-pse
>            - const: realtek,pse-mcu-gen1-smbus
>  
> +      # I2C, raw framing
> +      - items:
> +          - enum:
> +              - ubnt,usw-lite-16-poe-pse
> +          - const: realtek,pse-mcu-gen1-i2c
> +
>        # UART
>        - items:
>            - enum:
> @@ -100,6 +106,7 @@ allOf:
>            contains:
>              enum:
>                - realtek,pse-mcu-gen1-smbus
> +              - realtek,pse-mcu-gen1-i2c

That's the same device as smbus, no? Same device, same compatible.

You can have property deciding about protocol, if this cannot be deduced
from the clients.

Best regards,
Krzysztof