From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792500433; b=PDXWskK5dAJjDDxJPJuXEJlE/wopfeCHzgRM4lvbiaBvUIALJCXy3nUIECopHNoetFpT OULyvrH4FutKWL8D7RuEk34ddU3M8zgL1m8NVaT2Vswp673HNMPA1LSj2NyxdNo7/Gh+K hIYrlNCbdtK6ESMI8c2DJrlmgMaFulDRQBInOlKNtWVa+EhTWUifD11PUoF0l4lj9/n2I LkIqR2FoSeYaVreneuUjpAyTMB91JNlQgzUxAhLGr+ARS4O5/EzMeCdFezJYVuqrp2ift W2WVUtmyje37knclsVwgNziOFi6uGXXip24eWlcSH7HWkvvmsHXJdtDsn4W3JfDEkfA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792500433; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From: Subject:Date:Message-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:X-B4-Tracking:X-Change-ID:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Proofpoint-Spam-Details-Enc: X-Authority-Analysis:X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Info:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=C/HunTessReFhmQLSotB/lpU2t4TZwXk7X6wvQ6Dwts=; b=Kis6RR3yKIUbVCX3VA+DIlY1V+SAAhZO/4fGjZ/PCy4zAE11JWi4ozvhl2W86YBuemJD /CPVkbk8AnHyVZMm5iS3gdNLKOgtPovANsef35PUuIwUkAlMcTuC5g7oF+S3keUmE5vct NdwFGK0AH6plL8ae1/9SvKfOpGBZzKiTEp+dtAFkQ9YMI3ol7Z9U2X0mh+3ol4qW5S92U 7K0qInjKsnYfSiKyIpanYtWeBnePpXvS4nUrxjSK89suS1FvYecUtWzgfUP2TQtEr+nmt PFbthcG9RPjKOYyly43DH7tLanigSUkVULpEaPn4z0QuWHRfR7lPQJiPKFavEMbd1bg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=VyokrXee; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=f7xDjVWt; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 844C8606A336 for ; Tue, 20 Oct 2026 12:47:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 844C8606A336 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=VyokrXee; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=f7xDjVWt Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69KAx9LY419818 for ; Tue, 20 Oct 2026 12:47:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=C/HunTessReFhmQLSotB/l pU2t4TZwXk7X6wvQ6Dwts=; b=VyokrXeehHHkJdVm5FZVHFj3XFrfyvK5xifQM7 JzsJlmIKeFFsO6Sajz2Ku79F3/A4XoUlmtIzCUbpD6azwu8881hYkiV1irj5hcTu DgavnPi6YCd68lbZKb/hWvpTrhk4/ODoG9JltqvwEJQFDSX0Nphm1RF+JhMRColt kSuDBlfPHON2Jiu2OPjFLAnpKGJLNEFB3jG6xwj9KH6OnAAR4z9YjOWog8U8127h UcB90Kv6goGBOuVcUx2jXOSDORKHo/eoM+3RdcmGZ4KPkY3LRwpHBdjkV5N85dXH H1S64d4l95oUbGZzfQ9xEhPloC1ZZkJXBkEyYYs/nrzLP9qg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hdw5stf7p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Oct 2026 12:47:11 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93a082c014aso152105485a.0 for ; Tue, 20 Oct 2026 05:47:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792500430; x=1793105230; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=C/HunTessReFhmQLSotB/lpU2t4TZwXk7X6wvQ6Dwts=; b=f7xDjVWtb4UEFkaCapyiwwlnjQIakLuwJjFFzYVkRThAXvGHQXzhA9yAz6UM6tsfnR mQgKgiBy/yVUD9u7AJ4Bvrb6eoSnowWbK0lUBat4ccuWul0NHoJn1G0Rc2jE+oiPQxaq MvTO+QJH1Cis5RoyGKKxpGH0h6c/2iJxN6wMTmdD8nIBtNvXnAO9oCVIUWSUkSmDGaof A8vAdgU4F6O8KB36pQNtDdHYmztIfEyjNZ82UYKWjnPzvWC8yOfmKPCAadbTmi1DOAcs OyHWyg2rATmf8vN8/cghdmsKWHLb2LCdRTf9x6ccxFfE2O/3WfItcqMfgSoIFc8WtGnq NzLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792500430; x=1793105230; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=C/HunTessReFhmQLSotB/lpU2t4TZwXk7X6wvQ6Dwts=; b=2E0ot3bVFKil/QcFlk+79rw7bjIoaoQbqYbwZcmsATsnBE+ck2e4mshr9QP3ARSSHi p/uERg7HXtRDm5AbUuzriNmoVnWbrmE9IbK3wDVC2vEzxGc6x68lybhlT938doxMkpsQ E030UvtJSTaKx9EM0eodJ6dWHoXfVZGPeX2cipx3+M5RCDQSGE8CBt/Y+F9z8GNOLY7K MA1CB6on1Q39xbf/ObsQ52jB5UWBu4lQJy0dW3qsDz/OutfRSQZD1ttVzt5iOun8xd9l Ibec9k/K6ZGhM9GGU6mC6ZOTVaEuxOxDYBtKQ7MVw7OB8GxVKcslxThb/NReL7OZhHDD As1w== X-Forwarded-Encrypted: i=1; AKwUvBxi/M6S78sMIirPq+o7eSRKSPoK8jvX584r/zGXvmEBaXx8q7DY7y+kQz4UsXjuRLlQcuddF6eM5zgs0io=@vger.kernel.org X-Gm-Message-State: AFq9FYKcFiLxjLU4lZEOQT8m+NRhVrqG8mnKzbWqLyzOue6F7BDWy7wy mLJq2s5x9NzQ7zxXJ5ui01L5dxHp1D9vJ4i13Bsc9zdl8zWWMn6lyAQWUR1lC93webotAIf3wJ+ zuMgkQuBbA2JDr+yhN0nSPKX6EDKKH8W+VnH222hQ2WlNf22O+bXKecwf9Hcdikgqse8= X-Gm-Gg: AYBFou3KgI8caGByvbAXFeNqa0e+5CZWz1jjonkJsyJqEDc5/zA7V2CV2u+tEurFquC yttUOoXjucoDJI7qUIHWMJUjiRfZMpnrCcfHLH18snpf0ck60hnGjXRtqyYrc6mB3Tm2tE53V9a LMNTF1bcSRl8ks4V+j7Yazf2OnwxC9fyzOVLMTrMi7QYJH36gHYz2UTtiDnJ5lg3TWp6eHHgXcq vIfqUXeU7z7SRTN0vbiwqo4RuI3+PMSN/bvwAM7vU7S5mz1K1KQsalKCbpMGPH6C0DCJyogUAjJ /1SRH6ps3NfMB07I0gZOANtF5riyVqBzCarCxyW1N1kShCP7tBJURwFRyLUaamCyeSScFvUYH5U s89KTqF0I6CSRJE7u4XFeYwzdq+N0 X-Received: by 2002:a05:620a:649b:b0:939:5d22:d1f0 with SMTP id af79cd13be357-93f4c195bc6mr282061485a.2.1792500430321; Tue, 20 Oct 2026 05:47:10 -0700 (PDT) X-Received: by 2002:a05:620a:649b:b0:939:5d22:d1f0 with SMTP id af79cd13be357-93f4c195bc6mr282057685a.2.1792500429834; Tue, 20 Oct 2026 05:47:09 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:8916:7b9b:97a2:6c96]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e1d82456asm6544253f8f.42.2026.10.20.05.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 05:47:08 -0700 (PDT) From: Bartosz Golaszewski Subject: [PATCH v12 0/3] crypto - qce: fix self-test issues in aead Date: Tue, 20 Oct 2026 14:47:00 +0200 Message-Id: <20261020-qce-fixes-aead-v12-0-77a2e09abd0c@oss.qualcomm.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAMRi12oC/3WNwQrCMBBEf6Xs2S3ZSCr15H9IDyHd2oBtbFaLU vLvrr17GZh5zMwGwjmywLnaIPMaJaZZDdlDBWH0840x9hqANbYhQy0ugXGIbxb07Htka9vBW0O Oj6ClR+adaufaqR+jPFP+7Acr0S/+u6UcDRIF50I4+aZ1lyRSLy9/D2maahXoSilfF7aqXrYAA AA= X-Change-ID: 20261019-qce-fixes-aead-e229fa2015e3 To: Bartosz Golaszewski , Herbert Xu , "David S. Miller" , Eneas U de Queiroz , Kuldeep Singh , Eric Biggers , Demi Marie Obenour , Bjorn Andersson , Konrad Dybcio , Russell King , Abel Vesa Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org, Pankaj Patil X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4027; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=9SmK/a7pYcCxWS3GjVR7mF4MMQ+9o9U9EbjnwSAG0Ec=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBq12LLSsT8ijo536Kr2PkhXNVQXtjWYrWtLZygk IAcAHzsE4uJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCatdiywAKCRAFnS7L/zaE w6uWD/9xqQcA4sfVULidrbG+1ZK96dDcE9jqEmkGd2l9OEaLvZFeuED7y3/j0c8AQMSyJY9syIM S1pM+WjIohiXyWwQEjr0yNMXgsZOxcxuNWyFSiq9G8MC9gvxgiTQyET7Ct1E6XNU3uySIaxUtGF JJUPZK1vdhZZ9vE46zR045xDDXI0P/WGlnPGzF6y+uaG6YVUam1UzCY1H2Ro+qzOpRV1e3MsAH3 3ttUnvctXiBV79RImNW/CM6gigX4rJtTX1oJ+MqN5mdM7YaDNmNwvKS0ttnZOUyLtj/pyf/KVAE 305g/kbPQ78YwEJwDj086Q8ey+WpFzcsKeB4zaAvspiN1Kyqd/6+wo/G8UOXj95TagmRJSrmj83 eMDfKvZeFEmrxfgCtGvVz1GcxtvV466AgvyX9JpTi5sdntB846d2xMAY3lIShn5VO331Ei76oP5 v1OQNAKI8odQ+7plPJHF+SxulKXPssZ5zXmR5XHU5BdiDXgxjUIu0g2ocGsvv7TbJrXIfDFleLn QhdUEc37emrd0uSeHg/49HgW5iOXbd7IWuEdDP8MYKGPGZoJobqW5SJg+m0tBYPwMhBJmgookD3 QvZbGSV0CUEieI/JlYEzvYP70eRQjodJqx3rbpmPeK26aue/ozMWMB9cu9j5GEDy0tFxPS7FuSp gQ8oyw0qrLISroA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIwMDA1MCBTYWx0ZWRfX3m5MFYEDg+2a Y4FyesPuKeTry7g4SRaQQOUO4Ise+hhCa//k2FBdeUWJjVeVRaX9/ZUi1xDI90JD07ELW8c0iax Hg39DR3WlWANLmFEKLAMl0b7V2NjGLNZptoLmi1lA9xLO4vUTk/p/PQ44JcnBGm0Z8dlxewpQys dFVstM4N40LISxrwzO6olx+joaUdQEUm18Epqo5MBwEX7HtXUHQ9wwF3rv7rInuo7XhrgLvtt4l PMN11k6Y5lPDnj++xfiCI2NxP+LhU5J3UNy3M4wnYXVe6hs0dkqzrm7CrJOIQ+1VGJKCvjnIzE4 rK464mEpERq1u+7eX1T051s+8b5dAgrLuT3JFGV8gP89TIz388UDoVD2Vf0ghEH6RZ1mjO4Atuq /K2qx9ypu/ZQ7GXngnOrYN7ohvp2XLV/4VXhl6FNDvz1kWzPL6UfgufM/CVgBmWsX5LsLmpZZNg khlf2OlpIbH2A9L9T1g== X-Authority-Analysis: v=2.4 cv=fIusTpae c=1 sm=1 tr=0 ts=6ad762cf cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=iK5QPMNa_E_FA8V_BHUA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-GUID: DeCVwZOkPgo-MSZ7reEp57OQQdV3ZRNL X-Proofpoint-ORIG-GUID: DeCVwZOkPgo-MSZ7reEp57OQQdV3ZRNL X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIwMDA1MCBTYWx0ZWRfX/dTXXfYszjLo PNt3b8LB+5Js8iPL8TPYnhNuMI2aqjy6hs29LHc0v+BVv0T2aXNfRXzlwOFd360VZuoivihjQgx uRmSTZuvbfUGA/kCMgjAsmQTQkljquA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-20_01,2026-10-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 spamscore=0 malwarescore=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610200050 As requested by Herbert: this is the aead part of the QCE fixes sent separately for easier review. Signed-off-by: Bartosz Golaszewski --- Changes in v12: - clear the ctx->need_fallback flag for key sizes other than AES-192 (sashiko) - Link to v11: https://patch.msgid.link/20261019-qce-fixes-aead-v11-0-11c55cc7a695@oss.qualcomm.com Changes in v11: - Split out the aead patches into a smaller series for easier review - add a patch fixing a race condition resulting from sharing ctx->eed_fallback by concurrent requests - Link to v10: https://patch.msgid.link/20261013-qce-fix-self-tests-v10-0-57162a38a554@oss.qualcomm.com Changes in v10: - don't pass a NULL buffer to sg_init_one() - fix byte order of the imported hash state on empty finalization - don't recompute the CTR counter in software for every request - reject skcipher requests with a too short scatterlist - check fragmentation for empty CCM decryption requests too - don't use a static loop iterator (duh...) - initialize the return value in qce_handle_queue() - Link to v9: https://patch.msgid.link/20260922-qce-fix-self-tests-v9-0-b1aa742e79af@oss.qualcomm.com Changes in v9: - Rebase on top of cryptodev/master - Rephrase Kconfig help text changes - Link to v8: https://patch.msgid.link/20260921-qce-fix-self-tests-v8-0-107537869a72@oss.qualcomm.com Changes in v8: - Add a patch making the crypto driver *not* register algos by default but only if the user explicitly requests it with the provided module parameter - Use the "offloader" name for the crypto IP instead of "accelerator" - Fix device module table issues - Make the core driver use a list (despite it only having a single member now) of child auxiliary devices to register to make it clear we have the intention of extending this once we start the work on secure media playback - Link to v7: https://patch.msgid.link/20260910-qce-fix-self-tests-v7-0-cdbd2718af14@oss.qualcomm.com Changes in v7: - Add follow-up changes converting the QCE crypto driver to auxiliary bus, adding the core QCE driver under drivers/soc/ registering the auxiliary device and removing the BROKEN Kconfig label - Link to v6: https://patch.msgid.link/20260717-qce-fix-self-tests-v6-0-455775fe5f6c@oss.qualcomm.com Changes in v6: - Handle all zero-length HMAC finalizations (like imported state with data already hashed), not only the genuinely empty message case - Add an additional patch addressing the fragmented skcipher payload issue - Link to v5: https://patch.msgid.link/20260706-qce-fix-self-tests-v5-0-86f461ff1829@oss.qualcomm.com Changes in v5: - Dropped patch 1/8 that's already queued - Use the pre-allocated fallback ahash for HMAC transforms (Herbert) - Link to v4: https://patch.msgid.link/20260622-qce-fix-self-tests-v4-0-4f82ffa716c6@oss.qualcomm.com Changes in v4: - Remove remaining ECB and DES3 bits - Pick up tags - Link to v3: https://patch.msgid.link/20260617-qce-fix-self-tests-v3-0-ecc2b4dedcfd@oss.qualcomm.com Changes in v3: - Remove even more algorithms and dead code in patch 1/8 - Link to v2: https://patch.msgid.link/20260615-qce-fix-self-tests-v2-0-dc911f1aad42@oss.qualcomm.com Changes in v2: - Add fixes for the full suite of crypto self-tests - Add Fixes and Cc tags - Link to v1: https://patch.msgid.link/20260610-qce_selftest_fix-v1-0-1b0504783a46@oss.qualcomm.com/ --- Bartosz Golaszewski (3): crypto: qce - Don't modify the TFM context for per-request fallback crypto: qce - Use a fallback for CCM with a partial final block crypto: qce - Use fallback for CCM with a fragmented payload drivers/crypto/qce/aead.c | 46 ++++++++++++++++++++++++++++++++++++---------- 1 file changed, 36 insertions(+), 10 deletions(-) --- base-commit: 0aac16003b01b9282491ea3d454697c2dc7e8c78 change-id: 20261019-qce-fixes-aead-e229fa2015e3 Best regards, -- Bartosz Golaszewski