From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792500438; b=RCulKaImN32d2f+2OAaqMUMXtH2Yn2Ldx7/g5dWOLQdhjd/HvYOgThYI8dTa5jWRuQSm gMgOPszszb4N0SWpPyoJdIuYYWDTvqpeURAOzk4RkYYM1t6+61d+oFF+uVD7EjKcJVcfO 6K+EYbfX8hlZKNxvUpJkWMWMvrtbnv2z5My2k0yFy1dS6qXfb6RSfSuGEM5BhXaqLrJ2X VIIt0OA/FAzKv8Hv3mgdz0nZBjsiSCxG+JskHUtvRwhGuoOgNhDL8WLm++m6IjL96ghCx Vb1sdMQT58vjPLT//JWRmF6+S4GCztP9h89ML8p9KjHJ5avFsGtDx4Tf4zWtlbMgrUQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792500438; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Spam-Info: X-Authority-Analysis:X-Proofpoint-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=huFKBQDlZuVavcX0HkWyC9IVz+ofFZPmUDE2CCpGGhw=; b=1Te0PEYOMCSfYLoU6K6iNMHnWYt0HTaUhW422+YwKAphk3mV6P5PlzhXXxSiJLYLKRi/ wMbisDmdBY+BFn9YypzB9NdTEvXVpBTFc1Nh+cRw0cABfHi4NcV6CaaWfBnC3cb5RLuCF wVSUSRroN6GYKqwZOKSeYieyH2LAOGtzLx9DojS7xdSWQN7glavpYzhxvA63y8py9vCQl 1/UGbQmZkfVYA55Ti78b/4c0eXz7pI1/KozjNlYMewP0qJRdGo/L1Qs+93j1SDRJAtcPD vFvF0L4rad1Ro4ewp2+kKvqrLxBQL9s0jxV/lX1Enc3YIWYKBQT8u3E/TeH6yaUmcmA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=M4rHAd6D; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=HLV5jyKx; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CE5460A2614 for ; Tue, 20 Oct 2026 12:47:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6CE5460A2614 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=M4rHAd6D; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=HLV5jyKx Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69KAx3dp2562795 for ; Tue, 20 Oct 2026 12:47:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= huFKBQDlZuVavcX0HkWyC9IVz+ofFZPmUDE2CCpGGhw=; b=M4rHAd6D1FJIOzeo ZlW02DqDIcBFHQK6ttTi+6nivdTF7yZq0PqRV0LJm2dZlqM4C5u34Ix2frU8xjwe 78t+MkIw2EfvFDGCKB6MBPrNjb53Fts94lMPa4+NX8KcNybfeXY91La5cIRo/3/U aCiylSbMA3wbLsQJOxHJVBzp7JOBGFq1zlgaVjs0AVy2wvPv2rSmRzrrfyW6/DOa lb/SBoqCszMAq+9orbVa1rQBgQP4Lj/1nyGsXiqc0TJ+pX0TaL7bLSSO+0QRetbn LMu2ivdRQv5ZZUERp9C8vrQNpKWu3KVFexTwoKSf88G7SJDU7too5zMDxr/EcUHw xT7bwg== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hdw5naftt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Oct 2026 12:47:17 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-917a7fffbe0so61880916d6.1 for ; Tue, 20 Oct 2026 05:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792500437; x=1793105237; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=huFKBQDlZuVavcX0HkWyC9IVz+ofFZPmUDE2CCpGGhw=; b=HLV5jyKxFGVxD1OAThqrzqe+0u+x5aWPYXjXPpjFoEBacG0vk+K50+PyvXLApAjkqC AAB6IsJTHGOqO1pFJMotND7h0/Bqy/A82Eog9I72KwYo9wCJSNcR6vApo8PfFQJWnXXU HQzheh4/XpoMy57e78tEABZvfkMJy97dZtGuUCo335enoe5NeLkUtS8iFqjgDoaypKby DGS0Y42XHZS7nY5Hmw20Hw1D+hGvIw4LntYTc/CSJNt+eK4NverIE9TNNTuWOwrG1yi3 woTAhM9l9eVvvV1f2ChtUn52CQBNZ+7+K4KUKXEuz/qZzFUTbODALqiDCFo0ATU114aA Nu4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792500437; x=1793105237; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=huFKBQDlZuVavcX0HkWyC9IVz+ofFZPmUDE2CCpGGhw=; b=PJUBwnpRrhH5twpzk1LdEG5+9XQFhsSBdgL+pDr+UKET/eryFUKN4c/iHcC0Bt1Sxn DLw7JjJGfw7pthf28VJjU6pAc/r/wQ8GeiROXL7BkkrnHudUVgdcZw8KgbbH72ZnQW/0 wMy0326swXsbg1ys4ppeAZ3FFCsRU7KXTNsEUeJkrz0is46g03arBMqHi29Kncm9UBOj 0ow3XLZHdBaX3bKDRIRhRlRVLS8wd1f2j+GtKUL7r6YN48355miZFBpTJM2hbIAQOCtK rvDopkuiLsT/OTiYBFDPM4eN29OvQQwhS/WOuV4qr5qnoyixKM98vOts8oBOv+m+PZ8w wykA== X-Forwarded-Encrypted: i=1; AKwUvByAH92hzmknHa/0HJBFYjkoUjMNnwhK/76P2hu4hitwvvqd+YVwcvdb5MYfoZ6w0cWIzUI2zoDfGSGtYlE=@vger.kernel.org X-Gm-Message-State: AFq9FYL8WY9kn/WMRsBb+XnHajeBgM4cdG1V5AdIVFA2mbnE96Jjhm7r fiR72CxG2fC/eT4fugMnTOtm/Pu2xOdlNB5U9UfYwJxG9eLox+C4OmqiLuWy6L0h/wuJP48L/vC 4meoLhTJ0r7x2y8m44BQuev/KjLxtHdDqSJwcjKbPvrkakWDnmOjgbuuKpog8QxUVYwk= X-Gm-Gg: AYBFou0xBxH3ydtOUvaD9TI5dgY3Qd2Gulhs+sHEG67gwqOYKilrawzyYWpyNNaiPez 4bC56gS8i2gmpqqlUaQyV4O+A7BHtgclCXpW5IKzpMUkhtcd59oFJgSJoXsJzl5m5kL+ec9BoYS ZKsSq9S7KIbuG/ebx2aOQNMr79uKRubl85rgYDmP5d2BsIHIux0qU1X+bhVIHpUJbQrfol7RD// 8J5YBH5faEZED/It0BYfwe1ZuMhOAAx65UVCM1LqZ+xwd9uQvurulSwvRWAuPFqo40/x+3tsTGU ybT1V/3oqXErEuaeeXFtAfXImTXnAykfP0XOcynTVBsP7vodf1gbr9wNDsk2ZyDOw9ihWrHwcSS LvNd/EoNKb/eeRLLz1Nfv863H3XUz X-Received: by 2002:a05:620a:288b:b0:93b:d7a0:d9e5 with SMTP id af79cd13be357-93f29dc760bmr1784979085a.63.1792500436730; Tue, 20 Oct 2026 05:47:16 -0700 (PDT) X-Received: by 2002:a05:620a:288b:b0:93b:d7a0:d9e5 with SMTP id af79cd13be357-93f29dc760bmr1784974985a.63.1792500436235; Tue, 20 Oct 2026 05:47:16 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:8916:7b9b:97a2:6c96]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e1d82456asm6544253f8f.42.2026.10.20.05.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 05:47:13 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 20 Oct 2026 14:47:02 +0200 Subject: [PATCH v12 2/3] crypto: qce - Use a fallback for CCM with a partial final block X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261020-qce-fixes-aead-v12-2-77a2e09abd0c@oss.qualcomm.com> References: <20261020-qce-fixes-aead-v12-0-77a2e09abd0c@oss.qualcomm.com> In-Reply-To: <20261020-qce-fixes-aead-v12-0-77a2e09abd0c@oss.qualcomm.com> To: Bartosz Golaszewski , Herbert Xu , "David S. Miller" , Eneas U de Queiroz , Kuldeep Singh , Eric Biggers , Demi Marie Obenour , Bjorn Andersson , Konrad Dybcio , Russell King , Abel Vesa Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org, Pankaj Patil X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1628; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=GqhpiPEpEa1I70oxqqZo3K9AEP6IrLH9DMi8DVCLwIs=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBq12LLD9DtGJXaTr9T04Ert0KoYT+bbygA4vMVf PJyAMr6eI+JAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCatdiywAKCRAFnS7L/zaE w44hD/9clJ7ieqwrkF3q+9179egCOT3Rx0KvE4ovz+1T6uYEAT91Veqf2tZapFUdq8H+NqE5s0H OMHt1J5Lpd+vGnJaReYbYagXOBYNUST9ZXu5W9e4r+wptn0kDUWb7e9hp30K5xZ4O33ixIADjgU KoAOtZo0I5pJQ1CTXX2gSAOya8sf1/DMwRtFVNNIwXFi2ii69RJaXyq+iea08vFaFSAwIruZxyL B02PwJYSBfSithkOgsx2DcAmabxbfI5ZSEg6i04FtdlRpbK6VgekszSoAtXFrQLpMhBzjKsVjx8 do2UNTz6vUcXLYmBQzN9gt4NXljvmAEElt/vWycQxpg4nNmMZqFdLeI4NqS3kvQf4MOJD9r9/vq V1SPA/CrSXWo4UqvOf0funuk14tBCTyPp8CvC/q3cEye/PqtyzNIOGsXkG8PmS4kDQcttuP+nK2 L/un1xjZRxcDlcIxxXaevMqgIXUAVxP+cpYPil0HeHbiy6+uH3iVovuyVXMCmubczEL3nfh/+H3 dzHhs2P39OgEHgm/UQ5De2zBP3/t9oIbbYG5IvAT9L6uLZEfpONWsJLHDNxUR9yUA6/tm3YTNsY FPFxr73LIOXY36roVVhOPsFYpV2QXwjba8P+D47SZEMPmKQ9rylbNRC2xrqj41NpsdWBL6SI6rl bBq2xfNNIfAoh4Q== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-ORIG-GUID: r4jTKG5NHvhyfX5NnKCVKyR4cTHje-bJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIwMDA1MCBTYWx0ZWRfX5DFbp93KJ8uF 6tBhSu8ylipHndJMOeh3L7xmNY5imXv1W9EuiqChmmZaOGu1hE9U8JMOyFOSdmTpj82Mlps+Pko vkYqTqetF6cv5FDI2Wjx2+diQxs2WH1gGVvBaYYzNZAz5gBTqV7q3mwsgQqYekgbxdNygdDEkCu iTXGLavxXxj12X9gU01lsJWeRhaBqQ1yIPsoqHKQ/zYwV09dYIPg7Yhz3U7NosADF51WM3u4CB5 OscIUpUGjWrO+oYvHH3u42K1hdOxccxg+0yIOoe3d18lt7plEAChRh7hya3zWzh7Zt19nWXTXlJ 5tev84/w80/G2yq84kMsKQa+BgtSXBsATuXCtP1Nk9OrUihIMrauTCRdUTw4JT6+AmB0tx5YkmX toS/lGX/5vS3hJ4atSB+M0d36JSFed5sYoK0JjhD1RAzPwxgUhGXHeosSZ9QMMFefOHAFouUpHh m+hddR+Nylndz/8ELFw== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIwMDA1MCBTYWx0ZWRfXycgwIPJzwx5Y sk3PaBP1pn0i54c28AjuNw7zC3e0O2DnNfsY1oCvVXl6gu8Svhj+Vu5IQE6A6VfDBFsK4YVxQhW l/Gw+hAb9vMqs7Mke6xSnWaInfp4XIw= X-Authority-Analysis: v=2.4 cv=VI9IDNPX c=1 sm=1 tr=0 ts=6ad762d5 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=dx2SfONCXZg6tt9xEGkA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: r4jTKG5NHvhyfX5NnKCVKyR4cTHje-bJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-20_01,2026-10-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610200050 CCM builds on AES-CTR for encryption, and the crypto engine stalls on a partial final block just as it does for plain ctr(aes): a payload whose length is not a multiple of the AES block size leaves the operation incomplete and fails with a hardware operation error. This was caught by the ccm(aes) crypto self-tests. Force the software fallback for CCM requests whose message length is not block aligned, reusing the driver's existing need_fallback mechanism. Cc: stable@vger.kernel.org Fixes: 9363efb4181c ("crypto: qce - Add support for AEAD algorithms") Tested-by: Kuldeep Singh Tested-by: Pankaj Patil Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/aead.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/crypto/qce/aead.c b/drivers/crypto/qce/aead.c index b7873852249dffeb91d09df3bae6534f77c08b7e..19d7e92aaeda0df1072114fa0435dc40e1eb6849 100644 --- a/drivers/crypto/qce/aead.c +++ b/drivers/crypto/qce/aead.c @@ -515,6 +515,14 @@ static int qce_aead_crypt(struct aead_request *req, int encrypt) fallback = true; } + /* + * CCM uses AES-CTR internally and the CE stalls on a partial final + * block, so a payload that is not a multiple of the block size has to + * be handled by the fallback. + */ + if (IS_CCM(rctx->flags) && !IS_ALIGNED(rctx->cryptlen, AES_BLOCK_SIZE)) + fallback = true; + /* If fallback is needed, schedule and exit */ if (fallback) { aead_request_set_tfm(&rctx->fallback_req, ctx->fallback); -- 2.47.3