From: Yuanhe Shu <xiangzao@linux.alibaba.com>
To: ying.huang@linux.alibaba.com, kaitao.cheng@linux.dev
Cc: david@kernel.org, akpm@linux-foundation.org, vbabka@kernel.org,
linmiaohe@huawei.com, nao.horiguchi@gmail.com, ziy@nvidia.com,
wangkefeng.wang@huawei.com, tujinjiang@huawei.com,
mgorman@techsingularity.net, chengkaitao@kylinos.cn,
muchun.song@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, xiangzao@linux.alibaba.com
Subject: Re: [PATCH 1/2] mm/compaction: skip folios containing hwpoisoned pages
Date: Tue, 20 Oct 2026 15:16:00 +0800 [thread overview]
Message-ID: <20261020071600.3695395-1-xiangzao@linux.alibaba.com> (raw)
In-Reply-To: <877bjowf9i.fsf@DESKTOP-5N7EMDA>
On 10/11/26 21:14, Huang, Ying wrote:
> Is it good to implement the trick in copy_mc_user_highpage() and
> copy_mc_highpage() if the macro copy_mc_to_kernel is undefined?
Sounds good. That also covers the non-migration callers of the
fallbacks (COW, khugepaged, KSM), and composes with a real copy_mc
implementation for actual MCEs. I'll prepare it as a separate patch
with your Suggested-by, referenced from the v2 cover letter.
On 10/10/26 16:35, Kaitao Cheng wrote:
> Could we recheck PG_hwpoison on the source page after folio_mc_copy()
> completes, but before the mapping is transferred, and abort migration
> if the flag is set? This would prevent PG_hwpoison from being lost
> after migration.
Patch 2 already rechecks before the copy - your v2 check, moved a few
lines earlier. What it doesn't cover is the copy window itself: the
debugfs corrupt-pfn injector has no GUP ordering and can set the flag
mid-copy. Happy to carry the post-copy recheck in v2 as well.
--
Yuanhe
next prev parent reply other threads:[~2026-10-20 7:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 10:58 [PATCH 0/2] mm: don't migrate " Yuanhe Shu
2026-09-28 10:58 ` [PATCH 1/2] mm/compaction: skip " Yuanhe Shu
2026-09-28 12:12 ` David Hildenbrand (Arm)
2026-09-29 3:41 ` Yuanhe Shu
2026-10-11 13:14 ` Huang, Ying
2026-10-20 7:16 ` Yuanhe Shu [this message]
2026-10-20 7:52 ` David Hildenbrand (Arm)
2026-10-10 8:35 ` Kaitao Cheng
2026-09-28 10:58 ` [PATCH 2/2] mm/migrate: refuse to migrate " Yuanhe Shu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020071600.3695395-1-xiangzao@linux.alibaba.com \
--to=xiangzao@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=chengkaitao@kylinos.cn \
--cc=david@kernel.org \
--cc=kaitao.cheng@linux.dev \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=tujinjiang@huawei.com \
--cc=vbabka@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®