From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>
Cc: Emil Tsalapatis <emil@etsalapatis.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] sched_ext: Remove the foreign CPU check from the kick_sync wait
Date: Tue, 20 Oct 2026 10:43:21 +0200 [thread overview]
Message-ID: <20261020084400.845842-4-arighi@nvidia.com> (raw)
In-Reply-To: <20261020084400.845842-1-arighi@nvidia.com>
The kick_sync balance callback is now queued from set_next_task_scx()
after the core-wide selection has finished. Proxy resolution zaps the
callbacks before dropping the rq lock, so a foreign CPU cannot acquire
the lock and flush this callback while it is queued.
Remove the unreachable foreign CPU check and its obsolete comment.
Suggested-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/08cac02c604dd73ef96fc92eb29d692b@kernel.org
Signed-off-by: Andrea Righi <arighi@nvidia.com>
---
kernel/sched/ext/ext.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/kernel/sched/ext/ext.c b/kernel/sched/ext/ext.c
index 4b7d2602b4d40..a9b26fa431bf3 100644
--- a/kernel/sched/ext/ext.c
+++ b/kernel/sched/ext/ext.c
@@ -3733,15 +3733,6 @@ static void kick_sync_wait_bal_cb(struct rq *rq)
bool waited;
s32 cpu;
- /*
- * This callback is queued once the pick is final and flushed within
- * @rq's own scheduling pass. If a lock taker on a foreign CPU ever
- * flushes it, the snapshots are unrelated to that CPU. Don't get in the
- * way and leave the wait pending for @rq's next pick.
- */
- if (unlikely(cpu_of(rq) != smp_processor_id()))
- return;
-
/*
* Clear only when the wait actually runs. The callback can be dropped
* without running (e.g., proxy exec zaps the balance callbacks and
--
2.56.0
prev parent reply other threads:[~2026-10-20 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 8:43 [PATCHSET sched_ext/for-7.4-fixes] sched_ext: Fix proxy execution balance callbacks Andrea Righi
2026-10-20 8:43 ` [PATCH 1/3] sched/core: Avoid requeueing a singleton balance callback Andrea Righi
2026-10-20 8:43 ` [PATCH 2/3] sched_ext: Use irq_work for deferred actions with proxy execution Andrea Righi
2026-10-20 8:43 ` Andrea Righi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020084400.845842-4-arighi@nvidia.com \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=emil@etsalapatis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®