From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792516661; b=FsfiO0VicbtVBYBPqWHgh91JFZyEM/VpfENBc88uHErBhxR8xoOkOAFONRz+U5zEKdLI J7fJP6A6kgVeJ+TcgAOpiHxnjrUI4pe/Xw+r6Q0aah1RJBvRDtxDXHEckG4L7ouhkqWNN FBnNBpu7Ojar0z3pHqNYjdMRoUK6IX2wYeBK5fcqRu7lmJzoGOH3ixR6SaZXyO32u5BMJ SI22EaIfxem8Kw3VVJszvgAkDvv40xEP2Vdh4RZ8LwlgqrYUxdi8qXhqQLaGcaruu9qPU 8ui0vSWj0jUeEvc5ZQpbHDSgVKK8j3i/cMbASGSAjw2uZX5+AHLhmyEIFut67MyXF9Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792516661; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Gm-Message-State:X-Gm-Gg: X-Received:X-Received:Received:Date:From:To:Cc:Subject:Message-ID: In-Reply-To:References:Organization:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Authority-Analysis: X-Proofpoint-ORIG-GUID:X-Proofpoint-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Spam-Info: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=8QpGW0NKviFKo87+h3Yw2MqyJCFWY8ItSyPAh+yd9CU=; b=xFUTU1VrZc51WAN2P7ja9EfP575meN/W38DeQ7sYJYKmIuIycWM3bBYmr5y9DNIFvp9V 3przaVvOW9y2WJhu+/kolKAxtpqXwce39C7bKZUGCAlDdga/OstoaQGloagqkQBm0CAqr WArQBGRzBvLCOPhJ0Caww8oattaeFviYfRxqWHLfpS6Vs5BrPXkYw0JoStXOogeNL12TP nP+qDoukC9SQ4AbL0DvaqB1wT2nSpFlPdw4nY1EGc5Pj5GHfDEF6W5P7eI9tCs8uFR0uY kgm/jfFX8Zrdc4L2JjrawgXt2YkL1tRS1IN3KysBpqpMZLle6wBMSUo/PfuQeAIwJ5w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=o38bSjL8; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=dGIUKunL; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D25AA606AA18 for ; Tue, 20 Oct 2026 17:17:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D25AA606AA18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=o38bSjL8; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=dGIUKunL Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69KGu2NG2797258 for ; Tue, 20 Oct 2026 17:17:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8QpGW0NKviFKo87+h3Yw2MqyJCFWY8ItSyPAh+yd9CU=; b=o38bSjL8gGuVcSTR 84CM4Pq1EbcbZXg06gl55UxMOt3BBBFXAaXlhz0Nc/GShV6IEjkXFGHydvYGngD2 VWDoa1cxKjLCUINW6x8og6Dtz14ENY1wHuXJZjFmXtCs7UHDtkyuYfUOZctxHUMG RU7zRXlVTOEjoJXk1XJZTpa7bD+Dxx/ObdjSI1IHfj6nZO/ALnZPQKUz/AB84XqC 6+lm/dnxdyJClEsJ0v6Kj75y8szAaCKkgPjuu3eS1oHzKvAuYzHxbkueXhY9l8DV LWibtU0pGo0GN0B+p5+rf0WBZMCTpZeHcXMQCFoftLI47o+VrrEDr64el1XjtOu+ 1D4cOQ== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hdw5pknc1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Oct 2026 17:17:39 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-35d4538fd74so11282856eec.1 for ; Tue, 20 Oct 2026 10:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792516658; x=1793121458; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=8QpGW0NKviFKo87+h3Yw2MqyJCFWY8ItSyPAh+yd9CU=; b=dGIUKunLEiYUBe12BPU5wrem2NjGvnOwfjDQMQLNi9YpoMqv92pQYBmOAtzJ7wvMOs lK8yDTx/EOwUgIOk+8aRrggNmOIHPkKe3RorYbY8rBkIT4hXu/aVNQ1WnsrSAYDQW0iJ gCAVkTQbIz5rN+W/cIxUXKridyg9wWQjUlW82J+QusxXsOoqvOvllDXvMccpfPyGuhsv GtpGdM0t5EeAb12C8qmeKPVL9RIv6n0JRVbWPP+R1a1hUVYtgb9NGERYxWZ89n52Birb VQx5pFkA0c2dXxZ0Z4FQWp36zC2YCraNp7OvGWz8qXKovmWJFuaqRbaK4wvhTuFIEFlo OX5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792516658; x=1793121458; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8QpGW0NKviFKo87+h3Yw2MqyJCFWY8ItSyPAh+yd9CU=; b=dI/UyN5/ybnKesKdxAqi2HL93LnA0Z7vx0iMfYm/3oNpbzIDpj9i7iW78Pfsw0KcZ4 aH1rPP3mOSLyM0gKW4X23b1lHmQcujfErLy3FFLj/7O+4R703zpxrk71tWWnki+5ftk4 55QobF0nEzggZTaOXUotdw32GuYkLboceKeChg8NrH1ee6RcYfRaWxIl95k+sR2rfSUj iXOy7L/tZLGgV8yybl08RTwsdJrtiMcE1RNPpRriHrfFTNMujNZcWFl8E3E8oX8OzGxK KICZ+d7wNk5McLtYK9DUg+b/GfO7Yu3bJvangoowuhab0UNF5v/3+4DPPxS1uLihJL0r 820A== X-Gm-Message-State: AFq9FYIydhXqrvDdPgHvNz1z2Fb2eQqQLeIFIuiq/iZDrBoAiJA84WjF tIDGhsDZhl5YeRGOeif/z3U+jE/w7ynGjOqkK++n5N3PbCZY8MbejrF2ZhghOfUjj1D+wXLhyp/ DYxeRvx9Mv8yhJH6jQubjXERhBtCXn9hXs1HH9IzJUFHoAxss4iqoOCQd7yKBnVda+j4= X-Gm-Gg: AYBFou2cT4RMMPmAyM4vKtT4WfgEfjSEKVWG0zyClRZFas6g1d1v/uraqBNGrsgaFOd t1vk6Ky2Q4pRqeX8e5G2m+se+IEsGDP1ATeGCYA3PKYY24xBEgy6/USCZ7xvEOLARimB4E5NEYr PCUneyqFVzIGA3QUqFNYJ2vBzCqCTTGouuEV/l644Qx0FDzANwwBf7Yd6+tj3RdId1u6mizJHP8 yQnqxVDo1knelmp0Tbg/I+LXFC8Xcr91RioPB1li51TgIv/K1ZTn6u4J3HL2enLXbc8bmlqjZOA TLW5mRGDi/Cjy5/bwge7st7fgKU/Y4l54CpQVEETfw+LIzR7HOfBMjf6PETjIDIxGwXIAfgTxDA L5IYErS4YHMmDjGO3f3FgH+SgsUF05saQJ63+ngiQxg== X-Received: by 2002:a05:7023:a47:10b0:15a:9834:73c9 with SMTP id a92af1059eb24-1851453f752mr15327638c88.40.1792516658218; Tue, 20 Oct 2026 10:17:38 -0700 (PDT) X-Received: by 2002:a05:7023:a47:10b0:15a:9834:73c9 with SMTP id a92af1059eb24-1851453f752mr15327601c88.40.1792516657378; Tue, 20 Oct 2026 10:17:37 -0700 (PDT) Received: from localhost (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1903bb7f098sm5472c88.12.2026.10.20.10.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 10:17:36 -0700 (PDT) Date: Tue, 20 Oct 2026 10:17:20 -0700 From: Jonathan Cameron To: Pierre Gondois Cc: linux-kernel@vger.kernel.org, James Morse , Mark Brown , "Rafael J. Wysocki" , Len Brown , Tony Luck , Borislav Petkov , Hanjun Guo , Mauro Carvalho Chehab , Shuai Xue , Maciej Wieczor-Retman , Pawel Chmielewski , Dave Jiang , "Fabio M. De Francesco" , Breno Leitao , Terry Bowman , Dan Williams , Ard Biesheuvel , Morduan Zang , linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, acpica-devel@lists.linux.dev Subject: Re: [PATCH v2 5/6] ACPI: APEI: add separate Memory Error Section 2 handlers Message-ID: <20261020101720.00002545@oss.qualcomm.com> In-Reply-To: <20261019203915.2019037-6-pierre.gondois@arm.com> References: <20261019203915.2019037-1-pierre.gondois@arm.com> <20261019203915.2019037-6-pierre.gondois@arm.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=a7WlZkSF c=1 sm=1 tr=0 ts=6ad7a233 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=Rvnai5sDmRKbKYGs1KsA:9 a=CjuIK1q_8ugA:10 a=PxkB5W3o20Ba91AHUih5:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-ORIG-GUID: mZx39_w2a340FCJKyDZQSnLkGDyMs9H_ X-Proofpoint-GUID: mZx39_w2a340FCJKyDZQSnLkGDyMs9H_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIwMDA2OCBTYWx0ZWRfX1oWGHeoGsoaU TKBK0p1e2ji9W3rfjew8qWt8u/leK5fezDVg1WPFbyop9YOd4Jhs9v14c4neHO8Ys7D5/6xN21Q g2XlyNtUhm+mtIvUoBmGYZoKHa6yj05Du3+7LJyQzbMh5bnR97tpRyeaciEXDt6w30CUGKwcP4U b9Gzzbhhf+lUuU7sD0zIdeFQ/BUoDTu14ztPlf5l+2JAYVRmsd0tXVkaFF4BdwWFXC65mOupFJ0 vKzz8uPiZKlZrRsbeUeRuxG0kw5kKUPqp364qAruI//gKTPwMqPmxve9L5anbTaaro8UFE78Vql nvxhQ1+9ZaLoSKPT6l5IRuNOXR6BJ3EVNTUPBkEymSi0vJC4g7XMLmhiHoVn2hdWOEgUJCnG3nR rs4L0J3ya8WvfoR5URZRWWYaoi9PL2SmBavdIZfw/Ny5jV3EFTYh2rH7Dw9o3YwCLB3146Vsx3f XVNetLt4hPLUq+8Pp/Q== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIwMDA2OCBTYWx0ZWRfXzTkpGk0+TV8s CCKnMtO/zjAOPTCxaMgkHgR6MyDZuDsnff12ypZNT2PAeG/FDAjkwH3r/Dg99j7a1m4pVdni6wf n3rJocv3CB97CuDppfJo7A3ioWZ7gsI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-20_03,2026-10-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610200068 On Mon, 19 Oct 2026 22:38:44 +0200 Pierre Gondois wrote: > Add dedicated GHES and EDAC callbacks for Memory Error Section 2 > records. Use a separate GHES notifier chain so existing consumers > continue to receive legacy memory error sections. > > Signed-off-by: Pierre Gondois I think this is is ok. I don't love the dual notifier chains but right now I also don't have a better idea. So a somewhat tentative Reviewed-by: Jonathan Cameron Jonathan > --- > drivers/acpi/apei/ghes.c | 49 +++++++++++++++- > drivers/edac/ghes_edac.c | 118 +++++++++++++++++++++++++++++++++++++++ > include/acpi/ghes.h | 2 + > 3 files changed, 168 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index fe10ab0e02f6..c7fb15543b56 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -101,6 +101,7 @@ > #endif > > static ATOMIC_NOTIFIER_HEAD(ghes_report_chain); > +static ATOMIC_NOTIFIER_HEAD(ghes_report_mem2_chain); > > static inline bool is_hest_type_generic_v2(struct ghes *ghes) > { > @@ -551,6 +552,29 @@ static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, > return false; > } > > +static bool ghes_handle_memory_failure2(struct acpi_hest_generic_data *gdata, > + int sev, bool sync) > +{ > + int flags = -1; > + int sec_sev = ghes_severity(gdata->error_severity); > + struct cper_sec_mem_err2 *mem_err = acpi_hest_get_payload(gdata); > + > + if (!(mem_err->validation_bits & CPER_MEM2_VALID_PA)) > + return false; > + > + /* iff following two events can be handled properly by now */ > + if (sec_sev == GHES_SEV_CORRECTED && > + (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED)) > + flags = MF_SOFT_OFFLINE; > + if (sev == GHES_SEV_RECOVERABLE && sec_sev == GHES_SEV_RECOVERABLE) > + flags = sync ? MF_ACTION_REQUIRED : 0; > + > + if (flags != -1) > + return ghes_do_memory_failure(mem_err->physical_addr, flags); > + > + return false; > +} > + > static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, > int sev, bool sync) > { > @@ -915,7 +939,8 @@ static void ghes_log_hwerr(int sev, guid_t *sec_type) > return; > } > > - if (guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) { > + if (guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM) || > + guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM2)) { > hwerr_log_error_type(HWERR_RECOV_MEMORY); > return; > } > @@ -952,6 +977,16 @@ static void ghes_do_proc(struct ghes *ghes, > > arch_apei_report_mem_error(sev, mem_err); > queued = ghes_handle_memory_failure(gdata, sev, sync); > + } else if (guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM2)) { > + struct cper_sec_mem_err2 *mem_err = acpi_hest_get_payload(gdata); > + > + if (gdata->error_data_length < sizeof(*mem_err)) { > + pr_warn(FW_WARN "Memory Error Section 2 length is too small\n"); > + continue; > + } > + > + atomic_notifier_call_chain(&ghes_report_mem2_chain, sev, mem_err); > + queued = ghes_handle_memory_failure2(gdata, sev, sync); > } else if (guid_equal(sec_type, &CPER_SEC_PCIE)) { > ghes_handle_aer(gdata); > } else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) { > @@ -1973,3 +2008,15 @@ void ghes_unregister_report_chain(struct notifier_block *nb) > atomic_notifier_chain_unregister(&ghes_report_chain, nb); > } > EXPORT_SYMBOL_GPL(ghes_unregister_report_chain); > + > +void ghes_register_report_mem2_chain(struct notifier_block *nb) > +{ > + atomic_notifier_chain_register(&ghes_report_mem2_chain, nb); > +} > +EXPORT_SYMBOL_GPL(ghes_register_report_mem2_chain); > + > +void ghes_unregister_report_mem2_chain(struct notifier_block *nb) > +{ > + atomic_notifier_chain_unregister(&ghes_report_mem2_chain, nb); > +} > +EXPORT_SYMBOL_GPL(ghes_unregister_report_mem2_chain); > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c > index b90150c67f4b..01defc4e3bf1 100644 > --- a/drivers/edac/ghes_edac.c > +++ b/drivers/edac/ghes_edac.c > @@ -390,6 +390,122 @@ static struct notifier_block ghes_edac_mem_err_nb = { > .priority = 0, > }; > > +static int print_mem_error2_other_detail(const struct cper_sec_mem_err2 *mem, char *msg, > + const char *location, unsigned int len) > +{ > + u32 n; > + > + if (!msg) > + return 0; > + > + n = 0; > + len -= 1; > + > + n += scnprintf(msg + n, len - n, "APEI location: %s ", location); > + > + if (mem->validation_bits & CPER_MEM2_VALID_ERROR_STATUS) { > + n += scnprintf(msg + n, len - n, "status(0x%016llx): ", mem->error_status); > + n += scnprintf(msg + n, len - n, "%s ", > + cper_mem_err_status_str(mem->error_status)); > + } > + if (mem->validation_bits & CPER_MEM2_VALID_STATUS) > + n += scnprintf(msg + n, len - n, "section_status:0x%02x ", > + mem->status); > + > + msg[n] = '\0'; > + > + return n; > +} > + > +static int ghes_edac_report_mem_error2(struct notifier_block *nb, > + unsigned long val, void *data) > +{ > + struct cper_sec_mem_err2 *mem_err = data; > + struct edac_raw_error_desc *e; > + struct mem_ctl_info *mci; > + struct ghes_pvt *pvt; > + char *p; > + > + /* > + * We can do the locking below because GHES defers error processing > + * from NMI to IRQ context. Whenever that changes, we'd at least > + * know. > + */ > + if (WARN_ON_ONCE(in_nmi())) > + return NOTIFY_OK; > + > + guard(spinlock_irqsave)(&ghes_lock); > + > + pvt = ghes_pvt; > + if (!pvt) > + return NOTIFY_OK; > + > + mci = pvt->mci; > + e = ghes_edac_init_error(pvt, val); > + > + edac_dbg(1, "error validation_bits: 0x%08llx\n", > + (long long)mem_err->validation_bits); > + > + /* Error type, mapped on e->msg */ > + if (mem_err->validation_bits & CPER_MEM2_VALID_ERROR_TYPE) { > + u8 etype = mem_err->error_type; > + > + p = pvt->msg; > + p += snprintf(p, sizeof(pvt->msg), "%s", cper_mem_err_type_str(etype)); > + } else { > + strscpy(pvt->msg, "unknown error"); > + } > + > + /* Error address */ > + if (mem_err->validation_bits & CPER_MEM2_VALID_PA) { > + e->page_frame_number = PHYS_PFN(mem_err->physical_addr); > + e->offset_in_page = offset_in_page(mem_err->physical_addr); > + } > + > + /* Error grain */ > + if (mem_err->validation_bits & CPER_MEM2_VALID_PA_MASK) > + e->grain = ~mem_err->physical_addr_mask + 1; > + > + /* Memory error location, mapped on e->location */ > + p = e->location; > + p += cper_mem_err2_location(mem_err, p); > + > + if (mem_err->validation_bits & CPER_MEM2_VALID_MODULE_HANDLE) { > + struct dimm_info *dimm = NULL; > + > + p += cper_dimm_err2_location(mem_err, p); > + if (mem_err->mem_dev_handle <= U16_MAX) > + dimm = find_dimm_by_handle(mci, mem_err->mem_dev_handle); > + else > + pr_warn(FW_WARN "Memory Error Section 2 module handle 0x%x exceeds SMBIOS range\n", > + mem_err->mem_dev_handle); > + if (dimm) { > + e->top_layer = dimm->idx; > + strscpy(e->label, dimm->label); > + } > + } > + if (p > e->location) > + *(p - 1) = '\0'; > + > + if (!*e->label) > + strscpy(e->label, "unknown memory"); > + > + /* All other fields are mapped on e->other_detail */ > + p = pvt->other_detail; > + p += print_mem_error2_other_detail(mem_err, p, e->location, OTHER_DETAIL_LEN); > + if (p > pvt->other_detail) > + *(p - 1) = '\0'; > + > + edac_raw_mc_handle_error(e); > + > + return NOTIFY_OK; > +}