From: Piotr Kubik <piotr@kubik.pl>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Tamizh Chelvam Raja <tamizh.raja@oss.qualcomm.com>,
Muna Sinada <muna.sinada@oss.qualcomm.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Piotr Kubik <piotr@kubik.pl>
Subject: [PATCH wireless 0/2] wifi: mac80211: fix link changes of 4-address MLD stations
Date: Tue, 20 Oct 2026 14:44:44 +0200 [thread overview]
Message-ID: <20261020124446.188739-1-piotr@kubik.pl> (raw)
A 4-address (WDS) station of an AP MLD sits on an AP_VLAN interface.
Two faults appear when the links of such a station change, for
example when the station reassociates or removes a link with ML
reconfiguration:
- drv_change_sta_links() checks the AP_VLAN, which is never in the
driver, so every link add fails with -EIO and a link removal stays
in the driver.
- ieee80211_set_sta_4addr() adds the AP_VLAN links before it sets
their addresses, so a link that the station gains later gets the
zero address, and a second such link fails with -EALREADY. The
station then stays on the AP interface.
Both come with 469d5d5a3b7a ("wifi: mac80211: synchronize valid links
for WDS AP_VLAN interfaces"). Tested with mt7996e on a 2-link AP MLD
(5 GHz + 6 GHz) and a 4-address non-AP MLD: after repeated
reassociation and after a link removal, the station stays on its
AP_VLAN with all of its links.
Piotr Kubik (2):
wifi: mac80211: change the links of an AP_VLAN station through its AP
wifi: mac80211: set the link addresses of a 4-address AP_VLAN before its links
net/mac80211/cfg.c | 17 ++++++++++-------
net/mac80211/driver-ops.c | 1 +
2 files changed, 11 insertions(+), 7 deletions(-)
next reply other threads:[~2026-10-20 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 12:44 Piotr Kubik [this message]
2026-10-20 12:44 ` [PATCH wireless 1/2] wifi: mac80211: change the links of an AP_VLAN station through its AP Piotr Kubik
2026-10-20 12:44 ` [PATCH wireless 2/2] wifi: mac80211: set the link addresses of a 4-address AP_VLAN before its links Piotr Kubik
2026-10-21 4:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020124446.188739-1-piotr@kubik.pl \
--to=piotr@kubik.pl \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=muna.sinada@oss.qualcomm.com \
--cc=tamizh.raja@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®