From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.134 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792510169; b=5p92o1mCoLpuvNee9NlT2HbNgLLkKpyN7czN2zDDmT44zIcyW0B3D3lIdFlAKU5hxJMk r7fyP1x+02vKX5A9mADQidXXOw/c7B3/KTKKOnKajUFVIHYXEfj6uYs+nDvdGYFf/Ddtj TpY7Yrq92dcFKLTDIlxSB2CZ/9TxX/trzqNJtCdJ7Qk8NuHEBsmT8+gq3ohrB8tT5G9i0 5bEByQI/zdVgH2+Mt1eF63S4wNx0gCTyvpSriBl87D2IbFbZVgPhzv20d1VpHaha26iUe H8PwjhQh2dyYaewe3RY+NGIu6+f2e1GjUQNn7OwRCr+eay+VIzM7jOKLOQ85P3TZKhg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792510169; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=9GDFV35RrSVf5yP47jS+7rs1H7n+XBgiZq3zykV+XtQ=; b=Vwxlq638ebFFlQYCZIvDL7dUt68UbJxlfni3Q04d7PTHI6lLVgMbTHgmenmLU5BK5p5T V0ujqWWk+rhMdXtR4+0/GDMHVpYLjtr5Q4khwJTogbrF/JW6fpfU6AGTMWid3++ogXx75 gILiwVdYsdkcPatjOPGFM5dBTDoKBMWa2qK59dMHL0ttCNe6n6+iMz8x/nfX2LB4EgJGr D7aO2E+ubb3BVFtDhqOhmCu86hie1HOLtoZLlrjAmSrQ/R7aQR/FXOCeXAkQvHdSQXgB1 GcLdnYYilfSs6CyxGymXTYrkKmZYPjZY66e9vdYF1Y2yW8RRYd4tyK0SEl/Meq8plJQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b="n/xDhLui"; arc=none smtp.remote-ip=91.218.175.134 Received: from mta0.migadu.com (out-134.mta0.migadu.com [91.218.175.134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF739606A31A for ; Tue, 20 Oct 2026 15:29:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DF739606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=n/xDhLui X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=qDoOdKi6oKQdzWjw9ttiqe9bR4kfbpGeSoHF507AHt0=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792510167; v=1; x=1793114967; b=n/xDhLui/B6iYXMShd5zI/knbMIldewi4erzJF60TWChYVvJpknTaz4HGbgpGLkp0A/xRbx4 EW5iAvpS96paL562RyUJM91bhiYUP5xc/YiqDDEfWfG+cxLjlCb0iu/dMRz7lSPbVTZGpOFa+Z4 lnwyVE+7mQEWlzCco1UgoqWo= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 4a298b9aecc1ef70; Tue, 20 Oct 2026 15:29:26 +0000 X-Mizu-Trace-ID: 4a298b9aecc1ef70 X-Migadu-Flow: FLOW_OUT From: Leon Hwang To: bpf@vger.kernel.org Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Shuah Khan , Kuniyuki Iwashima , Hangbin Liu , Martin Karsten , Masashi Honma , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Leon Hwang Subject: [PATCH bpf-next v3 6/6] selftests/bpf: Add tests to verify link_create logs Date: Tue, 20 Oct 2026 23:28:04 +0800 Message-ID: <20261020152804.39863-7-leon.hwang@linux.dev> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261020152804.39863-1-leon.hwang@linux.dev> References: <20261020152804.39863-1-leon.hwang@linux.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add tests to verify the new logs in link_create and xdp link_create, including a log reported via extack when fail to create an xdp link. Signed-off-by: Leon Hwang --- .../selftests/bpf/prog_tests/xdp_link.c | 101 ++++++++++++++++++ 1 file changed, 101 insertions(+) diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_link.c b/tools/testing/selftests/bpf/prog_tests/xdp_link.c index e7e9f3c22edf..18c1f1039d4e 100644 --- a/tools/testing/selftests/bpf/prog_tests/xdp_link.c +++ b/tools/testing/selftests/bpf/prog_tests/xdp_link.c @@ -150,3 +150,104 @@ void serial_test_xdp_link(void) test_xdp_link__destroy(skel1); test_xdp_link__destroy(skel2); } + +static void test_link_create(int prog_fd, int ifindex, enum bpf_attach_type attach_type, + struct bpf_link_create_opts *opts, int exp_err, const char *msg) +{ + char log_buf[128] = {}; + int fd; + LIBBPF_OPTS(bpf_log_opts, log_opts, + .buf = log_buf, + .size = sizeof(log_buf), + .level = 1, + ); + + fd = bpf_link_create_log(prog_fd, ifindex, attach_type, opts, &log_opts); + if (!ASSERT_LT(fd, 0, "bpf_link_create_log")) { + close(fd); + return; + } + + ASSERT_EQ(fd, exp_err, "fd"); + ASSERT_STREQ(log_buf, msg, "log_buf"); + ASSERT_EQ(log_opts.true_size, strlen(msg) + 1, "log_size"); +} + +static void test_link_create_invalid_prog_fd(void) +{ + const char *msg = "Invalid prog_fd.\n"; + + test_link_create(-1, IFINDEX_LO, BPF_XDP, NULL, -EBADF, msg); +} + +static void test_link_create_invalid_prog_type(void) +{ + const struct bpf_insn insns[] = { + BPF_MOV64_IMM(BPF_REG_0, 0), + BPF_EXIT_INSN(), + }; + const char *msg = "Invalid prog type.\n"; + int prog_fd; + + prog_fd = bpf_prog_load(BPF_PROG_TYPE_LIRC_MODE2, NULL, "GPL", insns, + ARRAY_SIZE(insns), NULL); + if (!ASSERT_GE(prog_fd, 0, "bpf_prog_load")) + return; + + test_link_create(prog_fd, 0, BPF_LIRC_MODE2, NULL, -EINVAL, msg); + + close(prog_fd); +} + +static void test_link_create_attach(int ifindex, enum bpf_attach_type attach_type, + struct bpf_link_create_opts *opts, const char *msg) +{ + struct test_xdp_link *skel; + + skel = test_xdp_link__open_and_load(); + if (!ASSERT_OK_PTR(skel, "test_xdp_link__open_and_load")) + return; + + test_link_create(bpf_program__fd(skel->progs.xdp_handler), ifindex, attach_type, opts, + -EINVAL, msg); + + test_xdp_link__destroy(skel); +} + +static void test_link_create_invalid_attach_type(void) +{ + const char *msg = "Invalid attach_type.\n"; + + test_link_create_attach(IFINDEX_LO, BPF_CGROUP_INET_INGRESS, NULL, msg); +} + +static void test_link_create_xdp_invalid_target_ifindex(void) +{ + const char *msg = "Invalid target_ifindex.\n"; + + test_link_create_attach(0, BPF_XDP, NULL, msg); +} + +static void test_link_create_xdp_extack(void) +{ + const char *msg = "Invalid XDP flags for BPF link attachment\n"; + LIBBPF_OPTS(bpf_link_create_opts, opts, + .flags = XDP_FLAGS_REPLACE, + ); + + test_link_create_attach(IFINDEX_LO, BPF_XDP, &opts, msg); +} + +void test_link_create_log(void) +{ + if (test__start_subtest("invalid_prog_fd")) + test_link_create_invalid_prog_fd(); + if (test__start_subtest("invalid_prog_type")) + test_link_create_invalid_prog_type(); + if (test__start_subtest("invalid_attach_type")) + test_link_create_invalid_attach_type(); + if (test__start_subtest("xdp/invalid_target_ifindex")) + test_link_create_xdp_invalid_target_ifindex(); + if (test__start_subtest("xdp/extack")) + test_link_create_xdp_extack(); +} -- 2.55.0