From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792525144; b=gBnSdST4TIZQFGJ7k8z6/gIGxeUFfQBxRfPWtLmUElohay0F6BZlSkUVYuXrtSKTQbpx n3Xh9oqWvsORwHbTVDRRijpbMQbuCo2pSlynzZsvl1ackxnIlY9DMvGVndGfx4DkEEo+o iQ/z4jBUvIuEkBtljvbawMXJmPMq28m51t9q69IKXmuB7Ge/kfdAtOv8qdPaL1X+7zAKC 1E/4gOKO3OCcbCvuRfC8XKDavLtDmFv8avi8v/KgV+0ZSTm1lhSbH7oZrFrSCtCiEhNFJ 5yHc6EIRuA6KD7eZrxi8b2cANetgLHuwBupERuO5Ppw9+GzfJftbBB4kaj8y4N6Bk1A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792525144; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Date:From: To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=JkjH/Sgg5VxVUFVBkqKACHe5NY0hXmzsOqepQjU71sU=; b=yVbypzYGTd7QFTogcpRC9qyVa6t9KxyIADglYbyqb+sRZDzv16pPqGVPdS0o3gjEb+5n erzWLNgGMuY7QaCJRWivuzXMbFyqwxCKMcdTWtuc/A2ENeroLcUyep2GKBAAqFhFvLATB Z7VNWlYXlrlznoVKv1zyvxo9MqRrdTOmgUnVk+XXtSM5zoQbHsl0fGAMR/I9obtnPOCjl U504V8IJ96VTnIQvmS0Y8Wpgc85QfMy/XPh8BerOM39wMPohwZgLmr0aLhxc4ltd9r4Xe ONrLlXzmvsU60+io6jbvxgKnlfvOx0lW+D1oUDL+KxWgdLsIljfQzN9Za2ji1WoutRQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ukt7ZNcO; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b="YwG4gyY/"; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8D1C606A31F for ; Tue, 20 Oct 2026 19:39:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E8D1C606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ukt7ZNcO; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=YwG4gyY/ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792525143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JkjH/Sgg5VxVUFVBkqKACHe5NY0hXmzsOqepQjU71sU=; b=Ukt7ZNcOMNNjEZUH1JFRD4glAREXo4b/q6SnBjPJNSbhPw8HKYJdUj33MR/Oa5v6hvouWs LBdU4nwlQeCjKTYyqW7nNA2794lZqbwfCKBYJPOqrg8mcTsd5r29UDcLC4ZcHOa9qTNGaU vZHOcwDkZ8yuZ34Q1kElgvKOT9Gyqqk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-tvP3ZBZSNUqvXGSxOz5apA-1; Tue, 20 Oct 2026 15:38:59 -0400 X-MC-Unique: tvP3ZBZSNUqvXGSxOz5apA-1 X-Mimecast-MFC-AGG-ID: tvP3ZBZSNUqvXGSxOz5apA_1792525139 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48af5a07314so2345935f8f.2 for ; Tue, 20 Oct 2026 12:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1792525138; x=1793129938; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JkjH/Sgg5VxVUFVBkqKACHe5NY0hXmzsOqepQjU71sU=; b=YwG4gyY/ENGGcCpJomkCZlMTnbLuumIdx/YPQEbXTc6mcrNQIGVoYqhUPsb2ciyYi6 dWF2+TOjfKrDOnMQrSld4XieEBCV9y4sGWE23WnyZN4rWdVJcCjUtqQ8Gv+v/4U9upww B/9ahfxfMjpN4QW9vybfDsi28gOPkbNLD51RFgskjTuzajsO2WE+NgyOzXE6BzOd/lPY zYKWRcOP0DqtbiXEmzt+b8fLjKgJRU4x60osFysMs1sw9xQOylAvV4LprEyFWA+AKIii nO18HsQ++KofGc7S4bJwE/86uHMrshLR0LEZlKwFrKDyALFud/RsaWebstj4sPSvP+6N MTgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792525138; x=1793129938; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JkjH/Sgg5VxVUFVBkqKACHe5NY0hXmzsOqepQjU71sU=; b=ULSDQ/LINe5c3nLL9kwtkyNNEBtYTknrIjdhp498BqpoZW61dFyCZcqKW4LoYpo/xP 44XR6vJb0lAOxiljFxJNWLkqORs6U9Q6PZ0zZ1CmeSV2t7dDrS+VR89RAdsEdjzrtMIE 3QdyiQX2uoXog2F3RYLol7BF1MHu1JTzfNUIegEYd/m6o4I004Tl4DvAZY+Lbi7SUS22 bC29LS/6k/RnXMzQgZZXACgPhC/OODZmJWqV4Z/TyOOX1tIUrH/VF50Qxe9w+0fx8O33 Bd/vDh+o39h7OS7FNbWrapCyhqPJNvafhpPhmWqqKB/N6ZiYtjLC28gObFPnxXYQ9wj7 ImjA== X-Gm-Message-State: AFq9FYLDl0xxNJi9Gu1Xsa316iGIjRJajVsCaZhlNfr+5zEpgmhu94EL IGuyv86vI9822BlJEAtmbUToyM7P91QlSbgx6uqCdnAOfiYYIGK3Oy3X0HDZnBliYsC9uBJklgR R4SylQ1V14ye7nALIOPn7PaNKPG5NVa+YnGIl6ugQWlG656sVul70xiwJSHJH8b6EjA== X-Gm-Gg: AYBFou2De67LWphRCkRkjY/U9ZDvI3HnYgKSiaVIgyYmJia/eShW/+QZ3b/qgftlPG7 R+gmfigsMdDIApnNAW1PqM3O81h4Bm2WoTu0i1djf3JMb1ickBgeod8dtvc+xXCSeNTlUP1YQa9 iQ0zNDGpsG+Iny3BAwE/s726vudCChUH/MsRLrRhxEc7NvPdg+1klxQnt0hjwFUWN4GxO5MBE70 Kf0DhFS0A3RrPT/M96T/EkUAsQqqikyJzYHRxYnrgBXFGhhCqC13M3rAMpHcbU0hE5lVlCspdhn B24srIDfANYVF96vqzMBIT1m38T5H/d1MYBItyWIhV1go1a53sx8O048pYQVZWA/dBy6lA== X-Received: by 2002:a05:6000:1b8f:b0:487:72f:fb41 with SMTP id ffacd0b85a97d-48e07fa0e82mr18492836f8f.39.1792525138267; Tue, 20 Oct 2026 12:38:58 -0700 (PDT) X-Received: by 2002:a05:6000:1b8f:b0:487:72f:fb41 with SMTP id ffacd0b85a97d-48e07fa0e82mr18492786f8f.39.1792525137659; Tue, 20 Oct 2026 12:38:57 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:3fd7:5300:3d6b:52a4:a23f:9d0b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e25828cbfsm425597f8f.23.2026.10.20.12.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 12:38:56 -0700 (PDT) Date: Tue, 20 Oct 2026 15:38:53 -0400 From: "Michael S. Tsirkin" To: Willem de Bruijn Cc: linux-kernel@vger.kernel.org, Chris Arges , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Phil Sutter , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, virtualization@lists.linux.dev, Max Krasnyansky , Rusty Russell , Simon Horman Subject: Re: [PATCH net v3 1/8] net: account for ingress-resolved virtio net hdr state Message-ID: <20261020153650-mutt-send-email-mst@kernel.org> References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Oct 20, 2026 at 03:27:46PM -0400, Willem de Bruijn wrote: > Michael S. Tsirkin wrote: > > The following patch will add ingress resolution of uncommon virtio net > > hdr checksum metadata (software checksum completion at ingress) which > > adds performance overhead to the packet processing. > > > > We should make it visible, so a hypothetical workload relying on > > uncommon metadata can be distinguished from none at all. This way issues > > in the parsing will be reported and not quietly pay the host-CPU > > checksum overhead instead of offload. > > > > Flip every call to virtio_net_hdr_to_skb to test for negative errno > > only, and have tun count these events per device as rx_csum_sw, exposed > > via ethtool -S. > > > > Assisted-by: LLM > > Signed-off-by: Michael S. Tsirkin > > --- > > drivers/net/tap.c | 4 ++-- > > drivers/net/tun.c | 41 ++++++++++++++++++++++++++++++++++++++-- > > drivers/net/virtio_net.c | 2 +- > > net/packet/af_packet.c | 4 ++-- > > 4 files changed, 44 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/net/tap.c b/drivers/net/tap.c > > index ff67d99deb39..73e883394446 100644 > > --- a/drivers/net/tap.c > > +++ b/drivers/net/tap.c > > @@ -649,7 +649,7 @@ static ssize_t tap_get_user(struct tap_queue *q, void *msg_control, > > > > if (vnet_hdr_len) { > > err = tun_vnet_hdr_to_skb(q->flags, skb, &vnet_hdr); > > - if (err) { > > + if (err < 0) { > > rcu_read_unlock(); > > drop_reason = SKB_DROP_REASON_DEV_HDR; > > goto err_kfree; > > @@ -1084,7 +1084,7 @@ static int tap_get_user_xdp(struct tap_queue *q, struct xdp_buff *xdp) > > > > if (vnet_hdr_len) { > > err = tun_vnet_hdr_to_skb(q->flags, skb, gso); > > - if (err) { > > + if (err < 0) { > > rcu_read_unlock(); > > goto err_kfree; > > } > > similar to tun, should tap count this event? > > > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > > index 242899f7fd07..19cb443c89b0 100644 > > --- a/drivers/net/tun.c > > +++ b/drivers/net/tun.c > > @@ -210,6 +210,7 @@ struct tun_struct { > > u32 flow_count; > > u32 rx_batched; > > atomic_long_t rx_frame_errors; > > + atomic64_t rx_csum_sw; > > is a normal (and cheaper on 32b platforms) atomic_t or atomic_long_t sufficient? well it can overflow easily. i don't know that we care that a slow path will be even a bit slower on these ancient platforms. correct reporting seems more important. > > struct bpf_prog __rcu *xdp_prog; > > struct tun_prog __rcu *steering_prog; > > struct tun_prog __rcu *filter_prog; > > @@ -1935,11 +1936,16 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile, > > break; > > } > > > > - if (tun_vnet_hdr_tnl_to_skb(tun->flags, features, skb, &hdr)) { > > + err = tun_vnet_hdr_tnl_to_skb(tun->flags, features, skb, &hdr); > > + if (err < 0) { > > atomic_long_inc(&tun->rx_frame_errors); > > err = -EINVAL; > > goto free_skb; > > } > > + if (err > 0) { > > } else if (err > 0) { > > > + atomic64_inc(&tun->rx_csum_sw); > > + err = 0; > > + } > > > > if ((tun->flags & TUN_TYPE_MASK) == IFF_TAP) > > skb->protocol = eth_type_trans(skb, tun->dev); > > @@ -2605,12 +2611,15 @@ static int tun_xdp_one(struct tun_struct *tun, > > tnl_hdr = (struct virtio_net_hdr_v1_hash_tunnel *)gso; > > skb->dev = tun->dev; > > skb_set_network_header(skb, ETH_HLEN); > > - if (tun_vnet_hdr_tnl_to_skb(tun->flags, features, skb, tnl_hdr)) { > > + ret = tun_vnet_hdr_tnl_to_skb(tun->flags, features, skb, tnl_hdr); > > + if (ret < 0) { > > atomic_long_inc(&tun->rx_frame_errors); > > kfree_skb(skb); > > ret = -EINVAL; > > goto out; > > } > > + if (ret > 0) > > same > > > + atomic64_inc(&tun->rx_csum_sw); > > maybe reset ret = 0 in all these branches > > > > > skb->protocol = eth_type_trans(skb, tun->dev); > > skb_reset_network_header(skb); > > @@ -3739,7 +3748,35 @@ static void tun_get_channels(struct net_device *dev, > > channels->max_combined = tun->flags & IFF_MULTI_QUEUE ? MAX_TAP_QUEUES : 1; > > } > > > > +#define TUN_STATS_LEN 1 > > +static const char tun_ethtool_strings[TUN_STATS_LEN][ETH_GSTRING_LEN] = { > > + "rx_csum_sw", > > +}; > > + > > +static int tun_get_sset_count(struct net_device *dev, int sset) > > +{ > > + return sset == ETH_SS_STATS ? TUN_STATS_LEN : -EOPNOTSUPP; > > +} > > + > > +static void tun_get_strings(struct net_device *dev, u32 stringset, u8 *data) > > +{ > > + if (stringset == ETH_SS_STATS) > > + memcpy(data, tun_ethtool_strings, > > + sizeof(tun_ethtool_strings)); > > +} > > + > > +static void tun_get_ethtool_stats(struct net_device *dev, > > + struct ethtool_stats *stats, u64 *data) > > +{ > > + struct tun_struct *tun = netdev_priv(dev); > > + > > + data[0] = atomic64_read(&tun->rx_csum_sw); > > +} > > + > > static const struct ethtool_ops tun_ethtool_ops = { > > + .get_sset_count = tun_get_sset_count, > > + .get_strings = tun_get_strings, > > + .get_ethtool_stats = tun_get_ethtool_stats, > > .supported_coalesce_params = ETHTOOL_COALESCE_RX_MAX_FRAMES, > > .get_drvinfo = tun_get_drvinfo, > > .get_msglevel = tun_get_msglevel, > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index daab43ac92ce..2e6fd81df9c4 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -2519,7 +2519,7 @@ static void virtnet_receive_done(struct virtnet_info *vi, struct receive_queue * > > skb_set_network_header(skb, ETH_HLEN); > > if (virtio_net_hdr_tnl_to_skb(skb, &hdr->tnl_hdr, vi->rx_tnl, > > vi->rx_tnl_csum, > > - virtio_is_little_endian(vi->vdev))) { > > + virtio_is_little_endian(vi->vdev)) < 0) { > > net_warn_ratelimited("%s: bad gso: type: %x, size: %u, flags %x tunnel %d tnl csum %d\n", > > dev->name, hdr->hdr.gso_type, > > hdr->hdr.gso_size, hdr->hdr.flags, > > should virtio_net count these too? Or do we assume that devices are > more trustworthy, so unlikely to cause this issue? With memory encryption, from an untrusted host? i can add that. > > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > > index 52ae3d875e97..e6aec9ecfa99 100644 > > --- a/net/packet/af_packet.c > > +++ b/net/packet/af_packet.c > > @@ -2913,7 +2913,7 @@ static int tpacket_snd(struct packet_sock *po, struct msghdr *msg) > > } > > > > if (has_vnet_hdr) { > > - if (virtio_net_hdr_to_skb(skb, &vnet_hdr, vio_le())) { > > + if (virtio_net_hdr_to_skb(skb, &vnet_hdr, vio_le()) < 0) { > > tp_len = -EINVAL; > > goto tpacket_error; > > } > > @@ -3136,7 +3136,7 @@ static int packet_snd(struct socket *sock, struct msghdr *msg, size_t len) > > > > if (vnet_hdr_sz) { > > err = virtio_net_hdr_to_skb(skb, &vnet_hdr, vio_le()); > > - if (err) > > + if (err < 0) > > goto out_free; > > len += vnet_hdr_sz; > > } > > -- > > MST > > >