mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrei-Alexandru Bleortu <me@andrei-z.com>
To: Jinpu Wang <jinpu.wang@cloud.ionos.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	Bart Van Assche <bvanassche@acm.org>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 3/3] RDMA/rtrs: Post client read requests inline
Date: Tue, 20 Oct 2026 15:39:38 +0300	[thread overview]
Message-ID: <20261020153938.1445837-1-me@andrei-z.com> (raw)
In-Reply-To: <CAMGffE=qjNDYdwx1PYgK1K87A4NhJ=cuR+kkUhdYH81gSGb-nQ@mail.gmail.com>

On Tue, Oct 20, 2026, Jinpu Wang wrote:
> The change looks fine to me, and I did some testing on it. However,
> the data doesn't seem to show any clear performance gain from posting
> inline requests.

Thanks for testing it.

That matches what I measured. The gain only showed with one I/O in
flight against a memory-backed device (4 KB random reads to null_blk,
ConnectX-6 Dx over RoCE): fio's mean completion latency went from 20.1
to 19.7 us, under 2 %, and it took 15 paired rounds to resolve. With
more I/O in flight or a real drive it would be lost in the noise.

As I wrote to Leon, I'll leave the series unless someone finds that
latency matters to them.


      reply	other threads:[~2026-10-20 12:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 12:51 [PATCH RFC 0/3] RDMA: Post small ULP command messages inline Andrei-Alexandru Bleortu
2026-10-15 12:51 ` [PATCH RFC 1/3] IB/iser: Post header-only PDUs inline Andrei-Alexandru Bleortu
2026-10-15 12:51 ` [PATCH RFC 2/3] RDMA/srp: Post command IUs inline Andrei-Alexandru Bleortu
2026-10-15 17:24   ` Bart Van Assche
2026-10-15 18:22     ` Andrei-Alexandru Bleortu
2026-10-18 10:05       ` Leon Romanovsky
2026-10-19 20:12         ` Andrei-Alexandru Bleortu
2026-10-15 12:51 ` [PATCH RFC 3/3] RDMA/rtrs: Post client read requests inline Andrei-Alexandru Bleortu
2026-10-20  6:17   ` Jinpu Wang
2026-10-20 12:39     ` Andrei-Alexandru Bleortu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261020153938.1445837-1-me@andrei-z.com \
    --to=me@andrei-z.com \
    --cc=bvanassche@acm.org \
    --cc=haris.iqbal@ionos.com \
    --cc=jgg@ziepe.ca \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mgurtovoy@nvidia.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®