From: Eric Biggers <ebiggers@kernel.org>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org, stable@vger.kernel.org,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] KEYS: Reject @desclen values >= KEY_MAX_DESC_SIZE in key_alloc()
Date: Tue, 20 Oct 2026 15:50:13 +0000 [thread overview]
Message-ID: <20261020155013.GB699485@google.com> (raw)
In-Reply-To: <atdl74PtEpLxVPdd@kernel.org>
On Tue, Oct 20, 2026 at 04:00:31PM +0300, Jarkko Sakkinen wrote:
> On Tue, Oct 20, 2026 at 01:57:19PM +0300, Jarkko Sakkinen wrote:
> > > Sure, this fix is still incomplete though, as I mentioned.
> > >
> > > Turns out Sashiko found this too; see the comment on
> > > https://sashiko.dev/#/patchset/20261020013903.1244157-1-jarkko%40kernel.org
> >
> > I did not ignore what you said honestly but I overlooked generated
> > descriptions.
> >
> > By comparing your v2 response and Sashiko's response and going through the
> > code this is the list that I have where similar check should be placed:
> >
> > - key_alloc(): before quota calculation (in place)
> > - __key_create_or_update(): before assigning index_key.desc_len
> > - keyring_search(): before match_preparse
> > - request_key_and_link(): before match_preparse
> > - request_key_rcu(): before check_cached_key()
> >
> > Some sites might require some minor changes I just wrote the around the
> > ballpark locations.
> >
> > Did I miss any site that you are aware of?
It looks okay to me.
> - Would it make sense to wrap strlen + check into key_is_valid_desc()?
I don't think it would be very helpful.
> - Would it make sense as a safe-guard to use strnlen(), which is capped
> to KEY_MAX_DESC_SIZE?
Not really needed. They are NUL-terminated strings anyway.
- Eric
next prev parent reply other threads:[~2026-10-20 15:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 1:38 [PATCH v3 0/3] KEYS: rhashtable bug fixes Jarkko Sakkinen
2026-10-20 1:38 ` [PATCH v3 1/3] KEYS: Expand key->{datalen,quotalen} to unsigned int Jarkko Sakkinen
2026-10-20 15:47 ` Eric Biggers
2026-10-20 15:56 ` Jarkko Sakkinen
2026-10-20 1:38 ` [PATCH v3 2/3] KEYS: Reject @desclen values >= KEY_MAX_DESC_SIZE in key_alloc() Jarkko Sakkinen
2026-10-20 1:47 ` Jarkko Sakkinen
2026-10-20 2:28 ` Eric Biggers
2026-10-20 10:57 ` Jarkko Sakkinen
2026-10-20 13:00 ` Jarkko Sakkinen
2026-10-20 15:50 ` Eric Biggers [this message]
2026-10-20 16:09 ` Jarkko Sakkinen
2026-10-20 1:38 ` [PATCH v3 3/3] KEYS: Verify the key identity in __key_unlink_begin Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020155013.GB699485@google.com \
--to=ebiggers@kernel.org \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®