mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Carlo Szelinsky <github@szelinsky.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
	Kory Maincent <kory.maincent@bootlin.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Piotr Kubik <piotr.kubik@adtran.com>,
	Sai Krishna <saikrishnag@marvell.com>,
	Simon Horman <horms@kernel.org>,
	Kyle Swenson <kyle.swenson@est.tech>,
	netdev-bot+sashiko@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Carlo Szelinsky <github@szelinsky.de>
Subject: [PATCH net-next v2 0/2] net: pse-pd: si3474: probe error path cleanups
Date: Tue, 20 Oct 2026 19:11:31 +0200	[thread overview]
Message-ID: <20261020171134.852878-1-github@szelinsky.de> (raw)

Two small changes to the error paths in si3474 probe. They do not
depend on the PSE fixes for net ("net: pse-pd: assorted lifetime and
error-path fixes" v2) and apply to net-next as they are.

 1  The error message after a failed devm_add_action_or_reset() reads
    the ancillary I2C client, which was just unregistered.
 2  Use dev_err_probe() for a failed controller registration, as
    pd692x0 and tps23881 do.

1 was found by code inspection and not reproduced. Both are
build-tested only, with W=1.

Changes in v2:
 - 1 was patch 9 of the net series v1 [1]. Kory asked to send it to
   net-next, as it is not an urgent fix. Collected his Reviewed-by.
 - 2 was patch 3 of the net-next series v1 [2]. Its message no longer
   mentions the vpwr supply check from that series, which is not part
   of this version.

[1] https://lore.kernel.org/netdev/20261018082314.48950-1-github@szelinsky.de/
[2] https://lore.kernel.org/netdev/20261018081853.47484-1-github@szelinsky.de/

Carlo Szelinsky (2):
  net: pse-pd: si3474: fix use-after-free in ancillary client error path
  net: pse-pd: si3474: use dev_err_probe() for controller registration

 drivers/net/pse-pd/si3474.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)


base-commit: 8cc24527d54d3ecaa09eec5a91bd107bb8b3d7d3
-- 
2.43.0


             reply	other threads:[~2026-10-20 17:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 17:11 Carlo Szelinsky [this message]
2026-10-20 17:11 ` [PATCH net-next v2 1/2] net: pse-pd: si3474: fix use-after-free in ancillary client error path Carlo Szelinsky
2026-10-20 17:11 ` [PATCH net-next v2 2/2] net: pse-pd: si3474: use dev_err_probe() for controller registration Carlo Szelinsky
2026-10-20 17:15 ` [PATCH net-next v2 0/2] net: pse-pd: si3474: probe error path cleanups Kory Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261020171134.852878-1-github@szelinsky.de \
    --to=github@szelinsky.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kory.maincent@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=kyle.swenson@est.tech \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=piotr.kubik@adtran.com \
    --cc=saikrishnag@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®