From: Andrew Morton <akpm@linux-foundation.org>
To: Bradley Morgan <brads@mainlining.org>
Cc: Avi Weiss <thnkslprpt@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] profiling: fix sampling step on 64-bit big-endian systems
Date: Tue, 20 Oct 2026 17:46:43 -0700 [thread overview]
Message-ID: <20261020174643.41ce3b98434d0791af79cda7@linux-foundation.org> (raw)
In-Reply-To: <FBD0DC2E-B6C0-400A-A2C2-BA8BA127E43E@mainlining.org>
On Tue, 20 Oct 2026 17:50:24 +0100 Bradley Morgan <brads@mainlining.org> wrote:
> On 20 October 2026 17:47:22 BST, Avi Weiss <thnkslprpt@gmail.com> wrote:
> >I'm happy to try it anyway - just so I know how for future patches.
> >I'll see how many I can run through before my laptop gives up ;-)
>
> sometimes the crux is for these kinds of patches something in some cryptic
> arch gets messed up in vmlinux stage, odd right?
>
> This *makes sense* for me, off the top of my head and thinking hard id say
> this *shouldn't* do anything bad to a cryptic architecture, but I've been
> shocked in the past.
OK, read_profile() makes me question my career choices.
It starts out with totally inappropriate type choices then bandaids
over that by typecasting just about every damn thing in there. None of
it is commented, natch.
I'll grab Avi's fix for this merge window. I persuaded the
coin-operated coding machine to generate a couple of patches to fix a
pre-existing thing and to clean up that code. I'll send them
separately so Sashiko takes a look. Please review.
next prev parent reply other threads:[~2026-10-21 0:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 10:12 Avi Weiss
2026-10-20 15:07 ` Bradley Morgan
2026-10-20 16:47 ` Avi Weiss
2026-10-20 16:50 ` Bradley Morgan
2026-10-21 0:46 ` Andrew Morton [this message]
2026-10-21 3:13 ` Avi Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020174643.41ce3b98434d0791af79cda7@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=brads@mainlining.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thnkslprpt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®