From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792545743; b=QHK5gAVeOPnxJiuIdBA60gLwwaNaZWYMZDE3xOOJR4I/B4RtrtPAOO92y8d94bj/73D8 K/s1XFis/MEwFff1z0fBesJorlMN8WdEiTEEbq2k0VgNWdMfUJ+peI+brBSQ1uhjS8R6p ya72H4R1dtGGw4jxdLQgJCyPCQHUZ2BElHd6SEv7CI0g0k5joYNYiDQsBYN9DsaGyxFjM 3UCpSHfU7DzoZuoluKctpMjRWCoJ5R3H0FMMCPpU13rY5jGMf8csAMGi1z2JFAH3D1/HC LujKcacaIoRtk6aC+g3ZhlBqp9vysbkh4QiMnnZmT3uo8n3zGkrXwvFeL3t5AzjiIYQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792545743; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=/06k/OCF8qTJ0wBVY/M8ek9mzAGmnWdgB2kFs8X3vhc=; b=LMCGZpjvqm2nEVHTrF8cIDk+0T0CsykYA43XYQp73SQQKy9QJIwYjuw2GwJ4/Zvr0Ixa 1p08Xw2U2FPt/Ds8y1pfuyW+wp0ZGsmZZdt6RBh8RL9tpQe+pufq/EevBTa+jdByic+q7 +R2S7EPdJE9uxVnd9QfeQeNfr7J0/P5TFmzGVZRoEXM0ipqAgV+0Ti8X+WhrFJzW2sXzm 4IyxpsZwY7nSIFdnvNBRa/r35+E5uEYxjx+iy4CyK7qbR/2RPERwd2n18oE+v0E5gYp7Z 00mB8fWd+PPj/8rGtgvTNL2vDlAf8ZMGeD+NglT70mNdMN5MsHMCCmTETKiCHIi/6xg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=obwkoVec; arc=none smtp.remote-ip=74.125.82.43 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B12BD606A31A for ; Wed, 21 Oct 2026 01:22:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B12BD606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=obwkoVec Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-15354aa70e8so615990c88.1 for ; Tue, 20 Oct 2026 18:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792545742; x=1793150542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=/06k/OCF8qTJ0wBVY/M8ek9mzAGmnWdgB2kFs8X3vhc=; b=obwkoVecAkYYZz8g4jFcYK7AYWGEYr4NK+xZTIJYXNVAMhuNsmp4RnYr8Sc8c3FFa3 co7DEXC5uG6TP9+Kmah33xHb3viiK3hRgqddzXyLBLSnVlAcZ2lb/kShvIzYXEU8tkX9 5RVRiGkYAX3cJFFbDl7YyBFl7AnP8ZJcuNCNEjVznRvZ/cM4SsnS+c83NRNyHqMEkzzn wEW6InOM8DXK7nyLH4WZIV6/9eu0YP0JqNTqoKviXrACHl3qhE/6uG3jP9bjYRZ6YYRB F9i8S4nmlcu1xnrkIrK5498J3RfErA2Uo61d6DH6+vX/vqZvXTBCt1lGuHDqplU9FQnS 5yDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792545742; x=1793150542; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/06k/OCF8qTJ0wBVY/M8ek9mzAGmnWdgB2kFs8X3vhc=; b=qgoqlD9IX056XSVtnwCTc1s9VypxOxfFX4n8Z4Hip6lWsBBvx48By1HUD2PMlTFNLX Te2PSoM8IfhqkXUeozWE82fUn6jcCeAHiI8RdkNOQMOCrB9DdfakUo3HthiZEfYsdjtA KrmbQo3sA7LFI+W94yXrxJOQUkjdcic96uWY427fxf7tiKMlGSOvegBuoSCng4b1Es2Y WxJ6YyRjIlJK2lH0oj2x2yfrgz69LvaZB/ctoyc8/2Q5W0Z4XR4Rs5j2GufEDaATbXW3 zfGeGsHDfdEUntHndIx7ucDvOwkb8XROEQkamlWBTIxBfT0hji42wVU2T4pCkTDPDiq5 WPkg== X-Forwarded-Encrypted: i=1; AKwUvBySYJ+cFRZiHH6LwBnNLL5ewACS+vA9cluFQ2mqg2jb/igImf8hThsL0aT76IoiZA80MpphMySiq60OcQA=@vger.kernel.org X-Gm-Message-State: AFq9FYKgyn+AOESW6G6zjVSBQOc1ETCOZixL8EqORO29TZehdIMrX6+U 4683XTxZrSVXNyZskNidNFFwWWkgXLuBeHltCA8W7BkZ0vO+tayWGVcg X-Gm-Gg: AYBFou0ArHnWX1O0hIliNbPRO9VerdX9KBKoAIXvedMWEQGYAJP2JIawgsgAPk/haWE tTyJlHFX+wFVWk7uGgMCTg9Sbk6n7LUufUVWdSFKh2HH3bgPAe1lEg6nso2xDzlvILipQS3Y1Ea r5fuk3328sqkgqn6cZCrU3BL160J5obdfjsFCh5JyKakcz+oDO8JwDBADpbxthwi2W4CANfsd6Q WrbAa14kJu6akzFpNv1an595TleZykonV9AFrhRueIzGnNXcC4sXcbiM3PxRnqIXSqJJUQBchAs u9aMsF49w0CeU3EEaIIus+LFFGqx0pN6lo6sShjBzuPRSOx8Ii2bw4tBzdAimCbmHDsiFcj+B7K btQK3JQ1zAM6y/e9fAI7rKGgENM1X8jBtJffKhv5XkU6HgcGCYVt+dTf66qR8W9+i/uLJoC7JM3 0M/x6kDiz9qoPc6pDYwGes99k14NNqOMfBEK/ob1m3OOZwVxWYKYxh1dhRigQFbxCfizj69Vv5a PDxbz7jEgjqVsHZt0xY0P8a4EkgU96R+kI5ElRAjGPnVHrePYUhFvdBl+vR X-Received: by 2002:a05:7022:b90c:b0:14d:baf5:c40f with SMTP id a92af1059eb24-190a465c250mr649391c88.14.1792545741421; Tue, 20 Oct 2026 18:22:21 -0700 (PDT) Received: from CachingPlasma ([45.117.246.230]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1903a275026sm2935541c88.5.2026.10.20.18.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 18:22:21 -0700 (PDT) From: DragonicRage13 To: tiwai@suse.com Cc: perex@perex.cz, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, DragonicRage13 Subject: [PATCH v2] ALSA: hda/realtek: Add mute and mic-mute LEDs for HP ENVY 16 (103c:8be5) Date: Wed, 21 Oct 2026 13:22:05 +1200 Message-ID: <20261021012205.9431-1-ajaneshlal3@gmail.com> X-Mailer: git-send-email 2.56.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The HP ENVY Laptop 16-h1xxx (PCI SSID 103c:8be5) uses an ALC245 codec with CS35L41 I2C speaker amplifiers. No LED fixup is applied for this subsystem ID, so the speaker mute LED and the microphone mute LED are never driven and do not follow their keys. Add a fixup that calls the existing ALC245 mute LED COEF helper and the GPIO mic-mute LED helper directly, then chains to the CS35L41 I2C amplifier setup so the speakers keep working. Use it for 103c:8be5. Tested on an HP ENVY Laptop 16-h1xxx running kernel 7.2.11: the hda::mute and hda::micmute LEDs appear and follow their keys, and the speaker amplifiers still bind (CS35L41 Bound in dmesg). The mic LED GPIO pin and polarity are not verified on other hardware. Assisted-by: Claude:claude-haiku-5-5 Signed-off-by: DragonicRage13 --- Changes in v2: - Resend with intact whitespace (tabs); no code changes. sound/hda/codecs/realtek/alc269.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c index e98cc42e1..850a15801 100644 --- a/sound/hda/codecs/realtek/alc269.c +++ b/sound/hda/codecs/realtek/alc269.c @@ -1572,6 +1572,14 @@ static void alc245_fixup_hp_mute_led_coefbit(struct hda_codec *codec, } } +/* mute LED via COEF bit and mic-mute LED via GPIO, called directly */ +static void alc245_fixup_cs35l41_mute_micmute(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + alc245_fixup_hp_mute_led_coefbit(codec, fix, action); + alc245_fixup_hp_gpio_led(codec, fix, action); +} + static void alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec, const struct hda_fixup *fix, int action) @@ -4230,6 +4238,7 @@ enum { ALC245_FIXUP_BASS_HP_DAC, ALC245_FIXUP_ACER_MICMUTE_LED, ALC245_FIXUP_CS35L41_I2C_2_MUTE_LED, + ALC245_FIXUP_CS35L41_I2C_2_MUTE_MICMUTE_LED, ALC236_FIXUP_HP_DMIC, ALC256_FIXUP_HONOR_MRB_XXX_M1020_AUDIO, ALC245_FIXUP_HP_ENVY_X360_15_FH0XXX, @@ -6859,6 +6868,12 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC287_FIXUP_CS35L41_I2C_2, }, + [ALC245_FIXUP_CS35L41_I2C_2_MUTE_MICMUTE_LED] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc245_fixup_cs35l41_mute_micmute, + .chained = true, + .chain_id = ALC287_FIXUP_CS35L41_I2C_2, + }, [ALC236_FIXUP_HP_DMIC] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl[]) { @@ -7361,7 +7376,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8be1, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x103c, 0x8be2, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x103c, 0x8be3, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2), - SND_PCI_QUIRK(0x103c, 0x8be5, "HP Envy 16", ALC287_FIXUP_CS35L41_I2C_2), + SND_PCI_QUIRK(0x103c, 0x8be5, "HP Envy 16", ALC245_FIXUP_CS35L41_I2C_2_MUTE_MICMUTE_LED), SND_PCI_QUIRK(0x103c, 0x8be6, "HP Envy 16", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x103c, 0x8be7, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x103c, 0x8be8, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2), -- 2.56.0