From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=210.61.82.184 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792567450; b=jdXJRoNabXjjr0TywjIus188kelsxTbuJP8v6iTPRjovqB+N4uZ8mL7e1+LyfF4MjxlZ BT9pqBIKX0WPCFbkjKKYYBLqus3vgxocJ2y6SbnwqWMhBVUNpTgEJjypTOLXHLdpNQx6O lw4KJh4kQFpl5u2HvfZbVA9dVZDLqTDQMluW7Vd81V9DscURVCzk2k4kuBKT42PuAuanS pSTzk1aYxbIQip67J0N5uyZxtoBvGD6aV6T/qiSPWlnaHt3Ln5bjb5TF3/fhDX0Ja0LRx jgP8h5w75mBU+3EaGh5/NG5Ynt1mTcciATHs3faYad5Cr3jTWwQT1bHwGnz3TaK2fww== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792567450; h=DMARC-Filter:X-UUID:DKIM-Signature:X-CID-P-RULE:X-CID-O-INFO: X-CID-META:X-CID-BVR:X-CID-BAS:X-CID-FACTOR:X-CID-RHF:X-UUID:Received: Received:Received:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=nCsIQozWbiChRVAnBeeMNJUrcxjUzwc0Cz0qWxIuZNg=; b=iYFceV4Y1NJaIKZYVO5mzlGOSxgfG6sE/7kTF3A8kiZrNdj3gLd+NhxJifGhheRuYJnl WWbkrc+1a595Z8ISIsvPphuQhnZZFDNlqRg8u+Mal4FHObFsiLQ2MtfurKIusqTJeO6sW wNXtlJIsiFTK62LR8WCe3k395m9C96HjUla1LU91QkxsXRK2j30jesxDBG2SvE+0k0jIr 6z0BVWuIP5KN9xVIhGdHs9QTqDOUgBHCeFJn0trpWMq+0ngF26ivg0MXRXN7sJvjwY/QF hvIKrdfnunHliYTgxROkOE1CVE0sWxUWHT18hSO8XL9K72eCydA96kUBf01OcY/VveQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256 header.s=dk header.b=NL3VYw0n; arc=none smtp.remote-ip=210.61.82.184 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85098606A319; Wed, 21 Oct 2026 07:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 85098606A319 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256 header.s=dk header.b=NL3VYw0n X-UUID: 61ed4d46cd2011f18dc8c9802ae25ab1-20261021 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=nCsIQozWbiChRVAnBeeMNJUrcxjUzwc0Cz0qWxIuZNg=; b=NL3VYw0n0lfQ+q17Mch6dwDZkxEpdi2dM9cbHFuz24Ztqi3QGDApZeu+qbkFDdJ72s6z2q4PBfCQ109kf7A2D6pw47KqVoiIYuTaxWOwDTf/XUlnCLw0P5bDzvzFe57uqDVZTVjMd0iSLo75Ey2Y9Rz9hVrJDEADx0IrugbkmlE=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.20,REQID:e2d27e43-ead7-45f7-b893-ae60b6687235,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:291e20b,CLOUDID:ff187c37-ba88-4c75-aecc-1db722171f54,B ulkID:nil,BulkQuantity:0,SF:81|82|102|836|865|888|898,TC:-5,Content:0|15|5 0|99,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL:0,OSI:0, OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 61ed4d46cd2011f18dc8c9802ae25ab1-20261021 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1108674173; Wed, 21 Oct 2026 15:23:59 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Wed, 21 Oct 2026 15:23:57 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Wed, 21 Oct 2026 15:23:57 +0800 From: Chris Lu To: Marcel Holtmann , Johan Hedberg , Luiz Von Dentz CC: Hao Qin , Wenlong Tian , Sean Wang , Will Lee , SS Wu , linux-bluetooth , linux-kernel , linux-mediatek , Chris Lu Subject: [PATCH v3 1/3] Bluetooth: btmtk: drop zero-length ISO packets from endpoint padding Date: Wed, 21 Oct 2026 15:23:53 +0800 Message-ID: <20261021072356.1449539-2-chris.lu@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20261021072356.1449539-1-chris.lu@mediatek.com> References: <20261021072356.1449539-1-chris.lu@mediatek.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The ISO interrupt IN endpoint delivers a fixed-size transfer that holds one HCI ISO packet and zero-fills the remainder. That padding belongs to the transfer rather than to the stream, so it has to be dropped instead of reported to the host. btmtk_recv_isopkt() keeps parsing it: the zero bytes read as an ISO header with handle 0 and a Data_Total_Length of zero, and each one is passed to hci_recv_frame() as a complete frame. A single transfer yields a long run of them, which is what fills the HCI log with malformed ISO packets, and iso_recv() drops the SDU it is reassembling whenever handle 0 belongs to a live CIS/BIS. A zero Data_Total_Length carries no ISO Data Load, so such a packet is never part of the stream. Confirm that the rest of the transfer is zero-filled before dropping it, since the padding runs to the end of the transfer. This was observed on MT7925, but btmtk_recv_isopkt() is shared by every MediaTek USB controller that supports ISO data. Fixes: ceac1cb0259d ("Bluetooth: btusb: mediatek: add ISO data transmission functions") Co-developed-by: Hao Qin Signed-off-by: Hao Qin Co-developed-by: Wenlong Tian Signed-off-by: Wenlong Tian Signed-off-by: Chris Lu --- drivers/bluetooth/btmtk.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c index bdc85147b97f..63b4c99b20d8 100644 --- a/drivers/bluetooth/btmtk.c +++ b/drivers/bluetooth/btmtk.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include @@ -1201,6 +1202,25 @@ static int btmtk_recv_isopkt(struct hci_dev *hdev, void *buffer, int count) /* Complete ISO header */ hci_skb_expect(skb) = __le16_to_cpu(dlen); + if (!hci_skb_expect(skb)) { + /* The interrupt endpoint zero-fills the + * remainder of the transfer after the one + * packet it carries. Confirm that is what + * this is before dropping it. + */ + if (!mem_is_zero(buffer, count)) { + kfree_skb(skb); + skb = NULL; + + err = -EILSEQ; + break; + } + + kfree_skb(skb); + skb = NULL; + break; + } + if (skb_tailroom(skb) < hci_skb_expect(skb)) { kfree_skb(skb); skb = NULL; -- 2.45.2