From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.68 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792582244; b=ftXtbzCtbreSE2CnaxiDDQDnsmJOy7S+WlQFwpeIaOSGWPlhFSaQN25NPJJX/eg/QlGf d8rYTf7hqhKKJwzPfIYeI0fecR8VqOLqQ4+TN6gxZIxTFYzFko6DLXrzoKAa355iH+2SI 5ViEE4GPZkd2UFxdJOaJUx77TZ5Hit2Iihr3NHKfXiNz48Ydi8pQDYP9HHtGBpHOY6/lp 1E1tYSVc7Ef9IspiYJSAFfKg6LS4LgDFTXmxlMc/pYilOVsAqBgwP5tmo1VbC4W19Zo3Z jyzB/CmiJ1x/TyxbvTntBbkdaafxMpMo9aGALPouU6wmWYvZEH+EysPs/dhmdyiIL5Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792582244; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=U+xSPnvmF/tO+Fgf3pJ9qhNAxgNa/gXXKtkwmbQs8oM=; b=NxKN0HfWV2NIQc149DREay4DwRDMW16qXd7bWYjdukTxSsk5PSS2bWWLIungMuwdOOYs OAzK4eLmBQoFdPnmHrBrcYI0EPuKBfH8f5/+PMuNmcKSWBpY2MkxCXslzTvkQPPAgiewt rCvf/9EYy9Ac0gptVSFTB/TqeVUYhgI9MHVdYwDcB1Z1OgCvPV8dyQ//aITRoweflXHoX MxrdDdXLO94uFKgiAsKj7RsNkA+7QykQA0ByqcVDB+gmZ/J6tk6cbIjosPnAo3Rm9H1EC G6YoM8U7EzE2K0TUVCAFRl08hksLd8/2//3QwFgavnUpQ/jCzTqtn++XH/nQjYXi4VA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; arc=none smtp.remote-ip=95.215.58.68 Received: from mta1.migadu.com (out-68.mta1.migadu.com [95.215.58.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B14E606A319 for ; Wed, 21 Oct 2026 11:30:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9B14E606A319 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=ajoLYE5AD2heyAC44s3QWW8/SJdTozUgA/AhWcBRkvo=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792582235; v=1; x=1793187035; b=peV2frh87rolLVSFnvECmmtCIKSTBix8AHi94IGRwH2+Zplz/8TmlcfbFbtgWK++PPc/FcIX LF4vX1JfVq8eQAPn3Km9B4spHNUfS/5G43hyqiZ3M2xqyrStXmaDXJ780crtyJQOZLG9IS6I3x8 kHbmK8qsFXefL7HyACclAzCE= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 591aea82344d2dfa; Wed, 21 Oct 2026 11:30:20 +0000 X-Mizu-Trace-ID: 591aea82344d2dfa X-Migadu-Flow: FLOW_OUT From: Jinyu Tang To: SeungJu Cheon Cc: Jinyu Tang , anup@brainfault.org, atish.patra@linux.dev, tjytimi@163.com, inochiama@gmail.com, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, andrew.jones@linux.dev, pbonzini@redhat.com, seanjc@google.com, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] KVM: riscv: Set Accessed bit in dirty-log write fault fast path Date: Wed, 21 Oct 2026 19:30:10 +0800 Message-ID: <20261021113010.2476783-1-jinyu.tang@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016101458.221648-1-suunj1331@gmail.com> References: <20261016101458.221648-1-suunj1331@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, Oct 16, 2026 at 07:14:58PM +0900, SeungJu Cheon wrote: > @@ -591,14 +591,15 @@ static bool kvm_riscv_mmu_dirty_log_write_fault_fast(struct kvm *kvm, > dirty_marked = true; > } > > - if ((pte_val(old_pte) & (_PAGE_WRITE | _PAGE_DIRTY)) == > - (_PAGE_WRITE | _PAGE_DIRTY)) { > + if ((pte_val(old_pte) & > + (_PAGE_WRITE | _PAGE_DIRTY | _PAGE_ACCESSED)) == > + (_PAGE_WRITE | _PAGE_DIRTY | _PAGE_ACCESSED)) { > new_pte = old_pte; > ret = true; > break; > } > > - new_pte = pte_mkdirty(pte_mkwrite_novma(old_pte)); > + new_pte = pte_mkyoung(pte_mkdirty(pte_mkwrite_novma(old_pte))); I tested this on QEMU 10.2.1 with Svade enabled and Svadu disabled. With dirty logging enabled, the test clears A through page-idle tracking, write-protects the page with KVM_GET_DIRTY_LOG, and resumes the guest write. The unpatched kernel times out after 10 seconds, while the same test completes with this patch applied. Reviewed-by: Jinyu Tang Thanks, Jinyu