From: Mingyou Chen <qby140326@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilya Gladyshev" <ilya.gladyshev@linux.dev>
Cc: KentoNion <kento@kekto.ru>,
platform-driver-x86@vger.kernel.org,
"ted eric" <ericted8810@gmail.com>, "Armin Wolf" <W_Armin@gmx.de>,
linux-kernel@vger.kernel.org, "Chris Taraszka" <chris@miget.com>,
"Matias Civadda" <matias.civadda2342001@gmail.com>,
"高 俊文" <btx342@gmail.com>, powerfullz <wleizc7319@gmail.com>,
"孙 誉铭" <wolf109909@outlook.com>,
"Miloš Vlku" <vlku.milos.fun@gmail.com>, Rsplwe <i@rsplwe.com>,
"Bozhen Peng" <bozhenpeng93@gmail.com>,
"Anton Karasev" <uselessfire@gmail.com>,
"Jame Jao" <jaojame6@gmail.com>,
"Serhiy Shliapuhin" <shlyapugin@gmail.com>,
"Mingyou Chen" <qby140326@gmail.com>
Subject: [PATCH v13 7/7] platform/x86: bitland-mifs-wmi: Permit zero on SET functions
Date: Wed, 21 Oct 2026 20:34:14 +0800 [thread overview]
Message-ID: <20261021123414.25516-8-qby140326@gmail.com> (raw)
In-Reply-To: <20261021123414.25516-1-qby140326@gmail.com>
On Bitland laptops, the ACPI firmware returns 0x0000 for the function
field on SET operations, while setting the return code to success
(0x8000).
Because bitland_mifs_wmi_call() expects the returned function to match
the requested function ID, these write operations fail with -ENOMSG (-42).
Allow a return function value of 0 on SET operations to prevent false
error reports.
Fixes: dc1ec4fa86b2b ("platform/x86: bitland-mifs-wmi: Add new Bitland MIFS WMI driver")
Signed-off-by: Mingyou Chen <qby140326@gmail.com>
---
drivers/platform/x86/bitland-mifs-wmi.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/bitland-mifs-wmi.c b/drivers/platform/x86/bitland-mifs-wmi.c
index f4f37ae2f424..a4c341ffbb9b 100644
--- a/drivers/platform/x86/bitland-mifs-wmi.c
+++ b/drivers/platform/x86/bitland-mifs-wmi.c
@@ -258,10 +258,14 @@ static int bitland_mifs_wmi_call(struct bitland_mifs_wmi_data *data,
}
if (function != input->function) {
- if (!(data->quirks->accept_zero_function && function == 0))
- return -ENOMSG;
+ if (function == 0 && (data->quirks->accept_zero_function ||
+ input->operation == cpu_to_le16(WMI_METHOD_SET)))
+ goto fn_ok;
+
+ return -ENOMSG;
}
+fn_ok:
if (output) {
output->return_code = return_code;
output->function = function;
--
2.56.0
prev parent reply other threads:[~2026-10-21 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 12:34 [PATCH v13 0/7] Merge redmi-wmi into bitland-mifs-wmi Mingyou Chen
2026-10-21 12:34 ` [PATCH v13 1/7] MAINTAINERS: Add maintainer entry of bitland-mifs-wmi driver Mingyou Chen
2026-10-21 12:34 ` [PATCH v13 2/7] platform/x86: bitland-mifs-wmi: Merge the function of redmi-wmi into the bitland driver Mingyou Chen
2026-10-21 12:34 ` [PATCH v13 3/7] platform/x86: bitland-mifs-wmi: Add Redmi mic-mute key entries Mingyou Chen
2026-10-21 12:34 ` [PATCH v13 4/7] platform/x86: redmi-wmi: Drop redmi-wmi driver Mingyou Chen
2026-10-21 12:34 ` [PATCH v13 5/7] platform/x86: bitland-mifs-wmi: Add quirks table Mingyou Chen
2026-10-21 12:34 ` [PATCH v13 6/7] platform/x86: bitland-mifs-wmi: Fallback to balanced platform profile if last performance profile is not available Mingyou Chen
2026-10-21 12:34 ` Mingyou Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021123414.25516-8-qby140326@gmail.com \
--to=qby140326@gmail.com \
--cc=W_Armin@gmx.de \
--cc=bozhenpeng93@gmail.com \
--cc=btx342@gmail.com \
--cc=chris@miget.com \
--cc=ericted8810@gmail.com \
--cc=hansg@kernel.org \
--cc=i@rsplwe.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=ilya.gladyshev@linux.dev \
--cc=jaojame6@gmail.com \
--cc=kento@kekto.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=matias.civadda2342001@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=shlyapugin@gmail.com \
--cc=uselessfire@gmail.com \
--cc=vlku.milos.fun@gmail.com \
--cc=wleizc7319@gmail.com \
--cc=wolf109909@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®