From: Jakub Kicinski <kuba@kernel.org>
To: Chaosheng Qu <chaosheng.qu.linux@gmail.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
Chen-Yu Tsai <wens@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] can: don't discard the platform_get_irq() error in probe
Date: Wed, 21 Oct 2026 13:31:30 -0700 [thread overview]
Message-ID: <20261021133130.2cf75b3c@kernel.org> (raw)
In-Reply-To: <cover.1792118040.git.chaosheng.qu.linux@gmail.com>
On Fri, 16 Oct 2026 14:11:35 +0800 Chaosheng Qu wrote:
> Four CAN platform drivers collapse every failure of platform_get_irq()
> into a fixed error code:
>
> sun4i_can -ENODEV
> at91_can -ENODEV (also tests irq <= 0, which cannot happen)
> janz-ican3 -ENODEV
> ifi_canfd -EINVAL
>
> sun4i_can, at91_can and ifi_canfd match through an of_match_table, so
> of_irq_get() returns -EPROBE_DEFER while the interrupt controller has not
> been probed. The probes overwrite it and the driver core stops retrying,
> leaving the device unbound even though the interrupt controller appears
> later.
Please don't CC netdev@ on run-of-the-mill CAN patches.
Follow to MAINTAINERS / get_maintainers.pl
prev parent reply other threads:[~2026-10-21 20:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 6:11 Chaosheng Qu
2026-10-16 6:11 ` [PATCH net-next 1/4] can: sun4i_can: don't discard the IRQ lookup " Chaosheng Qu
2026-10-16 6:11 ` [PATCH net-next 2/4] can: at91_can: " Chaosheng Qu
2026-10-16 6:11 ` [PATCH net-next 3/4] can: janz-ican3: " Chaosheng Qu
2026-10-16 6:11 ` [PATCH net-next 4/4] can: ifi_canfd: " Chaosheng Qu
2026-10-16 6:15 ` [PATCH net-next 0/4] can: don't discard the platform_get_irq() " netdev-bot+sinfo
2026-10-16 7:16 ` chaosheng.qu.linux
2026-10-21 20:31 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021133130.2cf75b3c@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=chaosheng.qu.linux@gmail.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=jernej.skrabec@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=samuel@sholland.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®