From: Abdurrahman Karadag <abdurrahmankaradag19@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: pkshih@realtek.com, linux-kernel@vger.kernel.org,
rtl8821cerfe2@gmail.com
Subject: Re: [PATCH rtw-next v4] wifi: rtw88: pci: wake the TX queues after restart_hw and interface up
Date: Wed, 21 Oct 2026 18:03:27 +0300 [thread overview]
Message-ID: <20261021150327.2519860-1-abdurrahmankaradag19@gmail.com> (raw)
In-Reply-To: <d62975cc45c5b17a85f1e5cb7f9c1e326f27ffa5@linux.dev>
> The gated wake still releases that stop when a ring was left stopped.
Right, and the message should not have rested the gate on that case.
The gate is there for the common case: a start that stopped nothing
does not touch mac80211's stop reason at all, and that is every start
except one that follows a ring-full stop. After such a stop the
completion loop that would clear it cannot run - it needs a descriptor
and rtw_pci_dma_release() has already freed them - so on that path the
wake is what gets TX back.
Your case is the overlap of the two, and as you say nothing transmits
in idle. I will word it that way, and keep the v2 note that the wake
cannot be narrowed to the queue the ring-full path stopped.
next prev parent reply other threads:[~2026-10-21 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 10:13 Abdurrahman Karadag
2026-10-21 13:15 ` Luka Gejak
2026-10-21 15:03 ` Abdurrahman Karadag [this message]
2026-10-22 1:36 ` Ping-Ke Shih
2026-10-23 11:02 ` Abdurrahman Karadag
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021150327.2519860-1-abdurrahmankaradag19@gmail.com \
--to=abdurrahmankaradag19@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®