From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.197 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792596439; b=o6lplVl4/aebaYPesg7ckcgT7/BWjgA3ejrLrNoA0vyJu6/Mcv03awQnpjfp2npFp32x biRDLADwC+BUmyexg2omh6k9Q+aDraq7/u8GX2eOQbDBQ/MGUPmQIsOoigKN4SLV0oi4C r9bU19F6jr/q5BpLFFZR0+LPQcUYvaCFa4z+srsyU9MlqT0eEE+5CLTfe4pB82qy7JQnk xodo+bNYuPo0gNs/3BrsRT05YFpo8wUugssmzr6K0+GlZojCHoausm4z1KHZHNGp5hUzc O2pSvUN+Rd8WjoGKjpdIcsneqjVXBiXOzCSn+4RuOhG5saQVzQtnB7ul+s7TvwDuqdQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792596439; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:Mime-Version: X-Mailer:Message-ID:Subject:From:To:Cc:Content-Type; bh=jgAnNPRw4bl7KLoUTwKbk6oRViEcdsIxPyek4/jTHZc=; b=IuV0ya8vLJgJ7YBXsGrB9jl0wS5R2QcDs9qCSrXIaCz0fRspKtmQWIONnbdS3CJtaxYm 9QfgPqxnCbYS4HO/n+LBP+YTLwihylXJXr6FJoJt0thCy565/j1XwrAIh5klfhiZSiXZ2 bci9peRWeOw1A3ZYwx2uJ9MoS8vMpBhOGoH7bz7qsFNq5XU3l9TvvHkeFHR7dNc4RpI4C RrF5EvvB5Hft9rK7gk3K/hUcKmELtiIfid03VdGU8p1cu1QJwdT9s08hb7j+nHwPtUCfn ZgsMeuUYjCdBBPnukv5Z4IH0PqBjsTfoImfBKOSeYrpyiPPfeYjAtsLmowpGPkRaXyA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--gthelen.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=RWx0T6jq; arc=none smtp.remote-ip=74.125.82.197 Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BEDF606A321 for ; Wed, 21 Oct 2026 15:27:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6BEDF606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--gthelen.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=RWx0T6jq Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-3510d0baf63so2015200eec.1 for ; Wed, 21 Oct 2026 08:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792596438; x=1793201238; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:mime-version:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jgAnNPRw4bl7KLoUTwKbk6oRViEcdsIxPyek4/jTHZc=; b=RWx0T6jqAP4HmT2K09lvjwGaIFrNgspwI+GiEccvd37c5EIofQ2Z90i2VF0eV+9EtW QNuan04bsuIV5lePSClR20Yf54OtGxfL0UNC+1+iheIhH0M5Qv5EBYDmJ6C8S9St0NfV wQDR/4VN+ylTCPqz1GJKvI2H+gchcDZETgzsXeJzL6a2rKrM3lsTkbxRZEUopeuCnzdO +YeaVdSfb3opdL8y9vnYKrSoLD+KUp4X49ruFZOYhcXq+DrJVrgi/LWtkQ86F/296Z9I FvnVC2aJhOKeHwyRNjfNtDNCu84/oj60zWLdKJeGupNojRFVl7Rye1eL3NLIM+LEVunE zuZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792596438; x=1793201238; h=content-type:cc:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jgAnNPRw4bl7KLoUTwKbk6oRViEcdsIxPyek4/jTHZc=; b=s00tzH4Aa4k7uxh9SjXT7Kqx1iJ/IX/ek7nQR74Fy/hBDH4iLn4R6XUqAkiVjhJ5Pl afi7tmPngIKOtuW9U1/FlOfgrdL4N90tfOGE0w84zS+50qZym0S1x0V05dnMV+AZaWqg iEsHBSuVS2zQKUy3vP2ShnisxmI9IFzlRqzEB5OQXuEgFPNg25P+E74uPIB+Ca+lZQyj /oDRCb5nofnptwYqzoWw08sDPz1oO1ifZl7S9LsGvs5HUfuGwzZg78JLm8aaeWOJ+ftX Zw0WsY3CKLmiTfYmuywvVk/9fl1/kwKLDKczgxrqFENINmPtywYJcKXrlLJoDoPM44uj OFpw== X-Forwarded-Encrypted: i=1; AKwUvByqbDabAxjd/mfkcAI20ORAL3JcY0yeivzS6cl1LQuRjiac1sxEfaH9abrqVqHmkDHhbJu/WPNFquabjVw=@vger.kernel.org X-Gm-Message-State: AFq9FYKz4NjMfgSnxINbkRvDbqyNPKnhv2c070D5OQsZoimnlSagUMOC zPxwZwgCnAc8a8CvCVDCD6pGGGYdEsIAYce3Yg+qLij0KRwbHDABqydTaE5c1LoXc4Uf/DU+KX/ +pU58s0/9+A== X-Received: from dycpq4.prod.google.com ([2002:a05:7301:fd04:b0:34d:46b2:7513]) (user=gthelen job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:d185:b0:359:a6ed:41ab with SMTP id 5a478bee46e88-3674db50cd0mr3750142eec.36.1792596438073; Wed, 21 Oct 2026 08:27:18 -0700 (PDT) Date: Wed, 21 Oct 2026 08:26:58 -0700 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 X-Mailer: git-send-email 2.56.0.212.g129ede20d9-goog Message-ID: <20261021152658.2618709-1-gthelen@google.com> Subject: [PATCH net] selftests/net: tcp_mmap: remove unused -k option and keepflag From: Greg Thelen To: "David S. Miller" , Eric Dumazet Cc: Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Soheil Hassas Yeganeh , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Greg Thelen Content-Type: text/plain; charset="UTF-8" Commit aacb0c2e524c ("selftests: net: tcp_mmap must use TCP_ZEROCOPY_RECEIVE") removed the only read of keepflag in child_thread(), leaving the file-scope keepflag variable set by the -k option in main() but never read. This triggers a Clang 23 warning: tcp_mmap.c:91:12: error: variable 'keepflag' set but not used [-Werror,-Wunused-but-set-global] Remove the unused keepflag variable and the dead -k getopt option. Fixes: aacb0c2e524c ("selftests: net: tcp_mmap must use TCP_ZEROCOPY_RECEIVE") Signed-off-by: Greg Thelen --- tools/testing/selftests/net/tcp_mmap.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c index 487ae659a1f1..86241bed7f08 100644 --- a/tools/testing/selftests/net/tcp_mmap.c +++ b/tools/testing/selftests/net/tcp_mmap.c @@ -85,7 +85,6 @@ static int rcvbuf; /* Default: autotuning. Can be set with -r option static int sndbuf; /* Default: autotuning. Can be set with -w option */ static int zflg; /* zero copy option. (MSG_ZEROCOPY for sender, mmap() for receiver */ static int xflg; /* hash received data (simple xor) (-h option) */ -static int keepflag; /* -k option: receiver shall keep all received file in memory (no munmap() calls) */ static int integrity; /* -i option: sender and receiver compute sha256 over the data.*/ static size_t chunk_size = 512*1024; @@ -456,7 +455,7 @@ int main(int argc, char *argv[]) int sflg = 0; int mss = 0; - while ((c = getopt(argc, argv, "46p:svr:w:H:zxkP:M:C:a:i")) != -1) { + while ((c = getopt(argc, argv, "46p:svr:w:H:zxP:M:C:a:i")) != -1) { switch (c) { case '4': cfg_family = PF_INET; @@ -490,9 +489,6 @@ int main(int argc, char *argv[]) case 'x': xflg = 1; break; - case 'k': - keepflag = 1; - break; case 'P': max_pacing_rate = atoi(optarg) ; break; -- 2.56.0.212.g129ede20d9-goog