mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: linux-arm-kernel@lists.infradead.org
Cc: "Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Yendapally Reddy Dhananjaya Reddy"
	<yendapally.reddy@broadcom.com>,
	linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK),
	devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
	FLATTENED DEVICE TREE BINDINGS),
	linux-kernel@vger.kernel.org (open list),
	linux-usb@vger.kernel.org (open list:USB SUBSYSTEM)
Subject: [PATCH 9/9] ARM: dts: broadcom: Use noncoherent USB DMA on BCM958625HR
Date: Wed, 21 Oct 2026 10:28:18 -0700	[thread overview]
Message-ID: <20261021172819.668120-10-florian.fainelli@broadcom.com> (raw)
In-Reply-To: <20261021172819.668120-1-florian.fainelli@broadcom.com>

The USB hosts on BCM958625HR fail when using the dma-coherent properties
inherited from bcm-nsp.dtsi. xHCI aborts commands, while EHCI and OHCI
report fatal errors during enumeration and stop servicing their shared
interrupt.

Removing these properties restores high-speed USB2 device enumeration
and SuperSpeed USB3 operation on the board. Use noncoherent DMA for all
three hosts so the ARM DMA API maintains their descriptors and buffers,
as in the downstream SDK. Limit the override to the tested board.

Fixes: 56e2ff0346a3 ("ARM: dts: NSP: Add dma-coherent to relevant DT entries")
Fixes: bbe526f55b60 ("ARM: dts: NSP: Add USB3 and USB3 PHY to NSP")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 arch/arm/boot/dts/broadcom/bcm958625hr.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/broadcom/bcm958625hr.dts b/arch/arm/boot/dts/broadcom/bcm958625hr.dts
index 0105afeca748..c896c390f042 100644
--- a/arch/arm/boot/dts/broadcom/bcm958625hr.dts
+++ b/arch/arm/boot/dts/broadcom/bcm958625hr.dts
@@ -86,6 +86,7 @@ &amac2 {
 };
 
 &ehci0 {
+	/delete-property/ dma-coherent;
 	phys = <&usb3_phy>;
 	phy-names = "usb";
 	status = "okay";
@@ -130,6 +131,7 @@ partition@4000000 {
 };
 
 &ohci0 {
+	/delete-property/ dma-coherent;
 	phys = <&usb3_phy>;
 	phy-names = "usb";
 	status = "okay";
@@ -255,5 +257,6 @@ &usb3_phy {
 };
 
 &xhci {
+	/delete-property/ dma-coherent;
 	status = "okay";
 };
-- 
2.53.0


      parent reply	other threads:[~2026-10-21 17:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 17:28 [PATCH 0/9] Fix USB2 and USB3 on NSP SoCs Florian Fainelli
2026-10-21 17:28 ` [PATCH 2/9] dt-bindings: phy: bcm-ns-usb3-phy: Describe the NSP variant Florian Fainelli
2026-10-21 17:28 ` [PATCH 3/9] phy: broadcom: ns-usb3: Coordinate NSP USB2 and USB3 initialization Florian Fainelli
2026-10-21 17:28 ` [PATCH 6/9] dt-bindings: usb: generic-ehci: Add the NSP compatible Florian Fainelli
2026-10-21 17:28 ` [PATCH 7/9] usb: host: ehci-platform: Set the FIFO threshold on NSP Florian Fainelli
2026-10-21 17:28 ` [PATCH 8/9] ARM: dts: broadcom: Identify the NSP EHCI controller Florian Fainelli
2026-10-21 17:28 ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021172819.668120-10-florian.fainelli@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rafal@milecki.pl \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=stern@rowland.harvard.edu \
    --cc=vkoul@kernel.org \
    --cc=yendapally.reddy@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®