From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linusw@kernel.org>, Bartosz Golaszewski <brgl@kernel.org>
Cc: Andy Shevchenko <andy@kernel.org>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] gpiolib: use __free(gpiod_put_array) in gpiod_get_array()
Date: Wed, 21 Oct 2026 12:02:09 -0700 [thread overview]
Message-ID: <20261021190212.2237804-4-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20261021190212.2237804-1-dmitry.torokhov@gmail.com>
Switch to using __free(gpiod_put_array) scope-based cleanup facility
in gpiod_get_array(), simplifying error unwinding and eliminating manual
gpiod_put_array() calls.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/gpio/gpiolib.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 144a63e6692c..79f3be30ace1 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -5190,28 +5190,24 @@ struct gpio_descs *__must_check gpiod_get_array(struct device *dev,
enum gpiod_flags flags)
{
struct gpio_desc *desc;
- struct gpio_descs *descs;
struct gpio_device *gdev;
struct gpio_array *array_info = NULL;
int i, count, bitmap_size;
unsigned long dflags;
- size_t descs_size;
count = gpiod_count(dev, con_id);
if (count < 0)
return ERR_PTR(count);
- descs_size = struct_size(descs, desc, count);
- descs = kzalloc(descs_size, GFP_KERNEL);
+ struct gpio_descs *descs __free(gpiod_put_array) =
+ kzalloc_flex(*descs, desc, count);
if (!descs)
return ERR_PTR(-ENOMEM);
for (i = 0; i < count; i++) {
desc = gpiod_get_index(dev, con_id, i, flags);
- if (IS_ERR(desc)) {
- gpiod_put_array(descs);
+ if (IS_ERR(desc))
return ERR_CAST(desc);
- }
descs->desc[descs->ndescs++] = desc;
@@ -5222,6 +5218,7 @@ struct gpio_descs *__must_check gpiod_get_array(struct device *dev,
*/
if (i == 0 && gpiod_hwgpio(desc) == 0) {
struct gpio_descs *array;
+ size_t descs_size = struct_size(descs, desc, count);
bitmap_size = BITS_TO_LONGS(gdev->ngpio > count ?
gdev->ngpio : count);
@@ -5229,10 +5226,8 @@ struct gpio_descs *__must_check gpiod_get_array(struct device *dev,
array = krealloc(descs, descs_size +
struct_size(array_info, invert_mask, 3 * bitmap_size),
GFP_KERNEL | __GFP_ZERO);
- if (!array) {
- gpiod_put_array(descs);
+ if (!array)
return ERR_PTR(-ENOMEM);
- }
descs = array;
@@ -5293,7 +5288,7 @@ struct gpio_descs *__must_check gpiod_get_array(struct device *dev,
array_info->gdev->label, array_info->size,
*array_info->get_mask, *array_info->set_mask,
*array_info->invert_mask);
- return descs;
+ return_ptr(descs);
}
EXPORT_SYMBOL_GPL(gpiod_get_array);
--
2.56.0.307.g5fe7bd680c-goog
next prev parent reply other threads:[~2026-10-21 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 19:02 [PATCH 1/5] gpiolib: fix GPIO descriptor leak " Dmitry Torokhov
2026-10-21 19:02 ` [PATCH 2/5] gpiolib: fix fast-path cancellation " Dmitry Torokhov
2026-10-21 19:02 ` [PATCH 3/5] gpiolib: add support for scope-based management of GPIO descriptors Dmitry Torokhov
2026-10-21 19:02 ` Dmitry Torokhov [this message]
2026-10-21 19:02 ` [PATCH 5/5] gpiolib: avoid krealloc() in gpiod_get_array() Dmitry Torokhov
2026-10-21 19:34 ` Andy Shevchenko
2026-10-21 19:39 ` Andy Shevchenko
2026-10-21 19:36 ` [PATCH 1/5] gpiolib: fix GPIO descriptor leak " Andy Shevchenko
2026-10-21 19:43 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021190212.2237804-4-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=jmkrzyszt@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®