From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.51 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792695441; b=IhySwPVuj0VcGltiH2F0+7bk955K1q0R6mH1edvF589Z23huZPR4q9bdr67opDiSB2TD KGtr5nd/w/7zdbqsZN2TzUgdsSzjsYbwv9GLS4i1lqX5FTRF1YiSoDKyJ8IypFzN1WzQH Hu87/cxJjV744h+U/2ubGFue6BDUyZRh6oGuj2K6YwTfe8smL7vxFeQICT+w47g9/+Zwz E/5oKZSbz1x8m4/EmWyi91ahRkDZ2nIqcRQerBljdma3JXZbQOUtL29PC4miarMeOn9xG rHpbEYf7HLJR6XcVgRVx3qNUilnxeMg/jYafLvsLJWNkx35Lg05ceDDt1pmAMTZHeSQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792695441; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Subject:Date:Message-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:X-B4-Tracking:X-Change-ID:To:Cc:X-Mailer; bh=O1kXH2tQA49Ltlx5LN5QeX0va2Kp+8DB68xbor4uCoo=; b=5tiIumGhmUSFC4XGeJ34bY6KzIFs90AINJUKBtbofpcg9sARI4fEklbWrTFItlPCnLNg OYeOpeGbE4IIj+gBLKmTT+X4TWJyMckIIAsdJ/g4JIJB4akgUAkCvKSompPROv0f9zUYr cjlqO9LkPvLgRqxmE2xpd3WL/zJYy+Vb6nTDWecjKc5CR+NFnumyhzNSL3xyklzKFnX7e PlQd/E7KsvTWfUy699/J/RLSGXtmE9YuyaRXaHXMJu54+DzzGXe+01TCuF05dDRjlCS9F ZflXJlFv2QmNaQCV3HgCttCqSYybhUF5C5JkeUVzU5hK4NM38Uiw/lKLUk/KJuVUpIw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=NEy1i9bx; arc=none smtp.remote-ip=209.85.128.51 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFD85606A31A for ; Thu, 22 Oct 2026 18:57:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BFD85606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=NEy1i9bx Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4a1e266fca2so1073985e9.3 for ; Thu, 22 Oct 2026 11:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792695439; x=1793300239; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=O1kXH2tQA49Ltlx5LN5QeX0va2Kp+8DB68xbor4uCoo=; b=NEy1i9bxq4Qoc26+QqLZwcdLs7pIY2CXzMsUhr82UBF/r+i8at+WWXMuL5TgGWiQj7 Z5grun+t4bk6YFlbgHhVXWgd7hJisuvUc8pLHaLlXlgvuE7elR8/iWrbJmWxfFp3l8pg Aj63p4lcg2sx0XnnJ6ze0lI3Em4UDq5RMJd/88yE+xxcRZIKKbBUhWFsdGkNh5HGMteF WIchuV9dmUSLe2Q3YE5PFJmT/gkxeW1x82hmzT3Jrr7MwQTLHqou79KbBnAwkDMuS+Ed Wu/1uFoOrEZke4UMsSSflLCw7U1DIdZtLrqWjlgXz8UUdTlThPvuWVSOEgvrQztwn/o3 LWqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792695439; x=1793300239; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=O1kXH2tQA49Ltlx5LN5QeX0va2Kp+8DB68xbor4uCoo=; b=oTQbxXK+KijebULVzW3GyGuWcWMnXcyCxqLEFqKGWzKm2myCAov5rAzaPYozJHdF1k dsa+G+T1eRKrjwhO8A6ts+YW68Za2g3y4gU9wxE8wrCKNkCUzHmi6CFA9Mcq5uxo8tH1 eCkA61hvbhaS57L0TPn815faZg5mq8QxbaXCy84NH4ju/9Sge2U1zcCJKuTJmiUcErR1 rn82lYj5Ww1blfXxxdJ7UuwIFvolwfoJngFrLevWY1wM3wDQCwcQk4bRA08xiiH1ZTTd fviTJkD3zRb2Htx/BLC5/+SNdL1GdFzE1rdVhgA75cr9ygCr/z1OsVx85VqVh2oww/Mv +gMA== X-Forwarded-Encrypted: i=1; AKwUvBwxVa06UFxQbtJqLAKKSb7wNclfxPi/BYoInGPc/XLTgmwuiN3/lmBzfI1p+DBB8V/NA84zLto651pLdRo=@vger.kernel.org X-Gm-Message-State: AFq9FYLz4XoOMpZq0MZe50f1bRQLr6O40UY7xfVI5iZ0JL6iZN3EMB0b N4XsbIwMY++nX/rpNCRtxKlsHYxq0oGTQ+csgJS5XNT4brYD4Tm2h+z9PrW5Jae5E2k= X-Gm-Gg: AYBFou1MT4przSG0KzpbgyyN+QXerY4dnsMIvWaRVv0PPl7GLQyY1hZrSQKXIL/fPYd BTT3S78Px4mwW0MoTZV7Oyz2x7a2+GS4a95hylryBGOhzS3vkz52CqnN7C0KVpNd+IorRq1B4rX 29V51ERY2hSQhdtSO5r+EffJQLyp9HMZKPiC9SicmX0WQIIPJR+hGETGPrUgDuru2CW6KWE1edW wz/Cn8bJ6PdOIuehgmuXbuLQV5S6gWq2asXQabxgKPXKuXsX5zVxdlmZDmWI1jDPFgp7Od/rsOS KuOX5XdubXIJOEwY7ybwGDWeDJNur0PDFeqP4snsxJSnxJTqWYK9Zua9mZTUKZGRbuCfeb3XStV wxL+4zKLpXQ+ymh7aLd2Es9i23Mn/FyiuQd32O62UjGjXn33x9hMNVYw7NTza3FvWJxrTVJeCkJ 2KNroo+9r0SMgT4y8YLubyxdZR2+iAmpW9Lj1njCGZ8rfhPMEwZ3LCgK0qce2TVreULS5FF8spL kpLmsj1FGxOarVjbLBi2kzwVqj9mWdhgjhBgAc/0hRbrJvxFnUPfw== X-Received: by 2002:a05:600d:4443:20b0:4a2:1a:a120 with SMTP id 5b1f17b1804b1-4a2001aa3f1mr83811875e9.6.1792695438824; Thu, 22 Oct 2026 11:57:18 -0700 (PDT) Received: from localhost ([2a02:8308:b092:fd00:d900:ff27:14a1:f032]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e379f4993sm154745f8f.42.2026.10.22.11.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 11:57:18 -0700 (PDT) From: Jan Remes Subject: [PATCH v4 0/4] iio: light: tsl2591: fix lux calculation and precision, add I2C ID table, report saturation Date: Thu, 22 Oct 2026 20:56:39 +0200 Message-Id: <20261022-first-patch-v4-0-90b2fc6e8e28@mycroftmind.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/1WOyw6CMBBFf4V0bUkZHlpX/IdxUUqBUaCkrY2E8 O8WSIxmVie599xZiFUGlSXXaCFGebSoxwDZKSKyE2OrKNaBCTAoEpZktEFjHZ2Ekx2FlHEuC8a gFiQ0JqMafO+22/1g+6oeSrpNsSU6tE6beZ/zsOW+5nBFzmLIOQdOEypRPL3oy3YQ2MdSD2RT+ vSnBPD3jk8po9WZg7pwkQEX5TBLoxs34FgfhnVdP5XOrUvzAAAA X-Change-ID: 20261014-first-patch-23099c6002da To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Joe Sandom Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Remes , Jonathan Cameron , stable@vger.kernel.org, Martin Triska , Andy Shevchenko X-Mailer: b4 0.16.0 This series fixes several issues found while using the TSL2591 in company products (Raspberry Pi CM5) and when testing (x86_64 laptops with MCP2221 USB-I2C bridge). The original field report found that the illumination value has always been 0.0 (caused by division by zero on ARM). Patch 1 fixes divisions by zero in the lux calculation, which occur with LOW gain and short integration times, or in darkness when CH0 = 0. Patch 2 adds an i2c_device_id table so the driver can be matched by name (e.g. via sysfs new_device) on kernels without CONFIG_OF. Patch 3 makes the driver return an error instead of a bogus value when the sensor is saturated. Patch 4 improves the formula for calculating lux values to make the returned value more accurate. Patches 3 and 4 change existing behavior, I am OK with splitting the series into two, if that makes things better. AI assistance: Claude Code (Claude Opus 5.5) was used for research on sensor behavior, datasheets and Adafruit library, to compare results produced by old and new formula, to draft some code for patches 1 and 4. I reviewed all of it and tested it on x86_64. --- Changes in v4: - no changes in the code - drop "Assisted-by: LLM" tags (Andy) - Patch 2: make commit message more to the point (Andy) - Link to v3: https://patch.msgid.link/20261022-first-patch-v3-0-b792e89a429a@mycroftmind.com Changes in v3: - Patch 2: Fix commit message, OF-only drivers can still be enumerated via DT or ACPI (PRP0001), only matching by name needs the I2C ID table (Andy) - Patch 2: Drop Andy's Reviewed-by - Rebase on current iio/testing - Link to v2: https://patch.msgid.link/20261014141650.259929-1-ciakval@gmail.com Changes in v2 (thanks to Andy Shevchenko for review): - Patch 2: Use C99 initializers - Patch 4: Keep variables in reversed xmas tree order - Link to v1: https://lore.kernel.org/r/20261013143943.436816-1-ciakval@gmail.com/ To: Jonathan Cameron To: David Lechner To: Nuno Sá To: Andy Shevchenko To: Joe Sandom Cc: Jonathan Cameron Cc: linux-iio@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Jan Remes --- Jan Remes (4): iio: light: tsl2591: don't divide by zero iio: light: tsl2591: add I2C device ID table iio: light: tsl2591: report saturation iio: light: tsl2591: improve lux calculation precision drivers/iio/light/tsl2591.c | 58 ++++++++++++++++++++++++++++++++------------- 1 file changed, 42 insertions(+), 16 deletions(-) --- base-commit: 87e28db23d0384f3995c43ecc5ae2118b371edb5 change-id: 20261014-first-patch-23099c6002da Best regards, -- Jan Remes