From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Jai Luthra <jai.luthra@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Alexander Shiyan <eagle.alexander923@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: [PATCH v6 09/18] media: sony-starvis2: Use pm_runtime_autosuspend
Date: Thu, 22 Oct 2026 18:34:02 +0100 [thread overview]
Message-ID: <20261022-media-starvis2-v6-9-374343f55fd3@raspberrypi.com> (raw)
In-Reply-To: <20261022-media-starvis2-v6-0-374343f55fd3@raspberrypi.com>
In order to reduce the time in stopping and restarting
streaming, use pm_runtime_autosuspend so the sensor
isn't powered down.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/media/i2c/sony-starvis2.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/sony-starvis2.c b/drivers/media/i2c/sony-starvis2.c
index 95da8a9e671e..27357cc293be 100644
--- a/drivers/media/i2c/sony-starvis2.c
+++ b/drivers/media/i2c/sony-starvis2.c
@@ -858,7 +858,7 @@ static int starvis2_set_ctrl(struct v4l2_ctrl *ctrl)
break;
}
- pm_runtime_put(&client->dev);
+ pm_runtime_put_autosuspend(&client->dev);
return ret;
}
@@ -1049,7 +1049,7 @@ static int starvis2_enable_streams(struct v4l2_subdev *sd,
return 0;
err_rpm_put:
- pm_runtime_put(&client->dev);
+ pm_runtime_put_autosuspend(&client->dev);
return ret;
}
@@ -1072,7 +1072,7 @@ static int starvis2_disable_streams(struct v4l2_subdev *sd,
__v4l2_ctrl_grab(starvis2->link_freq, false);
- pm_runtime_put(&client->dev);
+ pm_runtime_put_autosuspend(&client->dev);
return ret;
}
@@ -1447,7 +1447,10 @@ static int starvis2_probe(struct i2c_client *client)
NULL);
pm_runtime_set_active(dev);
+ pm_runtime_get_noresume(dev);
pm_runtime_enable(dev);
+ pm_runtime_set_autosuspend_delay(dev, 1000);
+ pm_runtime_use_autosuspend(dev);
ret = starvis2_init_controls(starvis2);
if (ret)
@@ -1479,7 +1482,7 @@ static int starvis2_probe(struct i2c_client *client)
goto error_subdev_cleanup;
}
- pm_runtime_idle(dev);
+ pm_runtime_put_autosuspend(dev);
return 0;
@@ -1494,7 +1497,8 @@ static int starvis2_probe(struct i2c_client *client)
error_pm_runtime:
pm_runtime_disable(&client->dev);
- pm_runtime_set_suspended(&client->dev);
+ pm_runtime_put_noidle(dev);
+ pm_runtime_dont_use_autosuspend(&client->dev);
error_power_off:
starvis2_power_off(&client->dev);
@@ -1516,6 +1520,7 @@ static void starvis2_remove(struct i2c_client *client)
if (!pm_runtime_status_suspended(&client->dev))
starvis2_power_off(&client->dev);
pm_runtime_set_suspended(&client->dev);
+ pm_runtime_dont_use_autosuspend(&client->dev);
}
static const struct dev_pm_ops starvis2_pm_ops = {
--
2.34.1
next prev parent reply other threads:[~2026-10-22 17:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 17:33 [PATCH v6 00/18] Update imx678 to act as a common Sony Starvis 2 driver Dave Stevenson
2026-10-22 17:33 ` [PATCH v6 01/18] media: imx678: Rework into generic Starvis 2 sensor driver Dave Stevenson
2026-10-22 17:33 ` [PATCH v6 02/18] media: sony-starvis2: Reorder link frequencies to remove lookup Dave Stevenson
2026-10-22 17:33 ` [PATCH v6 03/18] media: sony-starvis2: Always program the sensor in window mode Dave Stevenson
2026-10-22 17:33 ` [PATCH v6 04/18] media: sony-starvis2: Parameterise the configuration to allow for other models Dave Stevenson
2026-10-22 17:33 ` [PATCH v6 05/18] media: sony-starvis2: Rework 2 lane support for higher link freqs Dave Stevenson
2026-10-22 17:33 ` [PATCH v6 06/18] media: sony-starvis2: Allow runtime control of link frequency Dave Stevenson
2026-10-22 17:34 ` [PATCH v6 07/18] media: sony-starvis2: Correct the exposure range Dave Stevenson
2026-10-22 17:34 ` [PATCH v6 08/18] media: sony-starvis2: Put module into standby after identify Dave Stevenson
2026-10-22 17:34 ` Dave Stevenson [this message]
2026-10-22 17:34 ` [PATCH v6 10/18] media: dt-bindings: sony,imx678: Add other Starvis 2 family members Dave Stevenson
2026-10-22 17:34 ` [PATCH v6 11/18] media: sony-starvis2: Add support for IMX662 Dave Stevenson
2026-10-22 17:34 ` [PATCH v6 12/18] media: sony-starvis2: Add support for IMX675 Dave Stevenson
2026-10-22 17:34 ` [PATCH v6 13/18] media: sony-starvis2: Add support for IMX832 Dave Stevenson
2026-10-22 17:34 ` [PATCH v6 14/18] media: sony-starvis2: Only update bits for window mode Dave Stevenson
2026-10-22 17:34 ` [PATCH v6 15/18] media: sony-starvis2: Parameterise exposure min and step Dave Stevenson
2026-10-22 17:34 ` [PATCH v6 16/18] media: sony-starvis2: Parameterise the mono ID register Dave Stevenson
2026-10-22 17:34 ` [PATCH v6 17/18] media: sony-starvis2: Add support for IMX585 Dave Stevenson
2026-10-22 17:34 ` [PATCH v6 18/18] media: sony-starvis2: Add support for IMX676 Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022-media-starvis2-v6-9-374343f55fd3@raspberrypi.com \
--to=dave.stevenson@raspberrypi.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eagle.alexander923@gmail.com \
--cc=jai.luthra@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®