From: Krzysztof Kozlowski <krzk@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
"Hal Feng" <hal.feng@starfivetech.com>
Subject: Re: [PATCH v1 1/2] dt-bindings: pwm: opencores: Add starfive,jhb100-pwm
Date: Thu, 22 Oct 2026 11:54:03 +0200 [thread overview]
Message-ID: <20261022-sincere-glossy-goshawk-00d1f5@quoll> (raw)
In-Reply-To: <20261019110855.52420-2-changhuang.liang@starfivetech.com>
On Mon, Oct 19, 2026 at 04:08:54AM -0700, Changhuang Liang wrote:
> Add a new compatible string "starfive,jhb100-pwm" for the PWM
> controller found on the StarFive JHB100 SoC.
>
> The StarFive JHB100 PWM is based on the OpenCores PWM v1 controller
> but with a modification: the polarity has been changed from inverted
> to normal. The generic opencores,pwm-v1 hardware only supports
> inverted polarity, so the JHB100 variant cannot reuse the
> "opencores,pwm-v1" fallback and must be described with a standalone
> compatible string.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
> .../devicetree/bindings/pwm/opencores,pwm.yaml | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-22 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 11:08 [PATCH v1 0/2] Add PWM support for JHB100 SoC Changhuang Liang
2026-10-19 11:08 ` [PATCH v1 1/2] dt-bindings: pwm: opencores: Add starfive,jhb100-pwm Changhuang Liang
2026-10-22 9:54 ` Krzysztof Kozlowski [this message]
2026-10-19 11:08 ` [PATCH v1 2/2] pwm: ocores: Add support for StarFive JHB100 PWM polarity Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022-sincere-glossy-goshawk-00d1f5@quoll \
--to=krzk@kernel.org \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hal.feng@starfivetech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®