From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.198 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792646570; b=lciDDQUPmQzXVC4JaF6eIndua1Zna2qh5lVKZZEU4I+xZGoOxp33FQdR95zEaqeerS1H 3XXr25xOn7vsDPK2lqsJMYgmvurrXYkliL2SgCwcymPSrlls0Re9RCHGzgG6+02SCaNtw uxsQcTFmRSw3NsEiQYlvAofP+M/xBzr4836ZH7NtHaZy/aGNBvAHo/K+HUVL6q9gNWd8H +I+nZZoCPUNrGH52HWKltjI6XoqqbSsz/h+aF5aLwLAHaC25iRzgR4swOSWDHo5aVrfgB lcKR1flgFuUNQUdS/hVwDMdZCR8dzPRXV8cW3PqlbPYhyKkICBCOsAlqtdIu5lZkcKQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792646570; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:Mime-Version: X-Mailer:Message-ID:Subject:From:To:Cc:Content-Type; bh=i0ib49ykkVTIXodpiuOe5mlbictVGMpVlOsQqgxbR10=; b=4DPbK/7dAEPXr0lZJj0DG+1SZDwft6v/taG4mtTGK7X6NRzxVaUS1AKaGRGdw3JM82GL C7kEzN8ZIzkFS38OyOwXY2NPkFk1qAnc1aH1t/LFAQkd1++YFGbk97kGT2d1RaHHF1aBp 25zCW+HYSk7ybhhVljR8icnYDrWBnndXZ9k0F0UUH3tUiGg8vYBMXNZEBFrnRlbtp4OmY uQB9HEgRCObwAvld/NLgn2bwYektfL4Uk8BRvDXvs08sEFIT/x6KNXDSBdty2+aQfiZ/9 GNN9LfWgpCpP18YcEzLpEJM8NdzLbDkDmzHDFjHcXJl7aCiGpAuv3+HYyCllJXZk3VQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--chihsheng.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=rM7fLbxE; arc=none smtp.remote-ip=209.85.210.198 Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12092606A319 for ; Thu, 22 Oct 2026 05:22:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 12092606A319 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--chihsheng.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=rM7fLbxE Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8a0522cdaf3so1118618b3a.0 for ; Wed, 21 Oct 2026 22:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792646569; x=1793251369; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:mime-version:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=i0ib49ykkVTIXodpiuOe5mlbictVGMpVlOsQqgxbR10=; b=rM7fLbxEmxtqe2XJH1ckPcC/HR+nt8Dd4dtFlo7ZfuauTjoo8LBPk7DWoCc0/T6azY LuATYY3nULYR2Pgqc0FtNZuzTZYgUrotN30vkn+Sd3jq4fQ8zzcXziUCYcECp+RxVvjY P2WZyj5iatmlIlFph2BMkt2BfewIw7LrGyPHqWdRMyKXnP1Jhq1MeLbyPiMpRUYUKJZk ftKIPeL1MQ29kyleADBfHaNJyxbntfwffdwd+PbJaANkENTMH3si7SSaLQO6vdRVdWRN 2qq0FmwkVFDhXbSext4RGrSBHXVtg1tQhSneW0IUk8rtfNN6Srk2KL0CZzSIkY3mR8XR PrNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792646569; x=1793251369; h=content-type:cc:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=i0ib49ykkVTIXodpiuOe5mlbictVGMpVlOsQqgxbR10=; b=DV/feluw60DzzPyBXimCb26eKqQGkokHhP5jMNN4Uw5UULk3Trrwh7cTppHzlDh3/O FJd6uIFxaxwkrl27tLAYpFbwRCf5XArVAjfA6YwaQn39ctw2Lmq8fm9HSvjnkjrzzbxJ hKwdqOZcUGu1XWn/RLu1sIm4AdDw3uzgVVz5XvmQ3U9nGkxBtskvc/qwaHg+VpWxY6Y1 rjaYTa8XSUCx/I1GVMjSHH0dWVISa2hPsf0yEXt+/ktU79/Rrh7+vl20T0siIXCNCRyM KFUIqanvCyI5Xmn8a9UVRXhmono8HWsCX8d8oz5wQE5BjUY07ve0Off1YEpSlrYApXWT 5gJg== X-Forwarded-Encrypted: i=1; AKwUvBxaQsNLV1d+wC9bp7z3slMb0IlxSLpr2DfOBkgkyxb92THGZyD2MFwjI6U7izmZKwFBHfyQr1XF3ZeskPc=@vger.kernel.org X-Gm-Message-State: AFq9FYI5LYcbgAENzTB7lpoO2V01xVqHVsgZSXiuzLAVYNaSUuVyTHge 0v5Zpx/7skDAk0Hj+RarOFEvHQKOXN6pYeq+9XBcLvlK5Dvg8jkwLqjAA/n5ThevWIQ09GgOyfi oXW1tbtYGyfyJV05S6w== X-Received: from pfwo8.prod.google.com ([2002:a05:6a00:1bc8:b0:8a2:1bc3:8884]) (user=chihsheng job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:349a:b0:881:4b47:f31a with SMTP id d2e1a72fcca58-8a089cdf1a4mr3211775b3a.11.1792646569217; Wed, 21 Oct 2026 22:22:49 -0700 (PDT) Date: Thu, 22 Oct 2026 05:22:44 +0000 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 X-Mailer: git-send-email 2.56.0.257.gf7497c7d27-goog Message-ID: <20261022052245.1138709-1-chihsheng@google.com> Subject: [PATCH 1/2] selftests/cpu-hotplug: Use $(id -u) instead of $UID for root check From: Darren Chang To: shuah@kernel.org, david@kernel.org, osalvador@suse.de Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Darren Chang Content-Type: text/plain; charset="UTF-8" $UID is a bash-specific variable and is not defined in other shells such as Android's /system/bin/sh (mksh) or POSIX sh. When running this test on environments without bash (e.g. Android), $UID is unset and '[ $UID != 0 ]' expands to '[ != 0 ]', causing a syntax error. Replace $UID with "$(id -u)" so the root privilege check works across different shells. Signed-off-by: Darren Chang --- tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh b/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh index 287cfd5809f6..6653507b9348 100755 --- a/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh +++ b/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh @@ -10,7 +10,7 @@ prerequisite() { msg="skip all tests:" - if [ $UID != 0 ]; then + if [ "$(id -u)" -ne 0 ]; then echo $msg must be run as root >&2 exit $ksft_skip fi -- 2.56.0.257.gf7497c7d27-goog