From: Cheng Yongkang <teel4res@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
bridge@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [BUG] net: bridge: MST bypasses blocking when VLAN filtering is off
Date: Thu, 22 Oct 2026 02:15:01 -0700 [thread overview]
Message-ID: <20261022091501.3650765-1-teel4res@gmail.com> (raw)
Hi all,
MST can be enabled while VLAN filtering is disabled and no port VLAN
entries exist. nbp_vlan_init() still installs a port VLAN group, so
br_mst_is_enabled() returns true even though BROPT_VLAN_ENABLED is off.
With that configuration:
ingress skips the normal p->state check and forces forwarding
br_allowed_ingress() accepts the unfiltered frame
br_allowed_egress() accepts the unfiltered frame
A port in BR_STATE_BLOCKING therefore still forwards data in both
directions. STP/MRP loop protection is defeated.
Observed on Linux v7.3, commit
08ab31164c55f20c7a2653de3186ae333470e2c1, with
vlan_filtering=0, default_pvid=0, mst_enabled=1, and a port whose
IFLA_BRPORT_STATE read back as BR_STATE_BLOCKING:
MST on: egress=3 ingress=3
MST off: egress=0 ingress=0
MST on: egress=3 ingress=3
Each direction sent three matching broadcast frames. This is a
deterministic configuration/state mismatch, not a race.
The MST fast path should require both MST and VLAN filtering, while
retaining the existing non-NULL port VLAN-group lifetime check. The
MST configuration itself should also be rejected if it is unusable with
VLAN filtering disabled.
CVE-2025-40297 used the same broad predicate for a port-deletion UAF,
but its fix only added the vlgrp lifetime check. The normal data-plane
forwarding bypass remains in current source; I found no separate fix or
CVE.
The test used a diagnostic switchdev endpoint only to establish the MRP
ring state. It did not replace bridge, VLAN, MST or packet-forwarding
code.
The PoC and full program/console logs are available on request.
This was found with a multi-agent workflow; the
forwarding differential was reproduced in QEMU.
Thanks,
Cheng Yongkang
reply other threads:[~2026-10-22 9:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022091501.3650765-1-teel4res@gmail.com \
--to=teel4res@gmail.com \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®